From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B6D3C433F5 for ; Mon, 25 Oct 2021 21:17:57 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED6AA60C51 for ; Mon, 25 Oct 2021 21:17:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ED6AA60C51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 82B00832C4; Mon, 25 Oct 2021 23:17:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="sGMbRdD0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A10483535; Mon, 25 Oct 2021 23:17:24 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6EA9383381 for ; Mon, 25 Oct 2021 23:17:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id j12so13204139qkk.5 for ; Mon, 25 Oct 2021 14:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v+9paet9Jo9509MvsZN31TmwBLTrm3nhOPKdnPIxDj0=; b=sGMbRdD0/UV2cM4gboqnBEEtsA8YbeOBx4b6t/orwPtHKkld2ZtY2jg/SZv9At8QP4 pGNu2KrYMVD9+skZUImpd5+3lb83ChOgrGgS1sGAEO8u9PISr6AQApZQ2FEvMs5dk9UK shlnoo7d8LC7ZJ7hlkjBBeIHSW8u2jJmS3bBU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v+9paet9Jo9509MvsZN31TmwBLTrm3nhOPKdnPIxDj0=; b=BBY/KDvHw+45qACkYXAv937tGHrFVNzHr41bCg/inC1GMGgJl4fz1uhv2XhtSD3Ser D6twLWKnbXFF2xv+XJRpG7p+OXuHqnbn2NNIUeRD5TqmvVJX8Z183PT6f0s0NSMNrdRU fq039PlLLLKGMHm1a6Plo6vsl+ItCzsU2Ga3w1w2z8wzlEeXqKpcgqGtFsNQOLbqfj4F TuWlGetxJVu1CAT4krb979f0llMIy5VpeoZHMEjvZtuwjJcVVk4FKVQ0NByGtX6uiVdJ gGzfjMHY8QW81QYA3QVZfoIxWbDTpUK606NTfgVTf3ra24p8ZvSN0GbXb30g905kqN4k tViw== X-Gm-Message-State: AOAM530J9RY1//q/40mgh9C7KTCCzGVIGrEDUKgL/0mh7oI7uTik55vD Vh0wYRwekcBg/UdVJ4HeBoUrdQ== X-Google-Smtp-Source: ABdhPJwDcG5kUjtTo01PT732FKc/GN8xNQTpGnzuFB5jcISrzbAN1HP1ctz9LpGpAxc+yWHhMPmxkA== X-Received: by 2002:a37:d09:: with SMTP id 9mr15711322qkn.409.1635196637918; Mon, 25 Oct 2021 14:17:17 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-c992-6a97-7d08-4b0c.res6.spectrum.com. [2603:6081:7b01:cbda:c992:6a97:7d08:4b0c]) by smtp.gmail.com with ESMTPSA id k8sm8970547qth.2.2021.10.25.14.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 14:17:17 -0700 (PDT) Date: Mon, 25 Oct 2021 17:17:13 -0400 From: Tom Rini To: Ilias Apalodimas Cc: sjg@chromium.org, Patrick Delaunay , Patrice Chotard , Liviu Dudau , Thomas Fitzsimmons , Matthias Brugger , Michal Simek , Pali =?iso-8859-1?Q?Roh=E1r?= , Marek =?iso-8859-1?Q?Beh=FAn?= , Bin Meng , Heinrich Schuchardt , Stefan Roese , Tim Harvey , Harald Seiler , Sughosh Ganu , Priyanka Jain , Vladimir Oltean , Andre Przywara , Ramon Fried , Nicolas Saenz Julienne , Peter Robinson , "Ivan T. Ivanov" , Marek Szyprowski , Zong Li , Leo Yu-Chi Liang , Sean Anderson , Rick Chen , Green Wan , T Karthik Reddy , Ashok Reddy Soma , Rasmus Villemoes , Alper Nebi Yasak , AKASHI Takahiro , Wasim Khan , Alexandru Gagniuc , Nandor Han , Pratyush Yadav , Steffen Jaeckel , Heiko Schocher , Asherah Connor , u-boot@lists.denx.de, uboot-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v4] sandbox: Remove OF_HOSTFILE Message-ID: <20211025211713.GA1992726@bill-the-cat> References: <20211019130725.171193-1-ilias.apalodimas@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: <20211019130725.171193-1-ilias.apalodimas@linaro.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailman-Approved-At: Mon, 25 Oct 2021 23:17:52 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 19, 2021 at 04:07:21PM +0300, Ilias Apalodimas wrote: > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > unique and not causing any confusions, we are better of having simpler > config options for the DTB. >=20 > So let's replace that with the existing OF_BOARD. U-Boot would then > have only three config options for the DTB origin. > - OF_SEPARATE, build separately from U-Boot > - OF_BOARD, board specific way of providing the DTB > - OF_EMBED embedded in the u-boot binary(should not be used in production >=20 > Signed-off-by: Ilias Apalodimas > Reviewed-by: Simon Glass This doesn't build on riscv: +(ae350_rv64) board/AndesTech/ax25-ae350/ax25-ae350.c:57:7: error: conflict= ing types for 'board_fdt_blob_setup'; have 'void *(void)' +(ae350_rv64) 57 | void *board_fdt_blob_setup(void) +(ae350_rv64) | ^~~~~~~~~~~~~~~~~~~~ +(ae350_rv64) In file included from include/asm-generic/global_data.h:23, +(ae350_rv64) from arch/riscv/include/asm/global_data.h:35, +(ae350_rv64) from include/init.h:21, +(ae350_rv64) from board/AndesTech/ax25-ae350/ax25-ae350.c= :10: +(ae350_rv64) include/fdtdec.h:1164:7: note: previous declaration of 'board= _fdt_blob_setup' with type 'void *(int *)' +(ae350_rv64) 1164 | void *board_fdt_blob_setup(int *err); +(ae350_rv64) board/AndesTech/ax25-ae350/ax25-ae350.c: In function 'board_f= dt_blob_setup': +(ae350_rv64) board/AndesTech/ax25-ae350/ax25-ae350.c:59:10: error: 'err' u= ndeclared (first use in this function); did you mean 'errno'? +(ae350_rv64) 59 | *err =3D 0; +(ae350_rv64) | ^~~ +(ae350_rv64) | errno +(ae350_rv64) board/AndesTech/ax25-ae350/ax25-ae350.c:59:10: note: each und= eclared identifier is reported only once for each function it appears in +(ae350_rv64) make[2]: *** [scripts/Makefile.build:254: board/AndesTech/ax2= 5-ae350/ax25-ae350.o] Error 1 +(ae350_rv64) make[1]: *** [Makefile:1801: board/AndesTech/ax25-ae350] Erro= r 2 +(ae350_rv64) make: *** [Makefile:177: sub-make] Error 2 --=20 Tom --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF3HtYACgkQFHw5/5Y0 tyyxHwv8DbBlDiUk1CW5VPrkU6p/ZoP2l7As0drMLOfsonoOSpJ2m8II4+ryWyul ioaQmmWyt9QNnwDqtM9Qsh0lhFKZVRgT4ZVWN5N0X85/dMBHxwg/S+9Bt+HDH3AZ VbYSsjYY32DZnX1biRTlFN4RXSjw4bHymMN08txo99nNXg9no01Ptjgdp60GxttO V2FRsMLWv4HbiPgpJ96g3k1D3KfYz1zb4V3GuXsts+5zuS4xP06m6V6wA/hTjTFK f9YFZUujReG5Qe1IVyc37PpDG/EBhS825/08J/CrkUv30wLscEdFAgO/yQ9/6qOT Vvnen1R5CO+RhlBIGsW8+lEdf4nE4m/EXkImL1Yt5iv6INgLwy16Wj+z0x4lOZii evZygcJ38hHjzXWkQXM3do+9rutLHn85GtV29rCIN/nTf6BqEi85Us7woiyoTY8j DVR1wp2CYY1YxJWRtYrD+aiIkTqzHstEN85dbbbObDMN6RD3UJC+bdLkqhdDSs9c x0QQfZe6 =P/1z -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--