From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E01C433F5 for ; Tue, 26 Oct 2021 08:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64BD760E75 for ; Tue, 26 Oct 2021 08:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234008AbhJZIg5 (ORCPT ); Tue, 26 Oct 2021 04:36:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:56242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232001AbhJZIgv (ORCPT ); Tue, 26 Oct 2021 04:36:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9C8B360FE8; Tue, 26 Oct 2021 08:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635237268; bh=aqX/BUKmfRta3pa2yzNOCRTmiB629p+qvxg28trH85k=; h=From:To:Cc:Subject:Date:From; b=iNJHjft9O86KkRz1OcOu6OlAUgJTcpntFvQIEV3zRcSmiDlHR9wHIh2oKUmeftdmZ fDZvWx4W/ZgFPMiM0fLzo+s8oD4uw6V2/VxrhDCicRY1czWpHU6VtwVcOL4uZ+L952 Y3PJcyLBWwrxQP+MbLX3jnNmjqCn8eksHoYTKgW6JBbh9X84YW5nJYIgX+4xcEKy3X T3XpgTNXz9Tr1GMgom3opfnJ9F/WTpluH0aTyEq4Yd+DBbujOsqhIJKfob2LLB6q6d JyrFWvbQmabjCL5a+M1rcn++qxb8dwe9k3cYNyaZQ+LT+iDcx7/boLm52YFmb1Hd+D 8r32CVf7MC1KQ== From: Arnd Bergmann To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Matthew Auld , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= Cc: Arnd Bergmann , Chris Wilson , Jason Ekstrand , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/i915/dmabuf: include asm/smp.h for cache operations Date: Tue, 26 Oct 2021 10:34:16 +0200 Message-Id: <20211026083423.3461555-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann The x86 low-level cache management operations are declared in asm/smp.h, so drivers that call into this code need to include the header: drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:248:3: error: implicit declaration of function 'wbinvd_on_all_cpus' [-Werror,-Wimplicit-function-declaration] wbinvd_on_all_cpus(); ^ Fixes: a035154da45d ("drm/i915/dmabuf: add paranoid flush-on-acquire") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c index 1adcd8e02d29..853a989fcb9b 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c @@ -7,6 +7,7 @@ #include #include #include +#include #include "i915_drv.h" #include "i915_gem_object.h" -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B169C433EF for ; Tue, 26 Oct 2021 12:10:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5961361179 for ; Tue, 26 Oct 2021 12:10:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5961361179 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D96096E429; Tue, 26 Oct 2021 12:10:10 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6DD4E6E442; Tue, 26 Oct 2021 08:34:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9C8B360FE8; Tue, 26 Oct 2021 08:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635237268; bh=aqX/BUKmfRta3pa2yzNOCRTmiB629p+qvxg28trH85k=; h=From:To:Cc:Subject:Date:From; b=iNJHjft9O86KkRz1OcOu6OlAUgJTcpntFvQIEV3zRcSmiDlHR9wHIh2oKUmeftdmZ fDZvWx4W/ZgFPMiM0fLzo+s8oD4uw6V2/VxrhDCicRY1czWpHU6VtwVcOL4uZ+L952 Y3PJcyLBWwrxQP+MbLX3jnNmjqCn8eksHoYTKgW6JBbh9X84YW5nJYIgX+4xcEKy3X T3XpgTNXz9Tr1GMgom3opfnJ9F/WTpluH0aTyEq4Yd+DBbujOsqhIJKfob2LLB6q6d JyrFWvbQmabjCL5a+M1rcn++qxb8dwe9k3cYNyaZQ+LT+iDcx7/boLm52YFmb1Hd+D 8r32CVf7MC1KQ== From: Arnd Bergmann To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Matthew Auld , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= Cc: Arnd Bergmann , Chris Wilson , Jason Ekstrand , =?UTF-8?q?Christian=20K=C3=B6nig?= , Maarten Lankhorst , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Tue, 26 Oct 2021 10:34:16 +0200 Message-Id: <20211026083423.3461555-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 26 Oct 2021 12:10:09 +0000 Subject: [Intel-gfx] [PATCH] drm/i915/dmabuf: include asm/smp.h for cache operations X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Arnd Bergmann The x86 low-level cache management operations are declared in asm/smp.h, so drivers that call into this code need to include the header: drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:248:3: error: implicit declaration of function 'wbinvd_on_all_cpus' [-Werror,-Wimplicit-function-declaration] wbinvd_on_all_cpus(); ^ Fixes: a035154da45d ("drm/i915/dmabuf: add paranoid flush-on-acquire") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c index 1adcd8e02d29..853a989fcb9b 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c @@ -7,6 +7,7 @@ #include #include #include +#include #include "i915_drv.h" #include "i915_gem_object.h" -- 2.29.2