All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Rakesh Babu <rsaladi2@marvell.com>
Cc: <sgoutham@marvell.com>, <gakula@marvell.com>,
	<sbhatta@marvell.com>, <hkelam@marvell.com>,
	<davem@davemloft.net>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [net-next PATCH v2 1/3] octeontx2-af: debugfs: Minor changes.
Date: Tue, 26 Oct 2021 14:13:05 -0700	[thread overview]
Message-ID: <20211026141305.0739a59e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20211026121814.27036-2-rsaladi2@marvell.com>

On Tue, 26 Oct 2021 17:48:12 +0530 Rakesh Babu wrote:
> This patch also has the null pointer check in rvu_nix.c file.

You need to explain why, and why is that not a fix, just a cosmetic
change. Same for the ret < 0 check. And please break those out to
separate patches.

  reply	other threads:[~2021-10-26 21:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 12:18 [net-next PATCH v2 0/3] RVU Debugfs updates Rakesh Babu
2021-10-26 12:18 ` [net-next PATCH v2 1/3] octeontx2-af: debugfs: Minor changes Rakesh Babu
2021-10-26 21:13   ` Jakub Kicinski [this message]
2021-10-26 12:18 ` [net-next PATCH v2 2/3] octeontx2-af: cn10k: debugfs for dumping LMTST map table Rakesh Babu
2021-10-26 12:18 ` [net-next PATCH v2 3/3] octeontx2-af: debugfs: Add channel and channel mask Rakesh Babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211026141305.0739a59e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rsaladi2@marvell.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.