All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manish Chopra <manishc@marvell.com>
To: <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <stable@vger.kernel.org>,
	<aelior@marvell.com>, <skalluru@marvell.com>,
	<malin1024@gmail.com>, <smalin@marvell.com>,
	<okulkarni@marvell.com>, <njavali@marvell.com>,
	<GR-everest-linux-l2@marvell.com>
Subject: [PATCH net-next 2/2] bnx2x: Invalidate fastpath HSI version for VFs
Date: Tue, 26 Oct 2021 12:37:17 -0700	[thread overview]
Message-ID: <20211026193717.2657-2-manishc@marvell.com> (raw)
In-Reply-To: <20211026193717.2657-1-manishc@marvell.com>

Commit 0a6890b9b4df ("bnx2x: Utilize FW 7.13.15.0.")
added validation for fastpath HSI versions for different
client init which was not meant for SR-IOV VF clients, which
resulted in firmware asserts when running VF clients with
different fastpath HSI version.

This patch along with the new firmware support in patch #1
fixes this behavior in order to not validate fastpath HSI
version for the VFs.

Fixes: 0a6890b9b4df ("bnx2x: Utilize FW 7.13.15.0.")
Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Omkar Kulkarni <okulkarni@marvell.com>
Signed-off-by: Shai Malin <smalin@marvell.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
index 9c2f51f23035..b1817f5e6179 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
@@ -758,9 +758,17 @@ static void bnx2x_vf_igu_reset(struct bnx2x *bp, struct bnx2x_virtf *vf)
 
 void bnx2x_vf_enable_access(struct bnx2x *bp, u8 abs_vfid)
 {
+	u16 abs_fid;
+
+	abs_fid = FW_VF_HANDLE(abs_vfid);
+
 	/* set the VF-PF association in the FW */
-	storm_memset_vf_to_pf(bp, FW_VF_HANDLE(abs_vfid), BP_FUNC(bp));
-	storm_memset_func_en(bp, FW_VF_HANDLE(abs_vfid), 1);
+	storm_memset_vf_to_pf(bp, abs_fid, BP_FUNC(bp));
+	storm_memset_func_en(bp, abs_fid, 1);
+
+	/* Invalidate fp_hsi version for vfs */
+	REG_WR8(bp,
+		BAR_XSTRORM_INTMEM + XSTORM_ETH_FUNCTION_INFO_FP_HSI_VALID_E2_OFFSET(abs_fid), 0);
 
 	/* clear vf errors*/
 	bnx2x_vf_semi_clear_err(bp, abs_vfid);
-- 
2.27.0


  reply	other threads:[~2021-10-26 19:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 19:37 [PATCH net-next 1/2] bnx2x: Utilize firmware 7.13.20.0 Manish Chopra
2021-10-26 19:37 ` Manish Chopra [this message]
2021-10-26 20:05   ` [PATCH net-next 2/2] bnx2x: Invalidate fastpath HSI version for VFs Greg KH
2021-10-26 20:05 ` [PATCH net-next 1/2] bnx2x: Utilize firmware 7.13.20.0 Greg KH
2021-10-26 20:30   ` [EXT] " Manish Chopra
2021-10-27  5:01     ` Greg KH
2021-10-26 21:07 ` Jakub Kicinski
2021-10-27  5:17   ` [EXT] " Ariel Elior
2021-10-27 12:18     ` Andrew Lunn
2021-10-27 14:03     ` Jakub Kicinski
2021-10-27 14:39       ` Andrew Lunn
2021-10-28  8:31       ` Ariel Elior
2021-11-08 11:02         ` Manish Chopra
2021-11-08 13:44           ` Andrew Lunn
2021-11-08 15:44             ` Ariel Elior
2021-11-08 21:52               ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211026193717.2657-2-manishc@marvell.com \
    --to=manishc@marvell.com \
    --cc=GR-everest-linux-l2@marvell.com \
    --cc=aelior@marvell.com \
    --cc=kuba@kernel.org \
    --cc=malin1024@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=njavali@marvell.com \
    --cc=okulkarni@marvell.com \
    --cc=skalluru@marvell.com \
    --cc=smalin@marvell.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.