From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 061F6C433F5 for ; Tue, 26 Oct 2021 22:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5E3D60F02 for ; Tue, 26 Oct 2021 22:21:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239938AbhJZWYP (ORCPT ); Tue, 26 Oct 2021 18:24:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:43722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235758AbhJZWYN (ORCPT ); Tue, 26 Oct 2021 18:24:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E2BAD60F02; Tue, 26 Oct 2021 22:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635286909; bh=Ti9ROmEWB++H0DVAD/4QLbK3bMpQv6DTgwhjoKZgM3Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PcI2FaCRlJY+KWzLUhYhOcAar43cbCPaiPFaGHtK9GQiTU5oUu5Cg99gBUjLkKFDY tsN2yWVZsuWG3Ldj/Eqxztu7tqHfh7OuGgEb9ljzY1EB3AiFARjrB2lR/PhwkmxHaY istohXv3cDHFL4Oz43TW05RJHlKH4+npN5TIF+kxSxOwART2KIjH3FajjF63TN3Iq5 7pIc3qIGTRh/KW7iiKIHsUTid1qRNbfxJJbd5S8tasOWHQ5fLcLUvwQp0l/7lM9KTV uxMaXqC+YxKabTJKA8IM7Q9sguYdy/4/br4qcOeCjOKvp2Tu/6EIjzwfrUpOtrvaV7 ghfJpn4scpUdg== Date: Tue, 26 Oct 2021 17:21:47 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "l.stach@pengutronix.de" , "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" , "linux-pci@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up Message-ID: <20211026222147.GA173173@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 25, 2021 at 02:35:36AM +0000, Richard Zhu wrote: > > -----Original Message----- > > From: Krzysztof Wilczyński > > Sent: Saturday, October 23, 2021 5:54 PM > > To: Richard Zhu > > Cc: Bjorn Helgaas ; l.stach@pengutronix.de; > > bhelgaas@google.com; lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; > > dl-linux-imx ; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; kernel@pengutronix.de > > Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling > > unbalance when link never came up > > I hope you don't mind me asking, but how is an empty default case in the > > switch statement helping IMX6Q and IMX6QP? What does it achieve for > > these two controllers specifically? > > > [Richard Zhu] Never mind. 😊. > There might be following building warning if the "default:break" is removed. > " CC drivers/pci/controller/dwc/pci-imx6.o > drivers/pci/controller/dwc/pci-imx6.c: In function ‘imx6_pcie_clk_disable’: > drivers/pci/controller/dwc/pci-imx6.c:527:2: warning: enumeration value ‘IMX6Q’ not handled in switch [-Wswitch] > 527 | switch (imx6_pcie->drvdata->variant) { > | ^~~~~~ > drivers/pci/controller/dwc/pci-imx6.c:527:2: warning: enumeration value ‘IMX6QP’ not handled in switch [-Wswitch]" Sorry, I didn't see this until after asking the same question as Krzysztof. Sigh. That's a really annoying gcc warning, but I guess I won't fight it ;) Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B3EAC433EF for ; Tue, 26 Oct 2021 22:23:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4899F61002 for ; Tue, 26 Oct 2021 22:23:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4899F61002 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=xpu9WimQvwhR+VGmyv8pOlvAqfXCukoUyJTNp4R2cdE=; b=xZP6FQOvwe17kY 1mDH3c7/XgvwBLRQykebCRzt1/tXwufFVb9zvkbIoTmS5xSue7E0MMhFRzWVRKr2JZu20i+3eclgB xvuWDPpuiQYlL9VTFE08G0rR6Q71eYTqdJDiJFRX4UIyn/rS2reDb3UxNezANQ9zm+hYHYMjc8j4f w/aXU+a59oNOn25VkaKDFNRaWoyjpGAzSemdVFsUiKn7MKOGEmO92x/ikmEJl0fZ+y3axzkWj7a2O 2UMLbgrRCmqwJV02sRElR2hkT37P/jdSxMRvkvMO2NE1nmOJHCxfQ1fFik7rAQa4bfFg9Tr9HJb3g XuLo4GMFLYS3ThwqofQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfUpN-003D1z-K4; Tue, 26 Oct 2021 22:21:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfUpJ-003D1g-MW for linux-arm-kernel@lists.infradead.org; Tue, 26 Oct 2021 22:21:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E2BAD60F02; Tue, 26 Oct 2021 22:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635286909; bh=Ti9ROmEWB++H0DVAD/4QLbK3bMpQv6DTgwhjoKZgM3Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PcI2FaCRlJY+KWzLUhYhOcAar43cbCPaiPFaGHtK9GQiTU5oUu5Cg99gBUjLkKFDY tsN2yWVZsuWG3Ldj/Eqxztu7tqHfh7OuGgEb9ljzY1EB3AiFARjrB2lR/PhwkmxHaY istohXv3cDHFL4Oz43TW05RJHlKH4+npN5TIF+kxSxOwART2KIjH3FajjF63TN3Iq5 7pIc3qIGTRh/KW7iiKIHsUTid1qRNbfxJJbd5S8tasOWHQ5fLcLUvwQp0l/7lM9KTV uxMaXqC+YxKabTJKA8IM7Q9sguYdy/4/br4qcOeCjOKvp2Tu/6EIjzwfrUpOtrvaV7 ghfJpn4scpUdg== Date: Tue, 26 Oct 2021 17:21:47 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "l.stach@pengutronix.de" , "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" , "linux-pci@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up Message-ID: <20211026222147.GA173173@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211026_152149_802532_22B7F7CD X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBPY3QgMjUsIDIwMjEgYXQgMDI6MzU6MzZBTSArMDAwMCwgUmljaGFyZCBaaHUgd3Jv dGU6Cj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJvbTogS3J6eXN6dG9mIFdp bGN6ecWEc2tpIDxrd0BsaW51eC5jb20+Cj4gPiBTZW50OiBTYXR1cmRheSwgT2N0b2JlciAyMywg MjAyMSA1OjU0IFBNCj4gPiBUbzogUmljaGFyZCBaaHUgPGhvbmd4aW5nLnpodUBueHAuY29tPgo+ ID4gQ2M6IEJqb3JuIEhlbGdhYXMgPGhlbGdhYXNAa2VybmVsLm9yZz47IGwuc3RhY2hAcGVuZ3V0 cm9uaXguZGU7Cj4gPiBiaGVsZ2Fhc0Bnb29nbGUuY29tOyBsb3JlbnpvLnBpZXJhbGlzaUBhcm0u Y29tOyBsaW51eC1wY2lAdmdlci5rZXJuZWwub3JnOwo+ID4gZGwtbGludXgtaW14IDxsaW51eC1p bXhAbnhwLmNvbT47IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsKPiA+IGxp bnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGtlcm5lbEBwZW5ndXRyb25peC5kZQo+ID4gU3Vi amVjdDogUmU6IFtSRVNFTkQgdjIgNC81XSBQQ0k6IGlteDY6IEZpeCB0aGUgY2xvY2sgcmVmZXJl bmNlIGhhbmRsaW5nCj4gPiB1bmJhbGFuY2Ugd2hlbiBsaW5rIG5ldmVyIGNhbWUgdXAKCj4gPiBJ IGhvcGUgeW91IGRvbid0IG1pbmQgbWUgYXNraW5nLCBidXQgaG93IGlzIGFuIGVtcHR5IGRlZmF1 bHQgY2FzZSBpbiB0aGUKPiA+IHN3aXRjaCBzdGF0ZW1lbnQgaGVscGluZyBJTVg2USBhbmQgSU1Y NlFQPyAgV2hhdCBkb2VzIGl0IGFjaGlldmUgZm9yCj4gPiB0aGVzZSB0d28gY29udHJvbGxlcnMg c3BlY2lmaWNhbGx5Pwo+ID4gCj4gW1JpY2hhcmQgWmh1XSBOZXZlciBtaW5kLiDwn5iKLgo+IFRo ZXJlIG1pZ2h0IGJlIGZvbGxvd2luZyBidWlsZGluZyB3YXJuaW5nIGlmIHRoZSAiZGVmYXVsdDpi cmVhayIgaXMgcmVtb3ZlZC4KPiAiICBDQyAgICAgIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdj L3BjaS1pbXg2Lm8KPiBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jOiBJbiBm dW5jdGlvbiDigJhpbXg2X3BjaWVfY2xrX2Rpc2FibGXigJk6Cj4gZHJpdmVycy9wY2kvY29udHJv bGxlci9kd2MvcGNpLWlteDYuYzo1Mjc6Mjogd2FybmluZzogZW51bWVyYXRpb24gdmFsdWUg4oCY SU1YNlHigJkgbm90IGhhbmRsZWQgaW4gc3dpdGNoIFstV3N3aXRjaF0KPiAgIDUyNyB8ICBzd2l0 Y2ggKGlteDZfcGNpZS0+ZHJ2ZGF0YS0+dmFyaWFudCkgewo+ICAgICAgIHwgIF5+fn5+fgo+IGRy aXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmM6NTI3OjI6IHdhcm5pbmc6IGVudW1l cmF0aW9uIHZhbHVlIOKAmElNWDZRUOKAmSBub3QgaGFuZGxlZCBpbiBzd2l0Y2ggWy1Xc3dpdGNo XSIKClNvcnJ5LCBJIGRpZG4ndCBzZWUgdGhpcyB1bnRpbCBhZnRlciBhc2tpbmcgdGhlIHNhbWUg cXVlc3Rpb24gYXMKS3J6eXN6dG9mLgoKU2lnaC4gIFRoYXQncyBhIHJlYWxseSBhbm5veWluZyBn Y2Mgd2FybmluZywgYnV0IEkgZ3Vlc3MgSSB3b24ndCBmaWdodAppdCA7KQoKQmpvcm4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK