From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7549FC433F5 for ; Wed, 27 Oct 2021 15:29:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CB07610A4 for ; Wed, 27 Oct 2021 15:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236313AbhJ0PbY (ORCPT ); Wed, 27 Oct 2021 11:31:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55886 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237661AbhJ0PbX (ORCPT ); Wed, 27 Oct 2021 11:31:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635348538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+eOillqFEGpQrQ9kkKK0BfuXxzIsa8E5TGrBm3ktydM=; b=H+CnqbAa0p5JnVPUHXooFLyzl03TGPKcYSjoxjTlWdnLfNsBESQZhn0PeK9qg5okUP29ru BRcN91EVbfc3UtMkrVPP+kZWJ8u2gmKm4pcAV1WtbatWaQLF/8rHDnFfgvyLvfv6GcccoH jbyMGITE490jrN31qjG4QNaKoxOeTak= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-MZJ1EHYSPU2G1Ddx8gicqg-1; Wed, 27 Oct 2021 11:28:57 -0400 X-MC-Unique: MZJ1EHYSPU2G1Ddx8gicqg-1 Received: by mail-wm1-f69.google.com with SMTP id a18-20020a1cf012000000b0032ca3eb2ac3so1344226wmb.0 for ; Wed, 27 Oct 2021 08:28:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+eOillqFEGpQrQ9kkKK0BfuXxzIsa8E5TGrBm3ktydM=; b=uXyyAzcxN7+iuCOPpPiETOB3z3krAjKpgunjB/rFd6Vox2P+rIOrL5/ZZpUsRCxK6a iueGEMgwO0GJ7Gz577elrTPelEP0au7oWEONRpU9wfvHq0tLE5DN82rhhR1mBTwxO9On Gy794Us0yzuoS/lhiJEP4OLLOcQlsavSv+cWfhZkc95EefOMVnDPDtJxmIVgJ9Ja5JKC fRhNLIHCp2Yq45p0D7UR9+5zAbuaTK2+XYnynFeuIP9/nqY5/KfzSHf99xFdckyMescT 9/Ho97UVft6ovd0uB0HSw5M5sGj8XIyORloxZsSnq8JWKI3ybT/EWX1Ucsg6/g21UoV4 NHXQ== X-Gm-Message-State: AOAM532/e0AsREYlaTaeH231rjjyGJtXy70kslaUBol+JMDAxizPU4k8 J//zdaFSN4cxIHzFBwCiJ8x6wZRcFN+0+80zt4CaCo3mkB1Lj21+5LcByCKcgPVuT4mZF13Ju/1 /cimDw8rm8qpTf+OgQL+rbcty X-Received: by 2002:a1c:f614:: with SMTP id w20mr6399598wmc.71.1635348534961; Wed, 27 Oct 2021 08:28:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx48Ekpj4clqe1b4A9LimmYmVc0qkpR7dH4dZiC/yCaw0YSOKIQftxe1BzKC6UMOGCBceazlw== X-Received: by 2002:a1c:f614:: with SMTP id w20mr6399567wmc.71.1635348534771; Wed, 27 Oct 2021 08:28:54 -0700 (PDT) Received: from redhat.com ([2a03:c5c0:207e:a543:72f:c4d1:8911:6346]) by smtp.gmail.com with ESMTPSA id o10sm173398wrx.64.2021.10.27.08.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 08:28:54 -0700 (PDT) Date: Wed, 27 Oct 2021 11:28:48 -0400 From: "Michael S. Tsirkin" To: Dmitry Vyukov Cc: Laurent Vivier , syzbot , davem@davemloft.net, herbert@gondor.apana.org.au, jiri@nvidia.com, kuba@kernel.org, leonro@nvidia.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, mpm@selenic.com, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] KASAN: slab-out-of-bounds Read in copy_data Message-ID: <20211027111300-mutt-send-email-mst@kernel.org> References: <000000000000a4cd2105cf441e76@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Oct 27, 2021 at 03:36:19PM +0200, Dmitry Vyukov wrote: > On Wed, 27 Oct 2021 at 15:11, Laurent Vivier wrote: > > > > On 26/10/2021 18:39, syzbot wrote: > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit: 9ae1fbdeabd3 Add linux-next specific files for 20211025 > > > git tree: linux-next > > > console output: https://syzkaller.appspot.com/x/log.txt?x=1331363cb00000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=aeb17e42bc109064 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=b86736b5935e0d25b446 > > > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=116ce954b00000 > > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=132fcf62b00000 > > > > > > The issue was bisected to: > > > > > > commit 22849b5ea5952d853547cc5e0651f34a246b2a4f > > > Author: Leon Romanovsky > > > Date: Thu Oct 21 14:16:14 2021 +0000 > > > > > > devlink: Remove not-executed trap policer notifications > > > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=137d8bfcb00000 > > > final oops: https://syzkaller.appspot.com/x/report.txt?x=10fd8bfcb00000 > > > console output: https://syzkaller.appspot.com/x/log.txt?x=177d8bfcb00000 > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > > Reported-by: syzbot+b86736b5935e0d25b446@syzkaller.appspotmail.com > > > Fixes: 22849b5ea595 ("devlink: Remove not-executed trap policer notifications") > > > > > > ================================================================== > > > BUG: KASAN: slab-out-of-bounds in memcpy include/linux/fortify-string.h:225 [inline] > > > BUG: KASAN: slab-out-of-bounds in copy_data+0xf3/0x2e0 drivers/char/hw_random/virtio-rng.c:68 > > > Read of size 64 at addr ffff88801a7a1580 by task syz-executor989/6542 > > > > > > > I'm not able to reproduce the problem with next-20211026 and the C reproducer. > > > > And reviewing the code in copy_data() I don't see any issue. > > > > Is it possible to know what it the VM configuration used to test it? > > Hi Laurent, > > syzbot used e2-standard-2 GCE VM when that happened. > You can see some info about these VMs under the "VM info" link on the dashboard. Could you pls confirm whether reverting caaf2874ba27b92bca6f0298bf88bad94067ec37 addresses this?