From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E07AC433EF for ; Wed, 27 Oct 2021 17:36:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45A2C60F02 for ; Wed, 27 Oct 2021 17:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243323AbhJ0RjO (ORCPT ); Wed, 27 Oct 2021 13:39:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:44406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236251AbhJ0RjM (ORCPT ); Wed, 27 Oct 2021 13:39:12 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF6D160EFF; Wed, 27 Oct 2021 17:36:45 +0000 (UTC) Date: Wed, 27 Oct 2021 13:36:44 -0400 From: Steven Rostedt To: Kalesh Singh Cc: Masami Hiramatsu , surenb@google.com, hridya@google.com, namhyung@kernel.org, kernel-team@android.com, Jonathan Corbet , Ingo Molnar , Shuah Khan , Tom Zanussi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 7/8] tracing/selftests: Add tests for hist trigger expression parsing Message-ID: <20211027133644.2a8ab22c@gandalf.local.home> In-Reply-To: <20211027113416.fdad2adf8d162e67405e44ba@kernel.org> References: <20211025200852.3002369-1-kaleshsingh@google.com> <20211025200852.3002369-8-kaleshsingh@google.com> <20211026214311.583c728d90d41778c38201dd@kernel.org> <20211027113416.fdad2adf8d162e67405e44ba@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Oct 2021 11:34:16 +0900 Masami Hiramatsu wrote: > > Hi Masami, > > > > Thanks for the feedback. The above change is to ensure we remove > > triggers in the reverse order that we created them - important when > > one trigger depends on another. > > Hi Kalesh, > That's a good reason to make this an independent patch :) > > > I can split it out into a separate > > patch and will add a README pattern check to the requires tag for > > these tests. Kalesh, As you may have noticed, I pulled in all the patches in this series but this selftests patch. Please rebase your updates as requested by Masami on top of my for-next branch, which can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git Thanks! -- Steve