All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH linux-next] ext4: Remove unnecessary assignments
@ 2021-10-28  2:44 luo penghao
  0 siblings, 0 replies; only message in thread
From: luo penghao @ 2021-10-28  2:44 UTC (permalink / raw)
  To: Theodore Ts'o
  Cc: Andreas Dilger, linux-ext4, linux-kernel, luo penghao, Zeal Robot

The assignment at the end of the function is not necessary

The clang_analyzer complains as follows:

fs/ext4/mballoc.c:3889:3 warning:

Value stored to 'err' is never read

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
---
 fs/ext4/mballoc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 089c958..f1258a7 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3886,7 +3886,7 @@ void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
 	if (err)
 		goto out_err;
 	sync_dirty_buffer(bitmap_bh);
-	err = ext4_handle_dirty_metadata(NULL, NULL, gdp_bh);
+	ext4_handle_dirty_metadata(NULL, NULL, gdp_bh);
 	sync_dirty_buffer(gdp_bh);
 
 out_err:
-- 
2.15.2



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-28  2:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-28  2:44 [PATCH linux-next] ext4: Remove unnecessary assignments luo penghao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.