All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pkrempa@redhat.com, berrange@redhat.com,
	ehabkost@redhat.com, qemu-block@nongnu.org, quintela@redhat.com,
	libvir-list@redhat.com, eblake@redhat.com, kchamart@redhat.com,
	mdroth@linux.vnet.ibm.com, dgilbert@redhat.com,
	pbonzini@redhat.com, marcandre.lureau@redhat.com,
	philmd@redhat.com, jsnow@redhat.com, libguestfs@redhat.com
Subject: [PATCH v2 3/9] qapi: Eliminate QCO_NO_OPTIONS for a slight simplification
Date: Thu, 28 Oct 2021 12:25:14 +0200	[thread overview]
Message-ID: <20211028102520.747396-4-armbru@redhat.com> (raw)
In-Reply-To: <20211028102520.747396-1-armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
 include/qapi/qmp/dispatch.h | 1 -
 monitor/misc.c              | 3 +--
 scripts/qapi/commands.py    | 5 +----
 3 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/include/qapi/qmp/dispatch.h b/include/qapi/qmp/dispatch.h
index 075203dc67..0ce88200b9 100644
--- a/include/qapi/qmp/dispatch.h
+++ b/include/qapi/qmp/dispatch.h
@@ -21,7 +21,6 @@ typedef void (QmpCommandFunc)(QDict *, QObject **, Error **);
 
 typedef enum QmpCommandOptions
 {
-    QCO_NO_OPTIONS            =  0x0,
     QCO_NO_SUCCESS_RESP       =  (1U << 0),
     QCO_ALLOW_OOB             =  (1U << 1),
     QCO_ALLOW_PRECONFIG       =  (1U << 2),
diff --git a/monitor/misc.c b/monitor/misc.c
index ffe7966870..3556b177f6 100644
--- a/monitor/misc.c
+++ b/monitor/misc.c
@@ -230,8 +230,7 @@ static void monitor_init_qmp_commands(void)
 
     qmp_init_marshal(&qmp_commands);
 
-    qmp_register_command(&qmp_commands, "device_add", qmp_device_add,
-                         QCO_NO_OPTIONS);
+    qmp_register_command(&qmp_commands, "device_add", qmp_device_add, 0);
 
     QTAILQ_INIT(&qmp_cap_negotiation_commands);
     qmp_register_command(&qmp_cap_negotiation_commands, "qmp_capabilities",
diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py
index 3654825968..c8a975528f 100644
--- a/scripts/qapi/commands.py
+++ b/scripts/qapi/commands.py
@@ -229,15 +229,12 @@ def gen_register_command(name: str,
     if coroutine:
         options += ['QCO_COROUTINE']
 
-    if not options:
-        options = ['QCO_NO_OPTIONS']
-
     ret = mcgen('''
     qmp_register_command(cmds, "%(name)s",
                          qmp_marshal_%(c_name)s, %(opts)s);
 ''',
                 name=name, c_name=c_name(name),
-                opts=" | ".join(options))
+                opts=' | '.join(options) or 0)
     return ret
 
 
-- 
2.31.1



  parent reply	other threads:[~2021-10-28 10:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 10:25 [PATCH v2 0/9] Configurable policy for handling unstable interfaces Markus Armbruster
2021-10-28 10:25 ` [PATCH v2 1/9] qapi: New special feature flag "unstable" Markus Armbruster
2021-10-28 10:25 ` [PATCH v2 2/9] qapi: Mark unstable QMP parts with feature 'unstable' Markus Armbruster
2021-10-28 10:25 ` Markus Armbruster [this message]
2021-10-28 10:25 ` [PATCH v2 4/9] qapi: Tools for sets of special feature flags in generated code Markus Armbruster
2021-10-29 10:32   ` Juan Quintela
2021-10-29 11:33   ` Philippe Mathieu-Daudé
2021-10-28 10:25 ` [PATCH v2 5/9] qapi: Generalize struct member policy checking Markus Armbruster
2021-10-29 10:42   ` Juan Quintela
2021-10-29 13:22     ` Markus Armbruster
2021-10-29 13:31   ` Philippe Mathieu-Daudé
2021-10-29 14:01     ` Markus Armbruster
2021-10-29 16:11       ` Philippe Mathieu-Daudé
2021-10-29 15:20   ` Eric Blake
2021-10-29 15:34     ` Markus Armbruster
2021-10-29 16:13       ` Philippe Mathieu-Daudé
2021-10-28 10:25 ` [PATCH v2 6/9] qapi: Generalize command " Markus Armbruster
2021-10-29 10:44   ` Juan Quintela
2021-10-29 15:28   ` Eric Blake
2021-10-29 16:11     ` Philippe Mathieu-Daudé
2021-10-28 10:25 ` [PATCH v2 7/9] qapi: Generalize enum member " Markus Armbruster
2021-10-29 11:31   ` Philippe Mathieu-Daudé
2021-10-28 10:25 ` [PATCH v2 8/9] qapi: Factor out compat_policy_input_ok() Markus Armbruster
2021-10-29 16:55   ` Markus Armbruster
2021-10-29 17:01     ` Philippe Mathieu-Daudé
2021-10-28 10:25 ` [PATCH v2 9/9] qapi: Extend -compat to set policy for unstable interfaces Markus Armbruster
2021-10-29 15:10   ` Eric Blake
2021-10-29 15:15     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211028102520.747396-4-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=libguestfs@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.