From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E2ADC433FE for ; Thu, 28 Oct 2021 14:19:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A1FB61073 for ; Thu, 28 Oct 2021 14:19:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231132AbhJ1OWU (ORCPT ); Thu, 28 Oct 2021 10:22:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbhJ1OWT (ORCPT ); Thu, 28 Oct 2021 10:22:19 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 081AFC061570; Thu, 28 Oct 2021 07:19:52 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id v127so5949788wme.5; Thu, 28 Oct 2021 07:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w9dCLGXOlRDJmVPN1HJBPCtrX5Y3dq1CeosXfwTmTIE=; b=MZZW77BM7jF65T9itFpM6n7U5dNOUA1+IJ2d8FO0oyqoTXflUpdwut867AadkBdvOf MdACiu8DDmGMF+ElH9PG5i8Vech57XSQftI0CPVl/H/Lw/Vm1dOXi+WEMpTh9jUyQiki 4IGL04gs8riaamW4lCTxL2bq0QDsXJGQKdGw7lKFv4+GZlRw4q7G23uXPqU+6333/Jht FAL+5sTiLuJhnGZUX+lOTCNtQeJwivdpuzCv9KhQTKrVTHEgBBCUCzuAh7vcvujktWcX FFZ08vnnBqfrGGnGqgBZTDNN5sWGI3Xa1pIT5tRBF+AQbPK+usl8k/O8qrjp212PEG6D MhLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w9dCLGXOlRDJmVPN1HJBPCtrX5Y3dq1CeosXfwTmTIE=; b=R0DJ6x2YdBfBZrJCo7kuYuJjSDpz0Kz36jHzHcI41bKnGA7T047Dhwh7oGkrYpWD7Y Pclqm/s0sMjVAYqJsjJSj2aMys6kUKoQMIQuil35jSs7L8NBmS8y+PfzobWd7vSXCunb 5iI3hS9SOCg+DkMMEJQ7CGLtm2tX5tbJ7ZjC8t3cMviFyWKoSD01RBLC5BQawmCzc9fW 9FgyX7nO2AFs0RSu+oEvPUJvgSoAZrZ2vn6JRVL8rHhahHdPN5lznlcf8KtEcOV2tB4U yL158bhPBGNNVY+sojSjhdiotZiXrHtiYKtqecncsna1f4DY3OAlz35mQiFYeSuoYNt0 YFCg== X-Gm-Message-State: AOAM532ghWgiW43L+qgOr6Pp6aJ2eqTT8NMuarJEVbUaQRH5RE7E30mi qjQ51L0lX89mTAGKu2YCVfM= X-Google-Smtp-Source: ABdhPJzg6/fblA82QiNOpf6te3qmuIz0aMLwxzyCLkqjiM6kfgiHZAu7QfphRHWjzrEyKfVdfQhyfQ== X-Received: by 2002:a05:600c:2288:: with SMTP id 8mr13025376wmf.40.1635430790515; Thu, 28 Oct 2021 07:19:50 -0700 (PDT) Received: from localhost.localdomain (i5C74E249.versanet.de. [92.116.226.73]) by smtp.gmail.com with ESMTPSA id m2sm6284546wml.15.2021.10.28.07.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 07:19:50 -0700 (PDT) From: Lukas Bulwahn To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH 00/13] Kconfig symbol clean-up on ./arch/arm{64} Date: Thu, 28 Oct 2021 16:19:25 +0200 Message-Id: <20211028141938.3530-1-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear arm maintainers, The script ./scripts/checkkconfigsymbols.py warns on invalid references to Kconfig symbols (often: minor typos, name confusions or outdated references). This is a patch series addressing the issues reported by ./scripts/checkkconfigsymbols.py in the ./arch/arm{64}/ directories, quickly filtered down with: ./scripts/checkkconfigsymbols.py | grep "arch/arm" -B 1 -A 2 without considering kernel configs, i.e., after removing arch/arm{64}/configs in the working tree. It addresses some issues I considered to be "true positives"; so, issues that should be addressed and cleaned up. The patches on updating the comments might arguably be considered of lower value by itself, but as the other patches show, checkkconfigsymbols does detect some relevant issues in the kernel tree otherwise being unnoticed. So, it might be worth to clean up the kernel tree to have checkkconfigsymbols produce a rather short list of issues and then continuously follow and check what checkkconfigsymbols reports. Some work from checkkconfigsymbols on arch/arm/ is deferred; the other remaining issues that checkkconfigsymbols reports are (as far as I understand it now) "false positives", i.e., the tool misinterprets the actual content) or "intentional", e.g., they refer to historic configs for the purpose of documentation (e.g., in changelogs) or are in various kernel configs that are not continuously updated to match the current set of kernel configs. You can see below a grouped list of remaining reports. Each patch in this series can be discussed and applied individually if needed. They are sent in one patch series, as they all orginate from the investigation guided by the same tool and hence share similar topics and resolutions. Please pick this series of minor clean-up patches on ./arch/arm{64}/. It applies cleanly on next-20211027. Best regards, Lukas Remaining reports from ./scripts/checkkconfigsymbols.py pointing to files in ./arch/arm{64}/ (excluding configs), grouped by the rationale why it is not addressed in this patch series: - Reference in historic comment: ARM_NR_BANKS Referencing files: arch/arm/mach-exynos/exynos.c CPU Referencing files: arch/arm/lib/backtrace.S, arch/arm/lib/csumpartialcopyuser.S, arch/arm/mach-rpc/ecard-loader.S, arch/arm/mach-rpc/io-acorn.S, arch/arm/nwfpe/fpmodule.h CPU_ARM92{0,2,5,6}_CPU_IDLE Referencing files: arch/arm/mm/proc-arm92{0,2,5,6}.S KVM_INDIRECT_VECTORS Referencing files: arch/arm64/kvm/hyp/nvhe/host.S - Use of CONFIG_* environment variable beyond the definition in Kconfig scripts AS_DMB_ISHLD Referencing files: arch/arm64/include/asm/vdso/compat_barrier.h, arch/arm64/kernel/vdso32/Makefile CC_HAS_K_CONSTRAINT Referencing files: arch/arm64/Makefile, arch/arm64/include/asm/atomic_ll_sc.h SHELL Ignore CONFIG_SHELL. Default variable in Kbuild build system. - Parsing Mistake (Incomplete parsing heuristics) by checkkconfigsymbols.py: ASC1, ASC2, SBC, UART Referencing files: arch/arm/Kconfig.debug - Future work to send clean-up patches: IRDA{_MODULE} Referencing files: arch/arm/mach-pxa/balloon3.c, arch/arm/mach-pxa/palm27x.c, arch/arm/mach-pxa/palm27x.h, arch/arm/mach-pxa/palmtc.c, include/linux/atalk.h, include/linux/netdevice.h PXA_FICP{_MODULE} Referencing files: arch/arm/mach-pxa/spitz.c DEBUG_LL_SER3 Referencing files: arch/arm/boot/compressed/head.S already discussed in 2014: https://lore.kernel.org/all/1400055127.31197.1.camel@x220/ Lukas Bulwahn (13): arm: debug: remove obsolete debug code for DEBUG_ZTE_ZX arm: debug: reuse the config DEBUG_OMAP2UART{1,2} for OMAP{3,4,5} arm: Kconfig.debug: drop reference to removed ARCH_MSM arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 arm: davinci: remove reference to obsolete BLK_DEV_PALMCHIP_BK3710 arm: ixp4xx: remove dead configs CPU_IXP43X and CPU_IXP46X arm: imx: remove dead left-over from i.MX{27,31,35} removal arm: imx: rename DEBUG_IMX21_IMX27_UART to DEBUG_IMX27_UART arm: milbeaut: remove select of non-existing PINCTRL_MILBEAUT arm: nomadik: drop selecting obsolete CLKSRC_NOMADIK_MTU_SCHED_CLOCK arm: npcm: drop selecting non-existing ARM_ERRATA_794072 arm: socfpga: always select PL310_ERRATA_753970 arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment arch/arm/Kconfig.debug | 28 ++++++++++------------- arch/arm/include/debug/imx-uart.h | 18 +++++++-------- arch/arm/include/debug/pl01x.S | 7 ------ arch/arm/kernel/bios32.c | 2 -- arch/arm/mach-davinci/board-dm644x-evm.c | 3 +-- arch/arm/mach-davinci/board-dm646x-evm.c | 3 +-- arch/arm/mach-davinci/board-neuros-osd2.c | 3 +-- arch/arm/mach-imx/Kconfig | 12 ---------- arch/arm/mach-imx/Makefile | 2 -- arch/arm/mach-ixp4xx/Kconfig | 13 ----------- arch/arm/mach-milbeaut/Kconfig | 1 - arch/arm/mach-nomadik/Kconfig | 1 - arch/arm/mach-npcm/Kconfig | 1 - arch/arm/mach-socfpga/Kconfig | 2 +- arch/arm/mm/pgd.c | 2 +- 15 files changed, 26 insertions(+), 72 deletions(-) -- 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D8DC433EF for ; Thu, 28 Oct 2021 14:20:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 222DC61073 for ; Thu, 28 Oct 2021 14:20:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 222DC61073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hg7503C4qz3bj1 for ; Fri, 29 Oct 2021 01:20:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=MZZW77BM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::335; helo=mail-wm1-x335.google.com; envelope-from=lukas.bulwahn@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=MZZW77BM; dkim-atps=neutral Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hg74G2jJcz2yY7 for ; Fri, 29 Oct 2021 01:19:57 +1100 (AEDT) Received: by mail-wm1-x335.google.com with SMTP id 192so4416995wme.3 for ; Thu, 28 Oct 2021 07:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w9dCLGXOlRDJmVPN1HJBPCtrX5Y3dq1CeosXfwTmTIE=; b=MZZW77BM7jF65T9itFpM6n7U5dNOUA1+IJ2d8FO0oyqoTXflUpdwut867AadkBdvOf MdACiu8DDmGMF+ElH9PG5i8Vech57XSQftI0CPVl/H/Lw/Vm1dOXi+WEMpTh9jUyQiki 4IGL04gs8riaamW4lCTxL2bq0QDsXJGQKdGw7lKFv4+GZlRw4q7G23uXPqU+6333/Jht FAL+5sTiLuJhnGZUX+lOTCNtQeJwivdpuzCv9KhQTKrVTHEgBBCUCzuAh7vcvujktWcX FFZ08vnnBqfrGGnGqgBZTDNN5sWGI3Xa1pIT5tRBF+AQbPK+usl8k/O8qrjp212PEG6D MhLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w9dCLGXOlRDJmVPN1HJBPCtrX5Y3dq1CeosXfwTmTIE=; b=gAe6Pyzy1i/Ul+Bd372NHKdr7q8qsryv1YKUMslmRTdDFAaLvXOt3Fpb0X+ldzSl7n s7VEgEaXnOw7WZkq+bNMVmlcgoTEL63cklNNsblWrAe3iFjRutJAmaoGwkBe+pPwIy2z MVqybvnG3t/5ZdxxS+H3D879Gb6LJ5CUW+039pIVNhhsw61et6h7eZBnOWFjtrU1rf7I zb8Ecc0iE9ISyMaj4sphollLboJB+uWjNqOTIIQyKFlEQnevrH7Zm5Y0+b021bOvMQ7S 2VGEhKT5U+hgfu2JwU23hWyIoIs+bl+K/yGCvEbyHd/P+YcW5iRkfmH4myyFR/QSFpKt 91Ew== X-Gm-Message-State: AOAM530U8Aw+xM3XeGPD3xbiE2f7heVXX84jH/8byjpAWA3H2GXur2ZL Hv9nej/SFjkikfgvTa8LhF0= X-Google-Smtp-Source: ABdhPJzg6/fblA82QiNOpf6te3qmuIz0aMLwxzyCLkqjiM6kfgiHZAu7QfphRHWjzrEyKfVdfQhyfQ== X-Received: by 2002:a05:600c:2288:: with SMTP id 8mr13025376wmf.40.1635430790515; Thu, 28 Oct 2021 07:19:50 -0700 (PDT) Received: from localhost.localdomain (i5C74E249.versanet.de. [92.116.226.73]) by smtp.gmail.com with ESMTPSA id m2sm6284546wml.15.2021.10.28.07.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 07:19:50 -0700 (PDT) From: Lukas Bulwahn To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org Subject: [PATCH 00/13] Kconfig symbol clean-up on ./arch/arm{64} Date: Thu, 28 Oct 2021 16:19:25 +0200 Message-Id: <20211028141938.3530-1-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lukas Bulwahn , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Dear arm maintainers, The script ./scripts/checkkconfigsymbols.py warns on invalid references to Kconfig symbols (often: minor typos, name confusions or outdated references). This is a patch series addressing the issues reported by ./scripts/checkkconfigsymbols.py in the ./arch/arm{64}/ directories, quickly filtered down with: ./scripts/checkkconfigsymbols.py | grep "arch/arm" -B 1 -A 2 without considering kernel configs, i.e., after removing arch/arm{64}/configs in the working tree. It addresses some issues I considered to be "true positives"; so, issues that should be addressed and cleaned up. The patches on updating the comments might arguably be considered of lower value by itself, but as the other patches show, checkkconfigsymbols does detect some relevant issues in the kernel tree otherwise being unnoticed. So, it might be worth to clean up the kernel tree to have checkkconfigsymbols produce a rather short list of issues and then continuously follow and check what checkkconfigsymbols reports. Some work from checkkconfigsymbols on arch/arm/ is deferred; the other remaining issues that checkkconfigsymbols reports are (as far as I understand it now) "false positives", i.e., the tool misinterprets the actual content) or "intentional", e.g., they refer to historic configs for the purpose of documentation (e.g., in changelogs) or are in various kernel configs that are not continuously updated to match the current set of kernel configs. You can see below a grouped list of remaining reports. Each patch in this series can be discussed and applied individually if needed. They are sent in one patch series, as they all orginate from the investigation guided by the same tool and hence share similar topics and resolutions. Please pick this series of minor clean-up patches on ./arch/arm{64}/. It applies cleanly on next-20211027. Best regards, Lukas Remaining reports from ./scripts/checkkconfigsymbols.py pointing to files in ./arch/arm{64}/ (excluding configs), grouped by the rationale why it is not addressed in this patch series: - Reference in historic comment: ARM_NR_BANKS Referencing files: arch/arm/mach-exynos/exynos.c CPU Referencing files: arch/arm/lib/backtrace.S, arch/arm/lib/csumpartialcopyuser.S, arch/arm/mach-rpc/ecard-loader.S, arch/arm/mach-rpc/io-acorn.S, arch/arm/nwfpe/fpmodule.h CPU_ARM92{0,2,5,6}_CPU_IDLE Referencing files: arch/arm/mm/proc-arm92{0,2,5,6}.S KVM_INDIRECT_VECTORS Referencing files: arch/arm64/kvm/hyp/nvhe/host.S - Use of CONFIG_* environment variable beyond the definition in Kconfig scripts AS_DMB_ISHLD Referencing files: arch/arm64/include/asm/vdso/compat_barrier.h, arch/arm64/kernel/vdso32/Makefile CC_HAS_K_CONSTRAINT Referencing files: arch/arm64/Makefile, arch/arm64/include/asm/atomic_ll_sc.h SHELL Ignore CONFIG_SHELL. Default variable in Kbuild build system. - Parsing Mistake (Incomplete parsing heuristics) by checkkconfigsymbols.py: ASC1, ASC2, SBC, UART Referencing files: arch/arm/Kconfig.debug - Future work to send clean-up patches: IRDA{_MODULE} Referencing files: arch/arm/mach-pxa/balloon3.c, arch/arm/mach-pxa/palm27x.c, arch/arm/mach-pxa/palm27x.h, arch/arm/mach-pxa/palmtc.c, include/linux/atalk.h, include/linux/netdevice.h PXA_FICP{_MODULE} Referencing files: arch/arm/mach-pxa/spitz.c DEBUG_LL_SER3 Referencing files: arch/arm/boot/compressed/head.S already discussed in 2014: https://lore.kernel.org/all/1400055127.31197.1.camel@x220/ Lukas Bulwahn (13): arm: debug: remove obsolete debug code for DEBUG_ZTE_ZX arm: debug: reuse the config DEBUG_OMAP2UART{1,2} for OMAP{3,4,5} arm: Kconfig.debug: drop reference to removed ARCH_MSM arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 arm: davinci: remove reference to obsolete BLK_DEV_PALMCHIP_BK3710 arm: ixp4xx: remove dead configs CPU_IXP43X and CPU_IXP46X arm: imx: remove dead left-over from i.MX{27,31,35} removal arm: imx: rename DEBUG_IMX21_IMX27_UART to DEBUG_IMX27_UART arm: milbeaut: remove select of non-existing PINCTRL_MILBEAUT arm: nomadik: drop selecting obsolete CLKSRC_NOMADIK_MTU_SCHED_CLOCK arm: npcm: drop selecting non-existing ARM_ERRATA_794072 arm: socfpga: always select PL310_ERRATA_753970 arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment arch/arm/Kconfig.debug | 28 ++++++++++------------- arch/arm/include/debug/imx-uart.h | 18 +++++++-------- arch/arm/include/debug/pl01x.S | 7 ------ arch/arm/kernel/bios32.c | 2 -- arch/arm/mach-davinci/board-dm644x-evm.c | 3 +-- arch/arm/mach-davinci/board-dm646x-evm.c | 3 +-- arch/arm/mach-davinci/board-neuros-osd2.c | 3 +-- arch/arm/mach-imx/Kconfig | 12 ---------- arch/arm/mach-imx/Makefile | 2 -- arch/arm/mach-ixp4xx/Kconfig | 13 ----------- arch/arm/mach-milbeaut/Kconfig | 1 - arch/arm/mach-nomadik/Kconfig | 1 - arch/arm/mach-npcm/Kconfig | 1 - arch/arm/mach-socfpga/Kconfig | 2 +- arch/arm/mm/pgd.c | 2 +- 15 files changed, 26 insertions(+), 72 deletions(-) -- 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75683C433EF for ; Thu, 28 Oct 2021 14:21:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 426D461108 for ; Thu, 28 Oct 2021 14:21:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 426D461108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1TCjn/tfTuKZprmjsgK+8T7BX7bbIxgvA32CNhzqWX4=; b=yxkVWVWPYepOas HQuw5CtVq0S0zR5xzwqasTjsovFccAh5KpE/tDtCcypENpeP0ajqKMyd7LRHI2WBtWrACv9LdXuVk oaweFOK83NhzFUD3nod/mpJIbAWSMuEA7Kvcqxaocj1eQgWp43STRj7NNGD9KZOHllHzdq1agCN4W 6XvHuSmoSkf7WWmVMRXDHfej3GtG68DykSA7ufNVEKRBwagzMQ3vLWJRPx8AxDz2E+ey66sZUO213 zckly7xzJBaZ1PhswDIMtj9lyehUxn8egPDGjo8yGJGFbM5/+DF+45c8z1j11bTt69a/wktti8ezb SCsuRsT+PneGQxWYPRVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg6G5-0086E0-C3; Thu, 28 Oct 2021 14:19:57 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg6G1-0086Cu-1K for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 14:19:54 +0000 Received: by mail-wm1-x32b.google.com with SMTP id j35-20020a05600c1c2300b0032caeca81b7so4789058wms.0 for ; Thu, 28 Oct 2021 07:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w9dCLGXOlRDJmVPN1HJBPCtrX5Y3dq1CeosXfwTmTIE=; b=MZZW77BM7jF65T9itFpM6n7U5dNOUA1+IJ2d8FO0oyqoTXflUpdwut867AadkBdvOf MdACiu8DDmGMF+ElH9PG5i8Vech57XSQftI0CPVl/H/Lw/Vm1dOXi+WEMpTh9jUyQiki 4IGL04gs8riaamW4lCTxL2bq0QDsXJGQKdGw7lKFv4+GZlRw4q7G23uXPqU+6333/Jht FAL+5sTiLuJhnGZUX+lOTCNtQeJwivdpuzCv9KhQTKrVTHEgBBCUCzuAh7vcvujktWcX FFZ08vnnBqfrGGnGqgBZTDNN5sWGI3Xa1pIT5tRBF+AQbPK+usl8k/O8qrjp212PEG6D MhLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w9dCLGXOlRDJmVPN1HJBPCtrX5Y3dq1CeosXfwTmTIE=; b=JkKyhIAYY3foCy5xcS3lvQNa9OxVVsZjp7yZt/3808Ut3xBfTikLS9iYTo2hxxfOdF JpsJ2CWkqWICVPjFG71s98flDRgsaC5LEzPGQ75gYXSkFDpKPZf+iLnGSU+F/MiiB2EM KGdCaX+0APeiBoESaaWOAyUu5O77Vp6KmS0groaDfYJGAJAEb1KVz5kEzLqdLX8GHRv0 krcB5z0WGjNNLuLQ9t1NP7N3DuvT3O7hxYaYkH5e9ZIMUvlc/ecafZSlnfkMvwHfRSex ZZ2RdCDNIM/gHZ6bNn9X1ZSJofXlbNMecMwdQ7uObpx0f4NPb6+wJxkWpOjRyfVH1Ma9 xD+w== X-Gm-Message-State: AOAM5322qYAzuExs0+tYz3PO3H3kzFbfMMyoghqJS5slg5xZBhKo0eYE axJ6wZEtFVNMgdJuVuOOve+UVegmAY4bug== X-Google-Smtp-Source: ABdhPJzg6/fblA82QiNOpf6te3qmuIz0aMLwxzyCLkqjiM6kfgiHZAu7QfphRHWjzrEyKfVdfQhyfQ== X-Received: by 2002:a05:600c:2288:: with SMTP id 8mr13025376wmf.40.1635430790515; Thu, 28 Oct 2021 07:19:50 -0700 (PDT) Received: from localhost.localdomain (i5C74E249.versanet.de. [92.116.226.73]) by smtp.gmail.com with ESMTPSA id m2sm6284546wml.15.2021.10.28.07.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 07:19:50 -0700 (PDT) From: Lukas Bulwahn To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH 00/13] Kconfig symbol clean-up on ./arch/arm{64} Date: Thu, 28 Oct 2021 16:19:25 +0200 Message-Id: <20211028141938.3530-1-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_071953_120890_9ABC3655 X-CRM114-Status: GOOD ( 21.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear arm maintainers, The script ./scripts/checkkconfigsymbols.py warns on invalid references to Kconfig symbols (often: minor typos, name confusions or outdated references). This is a patch series addressing the issues reported by ./scripts/checkkconfigsymbols.py in the ./arch/arm{64}/ directories, quickly filtered down with: ./scripts/checkkconfigsymbols.py | grep "arch/arm" -B 1 -A 2 without considering kernel configs, i.e., after removing arch/arm{64}/configs in the working tree. It addresses some issues I considered to be "true positives"; so, issues that should be addressed and cleaned up. The patches on updating the comments might arguably be considered of lower value by itself, but as the other patches show, checkkconfigsymbols does detect some relevant issues in the kernel tree otherwise being unnoticed. So, it might be worth to clean up the kernel tree to have checkkconfigsymbols produce a rather short list of issues and then continuously follow and check what checkkconfigsymbols reports. Some work from checkkconfigsymbols on arch/arm/ is deferred; the other remaining issues that checkkconfigsymbols reports are (as far as I understand it now) "false positives", i.e., the tool misinterprets the actual content) or "intentional", e.g., they refer to historic configs for the purpose of documentation (e.g., in changelogs) or are in various kernel configs that are not continuously updated to match the current set of kernel configs. You can see below a grouped list of remaining reports. Each patch in this series can be discussed and applied individually if needed. They are sent in one patch series, as they all orginate from the investigation guided by the same tool and hence share similar topics and resolutions. Please pick this series of minor clean-up patches on ./arch/arm{64}/. It applies cleanly on next-20211027. Best regards, Lukas Remaining reports from ./scripts/checkkconfigsymbols.py pointing to files in ./arch/arm{64}/ (excluding configs), grouped by the rationale why it is not addressed in this patch series: - Reference in historic comment: ARM_NR_BANKS Referencing files: arch/arm/mach-exynos/exynos.c CPU Referencing files: arch/arm/lib/backtrace.S, arch/arm/lib/csumpartialcopyuser.S, arch/arm/mach-rpc/ecard-loader.S, arch/arm/mach-rpc/io-acorn.S, arch/arm/nwfpe/fpmodule.h CPU_ARM92{0,2,5,6}_CPU_IDLE Referencing files: arch/arm/mm/proc-arm92{0,2,5,6}.S KVM_INDIRECT_VECTORS Referencing files: arch/arm64/kvm/hyp/nvhe/host.S - Use of CONFIG_* environment variable beyond the definition in Kconfig scripts AS_DMB_ISHLD Referencing files: arch/arm64/include/asm/vdso/compat_barrier.h, arch/arm64/kernel/vdso32/Makefile CC_HAS_K_CONSTRAINT Referencing files: arch/arm64/Makefile, arch/arm64/include/asm/atomic_ll_sc.h SHELL Ignore CONFIG_SHELL. Default variable in Kbuild build system. - Parsing Mistake (Incomplete parsing heuristics) by checkkconfigsymbols.py: ASC1, ASC2, SBC, UART Referencing files: arch/arm/Kconfig.debug - Future work to send clean-up patches: IRDA{_MODULE} Referencing files: arch/arm/mach-pxa/balloon3.c, arch/arm/mach-pxa/palm27x.c, arch/arm/mach-pxa/palm27x.h, arch/arm/mach-pxa/palmtc.c, include/linux/atalk.h, include/linux/netdevice.h PXA_FICP{_MODULE} Referencing files: arch/arm/mach-pxa/spitz.c DEBUG_LL_SER3 Referencing files: arch/arm/boot/compressed/head.S already discussed in 2014: https://lore.kernel.org/all/1400055127.31197.1.camel@x220/ Lukas Bulwahn (13): arm: debug: remove obsolete debug code for DEBUG_ZTE_ZX arm: debug: reuse the config DEBUG_OMAP2UART{1,2} for OMAP{3,4,5} arm: Kconfig.debug: drop reference to removed ARCH_MSM arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 arm: davinci: remove reference to obsolete BLK_DEV_PALMCHIP_BK3710 arm: ixp4xx: remove dead configs CPU_IXP43X and CPU_IXP46X arm: imx: remove dead left-over from i.MX{27,31,35} removal arm: imx: rename DEBUG_IMX21_IMX27_UART to DEBUG_IMX27_UART arm: milbeaut: remove select of non-existing PINCTRL_MILBEAUT arm: nomadik: drop selecting obsolete CLKSRC_NOMADIK_MTU_SCHED_CLOCK arm: npcm: drop selecting non-existing ARM_ERRATA_794072 arm: socfpga: always select PL310_ERRATA_753970 arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment arch/arm/Kconfig.debug | 28 ++++++++++------------- arch/arm/include/debug/imx-uart.h | 18 +++++++-------- arch/arm/include/debug/pl01x.S | 7 ------ arch/arm/kernel/bios32.c | 2 -- arch/arm/mach-davinci/board-dm644x-evm.c | 3 +-- arch/arm/mach-davinci/board-dm646x-evm.c | 3 +-- arch/arm/mach-davinci/board-neuros-osd2.c | 3 +-- arch/arm/mach-imx/Kconfig | 12 ---------- arch/arm/mach-imx/Makefile | 2 -- arch/arm/mach-ixp4xx/Kconfig | 13 ----------- arch/arm/mach-milbeaut/Kconfig | 1 - arch/arm/mach-nomadik/Kconfig | 1 - arch/arm/mach-npcm/Kconfig | 1 - arch/arm/mach-socfpga/Kconfig | 2 +- arch/arm/mm/pgd.c | 2 +- 15 files changed, 26 insertions(+), 72 deletions(-) -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel