From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE1DC433EF for ; Thu, 28 Oct 2021 14:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D558A610FC for ; Thu, 28 Oct 2021 14:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231493AbhJ1OXG (ORCPT ); Thu, 28 Oct 2021 10:23:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231401AbhJ1OWv (ORCPT ); Thu, 28 Oct 2021 10:22:51 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FCE6C061243; Thu, 28 Oct 2021 07:20:24 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id o14so10456127wra.12; Thu, 28 Oct 2021 07:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y0+Ewf3zoYKYSWZPJecgoccdfTSC37HrqNABHJ/zSx4=; b=qQ1E19YcuVT5BdjCL+cmlKQONdyDux+CcDXoljj3sR/mw/MbHxYEUXfiB/v6dFUVKs 8wfkCTpArL5db/Y2QwkhAPh/a0UAVBIb5LYjUYjWMwY7DH4NcutzkEcbsyDkui6fDJvQ yzbVHDh+EN3Pi+ifIu9haL5Vtn1wL1SoY2GMawHxP98gKS0h66oPLUL7b9eQaIPSa6RS KjAhHWPi71XeN7bXQbSnavaIMdAPxAL7+VNnOuHhEoPcBEaRb4x50Sz3lQLmgaqfGqYN jrOlLY7FCbPwkBw0OBBd5aUYiaSEQoBqeXESKvxAoJO/53291Pn7AJoE1ZCgD0pAVPA/ JvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y0+Ewf3zoYKYSWZPJecgoccdfTSC37HrqNABHJ/zSx4=; b=YHkvORQIqfx46aolLgyCagjsYxB+4Bxo2Ach1k/1K0rSQORcS/7XC42jMPJZNOZCPT v4KUrcubP0ohmu6b7zmQM6o71c4zBt346WYb1HdFw3Cy9Gz+Jb8AVPROpSoR8b5H10a2 zmlvau4EQfVYNtUbi31XMgVxK9Xixq+pfS1HCwsCq0jv2MKZLv2Bzlwu1zBjp8/NFUj+ dcVlJYi9ber8YQEqrUxJGIP15Y8Wml/M3OkFwQe6os2WXfiuR5XExIDd83f4q1np2wML dvrqHzy76b5/QciXUtL/SBAyggRF+SfJ/Wjyhq2iQIWazq2j8FR6WHRPJVGDl6sjJ/Rs WUTw== X-Gm-Message-State: AOAM532E3JPQVDrLVe/9jtrBzD+OckPPGrwSAwUdUsCBmA+1tUph+G2f hg4fc5G/qwnhNNLHYYvSlpQ= X-Google-Smtp-Source: ABdhPJyQqCEoBp5Xz9+BZw2NcATVGQ8YNlBwKwxvu8ASJ7d5NPYrqSJPGxWZa2Pga/Uj2nf1pomHkQ== X-Received: by 2002:adf:e489:: with SMTP id i9mr6257310wrm.22.1635430822842; Thu, 28 Oct 2021 07:20:22 -0700 (PDT) Received: from localhost.localdomain (i5C74E249.versanet.de. [92.116.226.73]) by smtp.gmail.com with ESMTPSA id m2sm6284546wml.15.2021.10.28.07.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 07:20:22 -0700 (PDT) From: Lukas Bulwahn To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment Date: Thu, 28 Oct 2021 16:19:38 +0200 Message-Id: <20211028141938.3530-14-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20211028141938.3530-1-lukas.bulwahn@gmail.com> References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the good practice to annotate the endif's with a comment to indicate the corresponding ifdef condition. One comment annotation refers to CONFIG_LPAE, whereas the config is actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably tolerable for all human readers. However, the script ./scripts/checkkconfigsymbols.py, which checks the kernel tree for references to non-existing Kconfig symbols, identifies and reports that the reference to CONFIG_LPAE is invalid. The script ./scripts/checkkconfigsymbols.py has been quite useful to identify a number of bugs with Kconfig symbols and deserves to be executed and checked regularly. So, repair the comment to reduce the reports from this script and simplify to use this script, as new issues are easier to spot when the list of reports is shorter. Signed-off-by: Lukas Bulwahn --- arch/arm/mm/pgd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/pgd.c b/arch/arm/mm/pgd.c index f8e9bc58a84f..bf2935f21c12 100644 --- a/arch/arm/mm/pgd.c +++ b/arch/arm/mm/pgd.c @@ -80,7 +80,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm) * sizeof(pmd_t)); clean_dcache_area(new_pmd, PTRS_PER_PMD * sizeof(pmd_t)); #endif /* CONFIG_KASAN */ -#endif /* CONFIG_LPAE */ +#endif /* CONFIG_ARM_LPAE */ if (!vectors_high()) { /* -- 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFFFC433F5 for ; Thu, 28 Oct 2021 14:28:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC54D60720 for ; Thu, 28 Oct 2021 14:28:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BC54D60720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SLgDGUv1ybxpBLvaM226bkrmbWYLV7aWT2aHJS1Tv/E=; b=U5sAsuxN/jTAlw huW6jJ0NYqiKHgiF5SBf+ztxcQSWID6ZhnjWzZS8oLMVgam5Mj0LSNFmHrr2O007mv4Kn6u6P3dFy SySgvTp8ARtR1g5vX7t0CDAOvowhCZMKBc9atuZb7lanQaTgKBwM+9KLVM73wbg2qTbcrItTw3oVj H8u0vsvx1q93ISvBwM++2cUwUVCGuk9T1Chme53FhnwS1PHCaUA2+xA8MsWEJef4DuaiuUS3l9OKH mlQHS+FL3MJKOpJ2v8At20YDWOtr7YlbUalICQoh9f1X5Jmw7U+vaKdZkudcb+2ZayqWTFAoAx1Op jPcm17PeRg+VqiMuM4ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg6M1-0088sF-DK; Thu, 28 Oct 2021 14:26:06 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg6GW-0086Oj-6h for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 14:20:27 +0000 Received: by mail-wr1-x42d.google.com with SMTP id d10so10576890wrb.1 for ; Thu, 28 Oct 2021 07:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y0+Ewf3zoYKYSWZPJecgoccdfTSC37HrqNABHJ/zSx4=; b=qQ1E19YcuVT5BdjCL+cmlKQONdyDux+CcDXoljj3sR/mw/MbHxYEUXfiB/v6dFUVKs 8wfkCTpArL5db/Y2QwkhAPh/a0UAVBIb5LYjUYjWMwY7DH4NcutzkEcbsyDkui6fDJvQ yzbVHDh+EN3Pi+ifIu9haL5Vtn1wL1SoY2GMawHxP98gKS0h66oPLUL7b9eQaIPSa6RS KjAhHWPi71XeN7bXQbSnavaIMdAPxAL7+VNnOuHhEoPcBEaRb4x50Sz3lQLmgaqfGqYN jrOlLY7FCbPwkBw0OBBd5aUYiaSEQoBqeXESKvxAoJO/53291Pn7AJoE1ZCgD0pAVPA/ JvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y0+Ewf3zoYKYSWZPJecgoccdfTSC37HrqNABHJ/zSx4=; b=m2dKWgJr89QTuo8icdq8cAHW91g1AFIMYj8JMKCukhP4AWSSD5U8+4nEGSFGQ4hYJG txFaNztjEkirS5Ah5rQhG319ZjyRpmgKgRbnYOjEgAXYOBI482ATm1E0g3KcZSl8gNva eGPIv3HN6jqh+l9t4O8g9cGGqoIwcoGo3iZuhq3g5PdwnviV2XUuWBCBkA38jwzxXfaw KZiT8NIdOAnacLFi1ARKDAsKJwTIrLThLqUttrO3p6H0WmE4Y7TkDcBddyCR1mdeVX2O pe20Edj60g/NRNrbPC1Jk8AGLqDUYfXy8I9h8VNbT1HAqjoQXDVI5d6Wc3OqT3uA/fO0 8aXg== X-Gm-Message-State: AOAM5313A9JfqMHVUZlI+sEEVFKFbe6sJZTHDVV6Tyj135iqavRCP98l FSrbVx2VPLPImhyT7brCfWAvB2QVhXFfSg== X-Google-Smtp-Source: ABdhPJyQqCEoBp5Xz9+BZw2NcATVGQ8YNlBwKwxvu8ASJ7d5NPYrqSJPGxWZa2Pga/Uj2nf1pomHkQ== X-Received: by 2002:adf:e489:: with SMTP id i9mr6257310wrm.22.1635430822842; Thu, 28 Oct 2021 07:20:22 -0700 (PDT) Received: from localhost.localdomain (i5C74E249.versanet.de. [92.116.226.73]) by smtp.gmail.com with ESMTPSA id m2sm6284546wml.15.2021.10.28.07.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 07:20:22 -0700 (PDT) From: Lukas Bulwahn To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment Date: Thu, 28 Oct 2021 16:19:38 +0200 Message-Id: <20211028141938.3530-14-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20211028141938.3530-1-lukas.bulwahn@gmail.com> References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_072024_340911_B9824E8C X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the good practice to annotate the endif's with a comment to indicate the corresponding ifdef condition. One comment annotation refers to CONFIG_LPAE, whereas the config is actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably tolerable for all human readers. However, the script ./scripts/checkkconfigsymbols.py, which checks the kernel tree for references to non-existing Kconfig symbols, identifies and reports that the reference to CONFIG_LPAE is invalid. The script ./scripts/checkkconfigsymbols.py has been quite useful to identify a number of bugs with Kconfig symbols and deserves to be executed and checked regularly. So, repair the comment to reduce the reports from this script and simplify to use this script, as new issues are easier to spot when the list of reports is shorter. Signed-off-by: Lukas Bulwahn --- arch/arm/mm/pgd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/pgd.c b/arch/arm/mm/pgd.c index f8e9bc58a84f..bf2935f21c12 100644 --- a/arch/arm/mm/pgd.c +++ b/arch/arm/mm/pgd.c @@ -80,7 +80,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm) * sizeof(pmd_t)); clean_dcache_area(new_pmd, PTRS_PER_PMD * sizeof(pmd_t)); #endif /* CONFIG_KASAN */ -#endif /* CONFIG_LPAE */ +#endif /* CONFIG_ARM_LPAE */ if (!vectors_high()) { /* -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572C6C433F5 for ; Thu, 28 Oct 2021 14:29:39 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAFF960720 for ; Thu, 28 Oct 2021 14:29:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CAFF960720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hg7HP3Q8Fz2yX8 for ; Fri, 29 Oct 2021 01:29:37 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=qQ1E19Yc; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::430; helo=mail-wr1-x430.google.com; envelope-from=lukas.bulwahn@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=qQ1E19Yc; dkim-atps=neutral Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hg74n5DK9z2ybK for ; Fri, 29 Oct 2021 01:20:25 +1100 (AEDT) Received: by mail-wr1-x430.google.com with SMTP id d13so10489196wrf.11 for ; Thu, 28 Oct 2021 07:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y0+Ewf3zoYKYSWZPJecgoccdfTSC37HrqNABHJ/zSx4=; b=qQ1E19YcuVT5BdjCL+cmlKQONdyDux+CcDXoljj3sR/mw/MbHxYEUXfiB/v6dFUVKs 8wfkCTpArL5db/Y2QwkhAPh/a0UAVBIb5LYjUYjWMwY7DH4NcutzkEcbsyDkui6fDJvQ yzbVHDh+EN3Pi+ifIu9haL5Vtn1wL1SoY2GMawHxP98gKS0h66oPLUL7b9eQaIPSa6RS KjAhHWPi71XeN7bXQbSnavaIMdAPxAL7+VNnOuHhEoPcBEaRb4x50Sz3lQLmgaqfGqYN jrOlLY7FCbPwkBw0OBBd5aUYiaSEQoBqeXESKvxAoJO/53291Pn7AJoE1ZCgD0pAVPA/ JvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y0+Ewf3zoYKYSWZPJecgoccdfTSC37HrqNABHJ/zSx4=; b=JDn1esXvgmQpdyln/mXt1i7qfG+X6VyMXjMh4exIz5m61yHrQODlpzgcnOm8AvrM3B jiOn4gftW9Vtz/IWnxLg5/Xnb0TDZg8kuMqg8pqXuNxe/tsa7jjkkEz9mgxC6kpBmgcc afPliWM/5+rwWDAzQZey2SBvBaQPtLpe/WOugNmU9lSLz9FJHX4lg0bmOdfoDfQGb2hW V81pyFw3uSUS5FMXXczPhiKjZv3G1uJyPzsDpcll8wEweqMQVtl6fH9/jpnheaKazcZA 1b5SNC2M1Kr+ZM5KYwuzYcWPkea2QpSTLifng11I69Vf+bPOBuDJq07fagPgeIA02PlF UlyA== X-Gm-Message-State: AOAM531uXHrkx4hrLkq67mKw3DUFGSECfK8bOhVRZFbfMOew5GxnYA4k E2by1VP3ulBuqCoZg6UWALQ= X-Google-Smtp-Source: ABdhPJyQqCEoBp5Xz9+BZw2NcATVGQ8YNlBwKwxvu8ASJ7d5NPYrqSJPGxWZa2Pga/Uj2nf1pomHkQ== X-Received: by 2002:adf:e489:: with SMTP id i9mr6257310wrm.22.1635430822842; Thu, 28 Oct 2021 07:20:22 -0700 (PDT) Received: from localhost.localdomain (i5C74E249.versanet.de. [92.116.226.73]) by smtp.gmail.com with ESMTPSA id m2sm6284546wml.15.2021.10.28.07.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 07:20:22 -0700 (PDT) From: Lukas Bulwahn To: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org Subject: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment Date: Thu, 28 Oct 2021 16:19:38 +0200 Message-Id: <20211028141938.3530-14-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20211028141938.3530-1-lukas.bulwahn@gmail.com> References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lukas Bulwahn , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the good practice to annotate the endif's with a comment to indicate the corresponding ifdef condition. One comment annotation refers to CONFIG_LPAE, whereas the config is actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably tolerable for all human readers. However, the script ./scripts/checkkconfigsymbols.py, which checks the kernel tree for references to non-existing Kconfig symbols, identifies and reports that the reference to CONFIG_LPAE is invalid. The script ./scripts/checkkconfigsymbols.py has been quite useful to identify a number of bugs with Kconfig symbols and deserves to be executed and checked regularly. So, repair the comment to reduce the reports from this script and simplify to use this script, as new issues are easier to spot when the list of reports is shorter. Signed-off-by: Lukas Bulwahn --- arch/arm/mm/pgd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/pgd.c b/arch/arm/mm/pgd.c index f8e9bc58a84f..bf2935f21c12 100644 --- a/arch/arm/mm/pgd.c +++ b/arch/arm/mm/pgd.c @@ -80,7 +80,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm) * sizeof(pmd_t)); clean_dcache_area(new_pmd, PTRS_PER_PMD * sizeof(pmd_t)); #endif /* CONFIG_KASAN */ -#endif /* CONFIG_LPAE */ +#endif /* CONFIG_ARM_LPAE */ if (!vectors_high()) { /* -- 2.26.2