From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5247C4332F for ; Thu, 28 Oct 2021 13:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82DA4610A0 for ; Thu, 28 Oct 2021 13:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230361AbhJ1Nip convert rfc822-to-8bit (ORCPT ); Thu, 28 Oct 2021 09:38:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:40304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbhJ1Nio (ORCPT ); Thu, 28 Oct 2021 09:38:44 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5584161056; Thu, 28 Oct 2021 13:36:15 +0000 (UTC) Date: Thu, 28 Oct 2021 14:40:41 +0100 From: Jonathan Cameron To: =?UTF-8?B?QW5kcsOp?= Gustavo Nakagomi Lopez Cc: lars@metafoo.de, vz@mleia.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: adc: lpc18xx_adc: Reorder clk_get_rate function call Message-ID: <20211028144041.20407149@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Oct 2021 09:19:50 -0300 André Gustavo Nakagomi Lopez wrote: > clk_get_rate is not guaranteed to work if called before clk_prepare_enable. > > Reorder clk_get_rate, so it's called after clk_prepare_enable and > after devm_add_action_or_reset of lpc18xx_clk_disable. > > Suggested-by: Jonathan Cameron > Acked-by: Vladimir Zapolskiy > Signed-off-by: André Gustavo Nakagomi Lopez Thanks. I tweaked the message a little and added a note that this was not a fix for this particular platform. Good to avoid chance of cut and paste into another driver! Jonathan > --- > Change log V1 -> V2: > -Fixed typo > -Added appropriate Suggested-by and Acked-by tags > drivers/iio/adc/lpc18xx_adc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c > index ceefa4d793cf..ae9c9384f23e 100644 > --- a/drivers/iio/adc/lpc18xx_adc.c > +++ b/drivers/iio/adc/lpc18xx_adc.c > @@ -157,9 +157,6 @@ static int lpc18xx_adc_probe(struct platform_device *pdev) > return dev_err_probe(&pdev->dev, PTR_ERR(adc->clk), > "error getting clock\n"); > > - rate = clk_get_rate(adc->clk); > - clkdiv = DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET); > - > adc->vref = devm_regulator_get(&pdev->dev, "vref"); > if (IS_ERR(adc->vref)) > return dev_err_probe(&pdev->dev, PTR_ERR(adc->vref), > @@ -192,6 +189,9 @@ static int lpc18xx_adc_probe(struct platform_device *pdev) > if (ret) > return ret; > > + rate = clk_get_rate(adc->clk); > + clkdiv = DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET); > + > adc->cr_reg = (clkdiv << LPC18XX_ADC_CR_CLKDIV_SHIFT) | > LPC18XX_ADC_CR_PDN; > writel(adc->cr_reg, adc->base + LPC18XX_ADC_CR); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966E4C433F5 for ; Thu, 28 Oct 2021 13:37:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56FB060527 for ; Thu, 28 Oct 2021 13:37:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 56FB060527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QOLXqNFsXFEnG7hiM1DCvKISyqifH/7ejHENE7lI9mE=; b=ITNwl8NHe/FZtd VduI/LZmAISpc78Ty/kCuc4FPf44FztTTkwGXNzJX5S2Pn3Ohr7YWsnj00BQUFtM6oHQMvhowPmdM XmHpDpNo7dj94am6dlrHjIwfxVw2CaMHDukgvY+AGrtwH4ntJfjzku3SX4e3kkVOTPwy2AJenMU+X Dh2tWaLWU/iCJr6x5XfXPhfLR0DfQW7mhQvLugHJPmjuKaTziF+XM6DWIOQSfAbhsTH9R8mQoKa3b wrDeyu5CM4dvP9Kg2YjELu9BpPfjkidwC5uhq9YZg10fUjFShrkEtWNqINZbMy95S3WxZb3WWVy1X fb/pQsEAIhfGpLI1SB3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg5Zt-007xjg-M0; Thu, 28 Oct 2021 13:36:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg5Zq-007xij-4V for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 13:36:19 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5584161056; Thu, 28 Oct 2021 13:36:15 +0000 (UTC) Date: Thu, 28 Oct 2021 14:40:41 +0100 From: Jonathan Cameron To: =?UTF-8?B?QW5kcsOp?= Gustavo Nakagomi Lopez Cc: lars@metafoo.de, vz@mleia.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: adc: lpc18xx_adc: Reorder clk_get_rate function call Message-ID: <20211028144041.20407149@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_063618_217379_1643D5A7 X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyNSBPY3QgMjAyMSAwOToxOTo1MCAtMDMwMApBbmRyw6kgR3VzdGF2byBOYWthZ29t aSBMb3BleiA8YW5kcmVnbmxAdXNwLmJyPiB3cm90ZToKCj4gY2xrX2dldF9yYXRlIGlzIG5vdCBn dWFyYW50ZWVkIHRvIHdvcmsgaWYgY2FsbGVkIGJlZm9yZSBjbGtfcHJlcGFyZV9lbmFibGUuCj4g Cj4gUmVvcmRlciBjbGtfZ2V0X3JhdGUsIHNvIGl0J3MgY2FsbGVkIGFmdGVyIGNsa19wcmVwYXJl X2VuYWJsZSBhbmQKPiBhZnRlciBkZXZtX2FkZF9hY3Rpb25fb3JfcmVzZXQgb2YgbHBjMTh4eF9j bGtfZGlzYWJsZS4KPiAKPiBTdWdnZXN0ZWQtYnk6IEpvbmF0aGFuIENhbWVyb24gPGppYzIzQGtl cm5lbC5vcmc+Cj4gQWNrZWQtYnk6IFZsYWRpbWlyIFphcG9sc2tpeSA8dnpAbWxlaWEuY29tPgo+ IFNpZ25lZC1vZmYtYnk6IEFuZHLDqSBHdXN0YXZvIE5ha2Fnb21pIExvcGV6IDxhbmRyZWdubEB1 c3AuYnI+CgpUaGFua3MuIEkgdHdlYWtlZCB0aGUgbWVzc2FnZSBhIGxpdHRsZSBhbmQgYWRkZWQg YSBub3RlIHRoYXQgdGhpcyB3YXMgbm90CmEgZml4IGZvciB0aGlzIHBhcnRpY3VsYXIgcGxhdGZv cm0uICBHb29kIHRvIGF2b2lkIGNoYW5jZSBvZiBjdXQgYW5kIHBhc3RlCmludG8gYW5vdGhlciBk cml2ZXIhCgpKb25hdGhhbgoKPiAtLS0KPiBDaGFuZ2UgbG9nIFYxIC0+IFYyOgo+IAkJICAtRml4 ZWQgdHlwbwo+IAkJICAtQWRkZWQgYXBwcm9wcmlhdGUgU3VnZ2VzdGVkLWJ5IGFuZCBBY2tlZC1i eSB0YWdzCj4gIGRyaXZlcnMvaWlvL2FkYy9scGMxOHh4X2FkYy5jIHwgNiArKystLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9paW8vYWRjL2xwYzE4eHhfYWRjLmMgYi9kcml2ZXJzL2lpby9hZGMvbHBj MTh4eF9hZGMuYwo+IGluZGV4IGNlZWZhNGQ3OTNjZi4uYWU5YzkzODRmMjNlIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvaWlvL2FkYy9scGMxOHh4X2FkYy5jCj4gKysrIGIvZHJpdmVycy9paW8vYWRj L2xwYzE4eHhfYWRjLmMKPiBAQCAtMTU3LDkgKzE1Nyw2IEBAIHN0YXRpYyBpbnQgbHBjMTh4eF9h ZGNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCQlyZXR1cm4gZGV2X2Vy cl9wcm9iZSgmcGRldi0+ZGV2LCBQVFJfRVJSKGFkYy0+Y2xrKSwKPiAgCQkJCSAgICAgImVycm9y IGdldHRpbmcgY2xvY2tcbiIpOwo+ICAKPiAtCXJhdGUgPSBjbGtfZ2V0X3JhdGUoYWRjLT5jbGsp Owo+IC0JY2xrZGl2ID0gRElWX1JPVU5EX1VQKHJhdGUsIExQQzE4WFhfQURDX0NMS19UQVJHRVQp Owo+IC0KPiAgCWFkYy0+dnJlZiA9IGRldm1fcmVndWxhdG9yX2dldCgmcGRldi0+ZGV2LCAidnJl ZiIpOwo+ICAJaWYgKElTX0VSUihhZGMtPnZyZWYpKQo+ICAJCXJldHVybiBkZXZfZXJyX3Byb2Jl KCZwZGV2LT5kZXYsIFBUUl9FUlIoYWRjLT52cmVmKSwKPiBAQCAtMTkyLDYgKzE4OSw5IEBAIHN0 YXRpYyBpbnQgbHBjMTh4eF9hZGNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK PiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gKwlyYXRlID0gY2xrX2dldF9yYXRl KGFkYy0+Y2xrKTsKPiArCWNsa2RpdiA9IERJVl9ST1VORF9VUChyYXRlLCBMUEMxOFhYX0FEQ19D TEtfVEFSR0VUKTsKPiArCj4gIAlhZGMtPmNyX3JlZyA9IChjbGtkaXYgPDwgTFBDMThYWF9BRENf Q1JfQ0xLRElWX1NISUZUKSB8Cj4gIAkJCUxQQzE4WFhfQURDX0NSX1BETjsKPiAgCXdyaXRlbChh ZGMtPmNyX3JlZywgYWRjLT5iYXNlICsgTFBDMThYWF9BRENfQ1IpOwoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK