From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13456C433EF for ; Thu, 28 Oct 2021 16:27:57 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15CB86103C for ; Thu, 28 Oct 2021 16:27:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 15CB86103C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3431183480; Thu, 28 Oct 2021 18:27:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="LJJnqhc2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B5FF834A4; Thu, 28 Oct 2021 18:27:50 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C5E7B832C6 for ; Thu, 28 Oct 2021 18:27:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id s1so4890973qta.13 for ; Thu, 28 Oct 2021 09:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0oXb/z4UBT4Fy1Q2p031OS/L7QeC/KKV9cnxE5g/FZA=; b=LJJnqhc249WybyF9s5BEjylgQuFb8wMox1bH7D9y2cmNcJTYghdMijx1+W7awUderD AXyRu30xxAiYWewaHTjpJ61OyzoLyhtGJn5l7e9IHt8gq3hZWnloMtsO33uBQFx3RZo3 YRbWmLCHnRmKMrr0vGXCwD0yhF/tqkNPpYr+0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0oXb/z4UBT4Fy1Q2p031OS/L7QeC/KKV9cnxE5g/FZA=; b=RzjFBOPDISX7Nyn+cbR5n2Y3jbOxWXV3raQZ8gpmBMXn2hh3tnYR1b+GOYbKOFW0f6 g2K0oXPqyc/1O7j23zZveZCVoMg9/XXzqMc8THM3pGqNpDDb8QvF/QhUGvZLpFFZ7Beg 5mO7DhQ72Ss20gJOaHBVtFd3/pIOJ67Iw9vAk385TN0XEpoA2ZgBDY3XtwpfeVojnFqy dH9HOxj89kxpZK08LIEiUgz93w2qhrzfi/0lS8G+8/5zGhRvWuPOraQVo2Fnsdf1w2Kl 0fWgvYw4MjKMy3zZu+coRshM/2XQIAyB0CWr1IoLTpggB6IpACUOJweubQ+bDlm1Br95 l9Pg== X-Gm-Message-State: AOAM532FDP6Syb0vfaPLhieM1K4dCfgWxxogNv+bZftqJF46+rUI8Vcz 59Za/KQs0gli8p0g4pqaPcYeEQ== X-Google-Smtp-Source: ABdhPJz74kleozOjmeEFzU/r+Jmo0gkATwiq/21AhgMrPs4D2wsIvq/T9E5ifFbKDyxIDxhXXXsRPw== X-Received: by 2002:a05:622a:290:: with SMTP id z16mr5743872qtw.358.1635438464635; Thu, 28 Oct 2021 09:27:44 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-015b-1704-43dd-8832.res6.spectrum.com. [2603:6081:7b01:cbda:15b:1704:43dd:8832]) by smtp.gmail.com with ESMTPSA id w11sm2556631qta.50.2021.10.28.09.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 09:27:44 -0700 (PDT) Date: Thu, 28 Oct 2021 12:27:41 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Michal Simek , Heinrich Schuchardt , Ilias Apalodimas , Daniel Schwierzeck , Steffen Jaeckel , Marek =?iso-8859-1?Q?Beh=FAn?= , Lukas Auer , Dennis Gilmore , Jaehoon Chung , Marek Vasut , Masahiro Yamada , Pavel Herrmann , Peng Fan , Stephen Warren , Stephen Warren Subject: Re: [PATCH v2 00/41] Initial implementation of standard boot Message-ID: <20211028162741.GA8284@bill-the-cat> References: <20211023232635.9195-1-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rbDVY1A5evmOIoPD" Content-Disposition: inline In-Reply-To: <20211023232635.9195-1-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --rbDVY1A5evmOIoPD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 23, 2021 at 05:25:54PM -0600, Simon Glass wrote: > The bootflow feature provide a built-in way for U-Boot to automatically > boot an Operating System without custom scripting and other customisation. > This is called 'standard boot' since it provides a standard way for > U-Boot to boot a distro, without scripting. >=20 > It introduces the following concepts: >=20 > - bootdev - a device which can hold a distro > - bootmeth - a method to scan a bootdev to find bootflows (owned by > U-Boot) > - bootflow - a description of how to boot (owned by the distro) >=20 > This series provides an implementation of these, enabled to scan for > bootflows from MMC, USB and Ethernet. It supports the existing distro > boot as well as the EFI loader flow (bootefi/bootmgr). It works > similiarly to the existing script-based approach, but is native to > U-Boot. I'm going to break my feedback down in to a few threads, to hopefully not confuse things too much. My first comment is that rpi_arm64 grows in size by 17 kilobytes, with the whole series (pxe, env, this) applied. And while there's a few small changes in the pxe cleanup I'm going to re-investigate on their own, it's really just this series, right here, adding tons of code. To replace an admittedly complex bit of environment scripting, with C. It's not even the earlier parts of the series to clean up / prepare, it starts at "bootstd: Add the bootstd uclass and core implementation" and keeps going from there. --=20 Tom --rbDVY1A5evmOIoPD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF6z3oACgkQFHw5/5Y0 tyziNQv9HDvj78Pn4Zho9gh3tAAxmiBc+JQlMUATKVS/glqWpY2eV4KRXZCB0o/t DneftB0DeCjxjaZQyzDx2j5EFEWYlIm4zNyfXZw43Pb4d9ltMm/yMaR1vyn5Tbzf /lLZhTMs0WLlNoFY78hlkLWFW91RXLiE63q7mP+4SVftEzLmyU8/skGNXAB1i6BQ H7sfWk6SlIN3lEChurEAuwVbMh5o5+TVmG8hI/zclv3xpyxTwFkZ467nYgWN3LwF u01MzY+Xt+BHx60jQlExQ7lkvpn9uHcs+JM9BRHRBq72P21n4kjPjAgKDhgVP86e 3agtpO7SEXZEJc7szgV05QofPSjKmDX9gPhFIRBIanpfeKPhUvGcEpnLRny5w7Y+ pJhcbCTAoR3wNY+CaqDeUgvcELB1XMWla/64tpgRuGwHAoR4lxvLYHmOHDcS7HH4 wBbDQnoEFHMVNWOoNPre5s/iqtOACZR/5DP7cTcyxxxDBbF7EIRMmExLu5Entqzh breP0Jtq =kgPI -----END PGP SIGNATURE----- --rbDVY1A5evmOIoPD--