From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7535C433EF for ; Thu, 28 Oct 2021 17:12:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADE89610C7 for ; Thu, 28 Oct 2021 17:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230424AbhJ1ROb (ORCPT ); Thu, 28 Oct 2021 13:14:31 -0400 Received: from foss.arm.com ([217.140.110.172]:57424 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230223AbhJ1ROa (ORCPT ); Thu, 28 Oct 2021 13:14:30 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D0B31063; Thu, 28 Oct 2021 10:12:03 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C7F43F70D; Thu, 28 Oct 2021 10:12:00 -0700 (PDT) Date: Thu, 28 Oct 2021 18:11:55 +0100 From: Mark Rutland To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org, paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, torvalds@linux-foundation.org, tsbogend@alpha.franken.de, vgupta@kernel.org, will@kernel.org Subject: Re: [PATCH 03/15] irq: mips: simplify do_domain_IRQ() Message-ID: <20211028171153.GA42845@lakrids.cambridge.arm.com> References: <20211021180236.37428-1-mark.rutland@arm.com> <20211021180236.37428-4-mark.rutland@arm.com> <20211028170732.GA507928@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211028170732.GA507928@roeck-us.net> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 28, 2021 at 10:07:32AM -0700, Guenter Roeck wrote: > On Thu, Oct 21, 2021 at 07:02:24PM +0100, Mark Rutland wrote: > > There's no need fpr arch/mips's do_domain_IRQ() to open-code the NULL > > check performed by handle_irq_desc(), nor the resolution of the desc > > performed by generic_handle_domain_irq(). > > > > Use generic_handle_domain_irq() directly, as this is functioanlly > > equivalent and clearer. > > > > There should be no functional change as a result of this patch. > > > > Except for this compile error: > > arch/mips/kernel/irq.c: In function 'do_domain_IRQ': > arch/mips/kernel/irq.c:114:26: error: unused variable 'desc' [-Werror=unused-variable] > 114 | struct irq_desc *desc; > > Guenter Sorry for that; this has been fixed by: https://lore.kernel.org/r/20211028095652.3503790-1-siyanteng@loongson.cn ... which is queued up: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/remove-handle-domain-irq-20211026&id=34fca8947b2743e6a3a9a8a3a44962e625993533 Thanks, Mark. > > > Signed-off-by: Mark Rutland > > Cc: Marc Zyngier > > Cc: Thomas Bogendoerfer > > Cc: Thomas Gleixner > > --- > > arch/mips/kernel/irq.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c > > index d20e002b3246..1fee96ef8059 100644 > > --- a/arch/mips/kernel/irq.c > > +++ b/arch/mips/kernel/irq.c > > @@ -115,11 +115,7 @@ void __irq_entry do_domain_IRQ(struct irq_domain *domain, unsigned int hwirq) > > > > irq_enter(); > > check_stack_overflow(); > > - > > - desc = irq_resolve_mapping(domain, hwirq); > > - if (likely(desc)) > > - handle_irq_desc(desc); > > - > > + generic_handle_domain_irq(domain, hwirq); > > irq_exit(); > > } > > #endif > > -- > > 2.11.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBE7C433EF for ; Thu, 28 Oct 2021 17:13:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F321610D2 for ; Thu, 28 Oct 2021 17:13:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3F321610D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hdBvbwLzjwF0LXgmP/LZ975zIDVzjCXNwAvMt+RQ0ys=; b=a86fODku9BMk+p /+LNrvJjcn0gU+Xypiho3oo/5GlWI4zFoPOyEPl8BPMaDKoxmiM3Ks8zGiI7MrdfmEnvK2US7fIzS bPsvA6rLLh8QFgH3grord9obNRo7ihzv03K+na8T3GseEKuEFTTpRZHcqnS3eGSrfqNw3Ie7n+LiA 3ap3mUqub8DPlJvKxR+3YMEGM6bFYOMfFk7Chxyi7sdFLCVZn/EvgsHPGl2q5scSMVkYZR9ghHvJC wpaJi4HW3cIN/NDn64/K3o4fpf5z6LUSU9kdougsvolfXahnPhLcCkaYu769ak2DaTsNxx5pd6Ic/ 8P6o7VkqR7IEzdBXCQyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg8wk-008h3W-GN; Thu, 28 Oct 2021 17:12:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg8wf-008h2J-FU for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 17:12:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D0B31063; Thu, 28 Oct 2021 10:12:03 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C7F43F70D; Thu, 28 Oct 2021 10:12:00 -0700 (PDT) Date: Thu, 28 Oct 2021 18:11:55 +0100 From: Mark Rutland To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org, paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, torvalds@linux-foundation.org, tsbogend@alpha.franken.de, vgupta@kernel.org, will@kernel.org Subject: Re: [PATCH 03/15] irq: mips: simplify do_domain_IRQ() Message-ID: <20211028171153.GA42845@lakrids.cambridge.arm.com> References: <20211021180236.37428-1-mark.rutland@arm.com> <20211021180236.37428-4-mark.rutland@arm.com> <20211028170732.GA507928@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211028170732.GA507928@roeck-us.net> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_101205_579066_A01386A4 X-CRM114-Status: GOOD ( 20.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 10:07:32AM -0700, Guenter Roeck wrote: > On Thu, Oct 21, 2021 at 07:02:24PM +0100, Mark Rutland wrote: > > There's no need fpr arch/mips's do_domain_IRQ() to open-code the NULL > > check performed by handle_irq_desc(), nor the resolution of the desc > > performed by generic_handle_domain_irq(). > > > > Use generic_handle_domain_irq() directly, as this is functioanlly > > equivalent and clearer. > > > > There should be no functional change as a result of this patch. > > > > Except for this compile error: > > arch/mips/kernel/irq.c: In function 'do_domain_IRQ': > arch/mips/kernel/irq.c:114:26: error: unused variable 'desc' [-Werror=unused-variable] > 114 | struct irq_desc *desc; > > Guenter Sorry for that; this has been fixed by: https://lore.kernel.org/r/20211028095652.3503790-1-siyanteng@loongson.cn ... which is queued up: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/remove-handle-domain-irq-20211026&id=34fca8947b2743e6a3a9a8a3a44962e625993533 Thanks, Mark. > > > Signed-off-by: Mark Rutland > > Cc: Marc Zyngier > > Cc: Thomas Bogendoerfer > > Cc: Thomas Gleixner > > --- > > arch/mips/kernel/irq.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c > > index d20e002b3246..1fee96ef8059 100644 > > --- a/arch/mips/kernel/irq.c > > +++ b/arch/mips/kernel/irq.c > > @@ -115,11 +115,7 @@ void __irq_entry do_domain_IRQ(struct irq_domain *domain, unsigned int hwirq) > > > > irq_enter(); > > check_stack_overflow(); > > - > > - desc = irq_resolve_mapping(domain, hwirq); > > - if (likely(desc)) > > - handle_irq_desc(desc); > > - > > + generic_handle_domain_irq(domain, hwirq); > > irq_exit(); > > } > > #endif > > -- > > 2.11.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel