From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D6DC433EF for ; Thu, 28 Oct 2021 17:29:18 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F0D960D07 for ; Thu, 28 Oct 2021 17:29:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3F0D960D07 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4DFD4834A3; Thu, 28 Oct 2021 19:29:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="V5Tlywao"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A9150834A4; Thu, 28 Oct 2021 19:29:14 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 10D0383480 for ; Thu, 28 Oct 2021 19:29:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id bl14so6597200qkb.4 for ; Thu, 28 Oct 2021 10:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PTIIBmqrt0/2rOPWOQrcdcjI1JEmiNVTlnlwDvbwmfk=; b=V5TlywaohhRKepeZVJy1OhgqoogNlQEKgjBet3dvdfJ7FNEZwZSpf8VmpGMhJTkCKn yip2j1+HJKEQ4x6jj1PrxfQO27brWcZMFkAid66/4RXJjCwAZjPZtAeNHdUNW29ejKcs Wzd1i1zqU417hC0gkmiGpWKBPK0Pyl3Nz1d+8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PTIIBmqrt0/2rOPWOQrcdcjI1JEmiNVTlnlwDvbwmfk=; b=559Np4AdmQEK/nQZO9PUHxSh/cb20hmpQl9ssGMvuAyblicv7y89AjixciozbPRql+ kyaop6PprKxvR9czDWOkfWLjVOmqg1HmYYlggT4l7iqEN/sPxPQ63OfG2SzNAt9DH381 Duk0vQcjOWP/wO3z5pZSnTlNYLwoFtV3KDIY58wMKP6JD4MOVpuA34sP9Tcy3sT4lsTi 3eNzQNji//9kVjnnAORHMUuR3iO5OxcgHubdwAtGnhQwUIjqSVX3qb658Oj5SxaKcROW kuIH+kxg4cn8ggG0Q+xTZlJnnm5Nxa67oYwkG0LvTD7hrHHkSGlffcnLrdHmo5w9YzhP hMtg== X-Gm-Message-State: AOAM531p+V3nwx5MUEvTdUAwYoQakAKdGvAsnuMMEvB5k8IJrT5zMBQg GbLAMBuLtVauHsfyUetehmhMSg== X-Google-Smtp-Source: ABdhPJwGQC+g0bqOov8slvVI1Zmmr0U9gLVOXFOR3RwcMRjZAwc2fvDME1b/YzE5ILEtxjUlA3hfPg== X-Received: by 2002:a05:620a:2442:: with SMTP id h2mr4897792qkn.298.1635442146505; Thu, 28 Oct 2021 10:29:06 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-015b-1704-43dd-8832.res6.spectrum.com. [2603:6081:7b01:cbda:15b:1704:43dd:8832]) by smtp.gmail.com with ESMTPSA id z6sm2494014qta.31.2021.10.28.10.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 10:29:05 -0700 (PDT) Date: Thu, 28 Oct 2021 13:29:03 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Michal Simek , Heinrich Schuchardt , Ilias Apalodimas , Daniel Schwierzeck , Steffen Jaeckel , Marek =?iso-8859-1?Q?Beh=FAn?= , Lukas Auer , Dennis Gilmore Subject: Re: [PATCH v2 41/41] RFC: Switch rpi over to use bootstd Message-ID: <20211028172903.GC8284@bill-the-cat> References: <20211023232635.9195-1-sjg@chromium.org> <20211023232635.9195-29-sjg@chromium.org> <20211028164316.GB8284@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZuerDrdIzQbPgkrC" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --ZuerDrdIzQbPgkrC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 28, 2021 at 11:16:31AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Thu, 28 Oct 2021 at 10:43, Tom Rini wrote: > > > > On Sat, Oct 23, 2021 at 05:26:35PM -0600, Simon Glass wrote: > > > > > Switch this over, for testing purposes. > > > > > > Signed-off-by: Simon Glass > > [snip] > > > #define CONFIG_EXTRA_ENV_SETTINGS \ > > > "dhcpuboot=3Dusb start; dhcp u-boot.uimg; bootm\0" \ > > > + "boot_targets=3Dmmc0 mmc1 usb0 pxe dhcp\0" \ > > > > So, based on this patch I went "oh, so we can still easily control the > > device order, per board and also for users to tweak". Then I looked for > > where boot_targets was used, saw it wasn't and looked over the > > documentation patch previous to this. That's not looking easier to > > configure than what we have now either. >=20 > Yes, I did originally implement the boot_targets env var, then decided > it should be in the device tree instead, since you can do: >=20 > bootstd { > compatible =3D "u-boot,boot-std"; > bootdev-order =3D "mmc2", "mmc1"; > }; >=20 > (with nothing else in the devicetree) >=20 > I made this change since it seems that boot_targets is always set in > the env and should not be touched by the distro. If that is not > correct I can bring the code back... Aside from what I said to the cover letter, I think all of the device tree stuff is taking it the wrong direction. The environment is something that can easily be manipulated in a persistent and well understood manner by a number of tools, and is done so today. Defining the boot order to start with in a device tree fragment is going to be annoying for all of the platforms where the device tree comes from somewhere else. But it's going to suck even more for users to manipulate (now that we've installed, we don't want to probe the whole world normally, just check where it's installed). I'm not seeing this as a better step forward at all right now, sorry. > BTW the MAC address was just for my testing. Hoped so, thanks :) --=20 Tom --ZuerDrdIzQbPgkrC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF63dwACgkQFHw5/5Y0 tyxMyQv/WPdmbUGIYPpikJmtCV3I1y148KIbdxlnEbz2FYdz/dRb3t0D+RfVHmoI d6hQcg3q3T3qsHFAnTGnKPXW5/95w9qbqE8caiVe10cCt8L9onsANclCF7bdIU4b PB1/0vu0O7/a1s6BU9fSAotNhS7hT1Z9F2g0Bi9Qo7BY7geiFYnPyaLpjH6DxllA w3fsCPPKuuYX+MKLxzWlfZwnaUrWV8aS/KnjaqQ88Zp+dFeLt3XHuwqzgJIV273S x+McSpqjHu8UqguqZqyrDJPsTVgye0y/bxelhxJOi/mQvEPLvJIPFCElqjru4/TG yc7U7ZVViYcaoFcpy4jDY14KkDNV9+vty6FK9gRdCNVBVo4WAuRAMJTM4lptX6Bt FxBLB4/1MmpjhsIaaSrrNndjDBeyD7ug/8LOIK0/v9EBeTY9RC3CVV6iHes+QsZi 2ucoajX1YHp559BpM8vSq0Wjwk2MYybw/bJnykXbIPJM1+vYy2FL57jEYCNzY2ek WHWHx5Sf =CqCw -----END PGP SIGNATURE----- --ZuerDrdIzQbPgkrC--