Re: [PATCH] xen-pciback: allow compiling on other archs than x86

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3751 bytes --]

Hi Oleksandr,

I love your patch! Perhaps something to improve:

[auto build test WARNING on xen-tip/linux-next]
[also build test WARNING on linux/master linus/master v5.15-rc7 next-20211028]
[cannot apply to helgaas-pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Oleksandr-Andrushchenko/xen-pciback-allow-compiling-on-other-archs-than-x86/20211028-141523
base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/085a7279d0d85497688bc5be9a1f00ab2cce02ae
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Oleksandr-Andrushchenko/xen-pciback-allow-compiling-on-other-archs-than-x86/20211028-141523
        git checkout 085a7279d0d85497688bc5be9a1f00ab2cce02ae
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/xen/pci.c:279:5: warning: no previous prototype for 'xen_find_device_domain_owner' [-Wmissing-prototypes]
     279 | int xen_find_device_domain_owner(struct pci_dev *dev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/xen/pci.c:293:5: warning: no previous prototype for 'xen_register_device_domain_owner' [-Wmissing-prototypes]
     293 | int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/xen/pci.c:315:5: warning: no previous prototype for 'xen_unregister_device_domain_owner' [-Wmissing-prototypes]
     315 | int xen_unregister_device_domain_owner(struct pci_dev *dev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/xen_find_device_domain_owner +279 drivers/xen/pci.c

   278	
 > 279	int xen_find_device_domain_owner(struct pci_dev *dev)
   280	{
   281		struct xen_device_domain_owner *owner;
   282		int domain = -ENODEV;
   283	
   284		spin_lock(&dev_domain_list_spinlock);
   285		owner = find_device(dev);
   286		if (owner)
   287			domain = owner->domain;
   288		spin_unlock(&dev_domain_list_spinlock);
   289		return domain;
   290	}
   291	EXPORT_SYMBOL_GPL(xen_find_device_domain_owner);
   292	
 > 293	int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain)
   294	{
   295		struct xen_device_domain_owner *owner;
   296	
   297		owner = kzalloc(sizeof(struct xen_device_domain_owner), GFP_KERNEL);
   298		if (!owner)
   299			return -ENODEV;
   300	
   301		spin_lock(&dev_domain_list_spinlock);
   302		if (find_device(dev)) {
   303			spin_unlock(&dev_domain_list_spinlock);
   304			kfree(owner);
   305			return -EEXIST;
   306		}
   307		owner->domain = domain;
   308		owner->dev = dev;
   309		list_add_tail(&owner->list, &dev_domain_list);
   310		spin_unlock(&dev_domain_list_spinlock);
   311		return 0;
   312	}
   313	EXPORT_SYMBOL_GPL(xen_register_device_domain_owner);
   314	
 > 315	int xen_unregister_device_domain_owner(struct pci_dev *dev)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 56219 bytes --]