From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1FCD2C82 for ; Thu, 28 Oct 2021 22:13:30 +0000 (UTC) Received: by mail-qt1-f171.google.com with SMTP id 19so5711104qtt.7 for ; Thu, 28 Oct 2021 15:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BxQeetJwEcrw7mZizeh9N8oA8I68HO4YJPCT6BOjW/s=; b=YFX4KkFo8sn9wUT9exIjYE3zy3X6XhfFyUpqK4woD/WNaVGG3KGkVpVflHcB2Qt1lE Xkhb3v3R7klYbEuJFZfZjc88uoGQTQlz55LXKAO/HgzTV1v+Iw3nk3r4l8kDktOetHWv zE+bQ06pDHenulNUaR3PQwa1vJ0rOPI/VD52aaxeqduMEy75r78mNhqQ8H2h5bci8jtS XwmcTcwMGOBl99eASIyea5vPhEfkpKyomJtpy9kr23OXOIjmoOzm/7kz1r2I8u/mpEdv Pn4gxdZZ5msiceUFeN0yQ5DE4zcoTWmFwaQLZYGeLXelxIx+UNHtzObZMzsrRiU9cZv5 pTow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=BxQeetJwEcrw7mZizeh9N8oA8I68HO4YJPCT6BOjW/s=; b=JYpJB2JQ8Hn/dr7+AdOG2epv88Fm7hvB7+HuV+uBukIaUj7cvNT2B4ILzakNSnuEmQ 8lT/Re4eVzp3NO+iXGYfZFDdxNzCbZdsurtddKbmZJvf2fKAcbctNKj/HML450J+Mw/f nyV+O/lff0mX1lAOYyFP4rTGauIehjdzZ325k8b5dAzW23QFaHPBLG0dNUinYA2+myU/ eR7+jKNjbNePYk+w20tV+Tf10mDhemkCh1WtcRRlOPEH1H3oc9H79PW+Zmz7zYHN+LoA sUL+NMWXAgPJOUzvkFQZec96LcD3vHaGD0DhlqorUm9b2jqOALpMxMgTQM0KH+Cf6b8P P3dg== X-Gm-Message-State: AOAM531VYkhCba6mE2/qZF3ikatTryAqDr0x1TWqQm6mbICxk8j8wK4n GApnhZAYgb5sQrle4kqlAso= X-Google-Smtp-Source: ABdhPJw7Ip+mVVOhi3P5MeUydNnz0+e4/X81XifGWVT5beNjEjvIb8weALxoCTaaNT8lMLrlpNCpGQ== X-Received: by 2002:ac8:5d8c:: with SMTP id d12mr7510623qtx.184.1635459209652; Thu, 28 Oct 2021 15:13:29 -0700 (PDT) Received: from localhost.localdomain ([67.8.38.84]) by smtp.gmail.com with ESMTPSA id h2sm2791097qkf.106.2021.10.28.15.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 15:13:29 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: airlied@linux.ie, daniel@ffwll.ch, jernej.skrabec@gmail.com, wens@csie.org, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, fazilyildiran@gmail.com Subject: [PATCH] drm/sun4i: fix unmet dependency on RESET_CONTROLLER for PHY_SUN6I_MIPI_DPHY Date: Thu, 28 Oct 2021 18:13:27 -0400 Message-Id: <20211028221327.17984-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER is not selected, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY Depends on [n]: (ARCH_SUNXI [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=n] Selected by [y]: - DRM_SUN6I_DSI [=y] && HAS_IOMEM [=y] && DRM_SUN4I [=y] This is because DRM_SUN6I_DSI selects PHY_SUN6I_MIPI_DPHY without selecting or depending on RESET_CONTROLLER, despite PHY_SUN6I_MIPI_DPHY depending on RESET_CONTROLLER. These unmet dependency bugs were detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha --- drivers/gpu/drm/sun4i/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig index 5755f0432e77..3f70a14a3c94 100644 --- a/drivers/gpu/drm/sun4i/Kconfig +++ b/drivers/gpu/drm/sun4i/Kconfig @@ -46,6 +46,7 @@ config DRM_SUN6I_DSI default MACH_SUN8I select CRC_CCITT select DRM_MIPI_DSI + select RESET_CONTROLLER select PHY_SUN6I_MIPI_DPHY help Choose this option if you want have an Allwinner SoC with -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 424DEC433F5 for ; Thu, 28 Oct 2021 22:15:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08EEB60E8B for ; Thu, 28 Oct 2021 22:15:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08EEB60E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=nXvuBqE+oHxpr2oSxtO4plEvnVCXeMNcyGb+h/KixDY=; b=j+1HEvsf8w+aWE hIGrPFaKgO+zgGxnWPsgqUR84oDNbrVX1ElcAwt+2qbG4u7HZFULna663vj/RhyScwvapfMIYhhrT PdrLqSXJYJB+2BLV9v1lTLYI3ChDiwhfGMwOKZi8NNLbD16KDIsTcS6rDFhrmS7iGDsw0ajBYU1hE vNx9QF8Ui98JWdUZ1wFL2kDU9pDrPWfQM43PVLgBqjl4PTqWA29zA8Ajpz+ELoR/3pH0hmJSP5RG7 x30lMvRTOIjTE0Qa4Ua8ekDPCHdQHyIOzI4nwyvsA02Xvf2MbPF5Ct81bCmeUZQK2Q6plmVzSpiNT NN/upBc6Miu6yM9oJHeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgDeQ-009E9x-7d; Thu, 28 Oct 2021 22:13:34 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgDeM-009E9Y-PA for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 22:13:32 +0000 Received: by mail-qt1-x82b.google.com with SMTP id v17so7320861qtp.1 for ; Thu, 28 Oct 2021 15:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BxQeetJwEcrw7mZizeh9N8oA8I68HO4YJPCT6BOjW/s=; b=YFX4KkFo8sn9wUT9exIjYE3zy3X6XhfFyUpqK4woD/WNaVGG3KGkVpVflHcB2Qt1lE Xkhb3v3R7klYbEuJFZfZjc88uoGQTQlz55LXKAO/HgzTV1v+Iw3nk3r4l8kDktOetHWv zE+bQ06pDHenulNUaR3PQwa1vJ0rOPI/VD52aaxeqduMEy75r78mNhqQ8H2h5bci8jtS XwmcTcwMGOBl99eASIyea5vPhEfkpKyomJtpy9kr23OXOIjmoOzm/7kz1r2I8u/mpEdv Pn4gxdZZ5msiceUFeN0yQ5DE4zcoTWmFwaQLZYGeLXelxIx+UNHtzObZMzsrRiU9cZv5 pTow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=BxQeetJwEcrw7mZizeh9N8oA8I68HO4YJPCT6BOjW/s=; b=QRZ0FzkIJyt0NxyMpjhVcBLuq4riWkldcxpc5tm9n/u430rFehDAkfSmYcBoj9pis7 V3q6GKJZwknVBJ0ewgkIDBE4XRfP44BIrPSaXZa1LZH8qNGB6KkHPOsaagXwea6iF+2K 7KHAZaaW4Y1OGnIUN6Rwv/8h9ZUpPbc4lhVDuT3RNE2A12KJ2TQtiaed1hDpNPkJFqJ+ jZnd+CAiuC9SNZ2sJBiP6nzcNPf64Vi83wUPZzbj9MazTyzl4Vhn0qN0VUS9rQ+p6/sy 91a97/OMR0xp8oQs232ZFyfMUtj/OZV/Cy4fsNwPEJD9ROyUkxDLJ/eLbnd1b0xUsbcx Wgpg== X-Gm-Message-State: AOAM533vx854tIjd1Zto50Q8QMQFLgWn2ng0BocEih3lalzVTUSKMjvK ZY13AfTyb6WvUf2tjCKpDw8= X-Google-Smtp-Source: ABdhPJw7Ip+mVVOhi3P5MeUydNnz0+e4/X81XifGWVT5beNjEjvIb8weALxoCTaaNT8lMLrlpNCpGQ== X-Received: by 2002:ac8:5d8c:: with SMTP id d12mr7510623qtx.184.1635459209652; Thu, 28 Oct 2021 15:13:29 -0700 (PDT) Received: from localhost.localdomain ([67.8.38.84]) by smtp.gmail.com with ESMTPSA id h2sm2791097qkf.106.2021.10.28.15.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 15:13:29 -0700 (PDT) From: Julian Braha To: airlied@linux.ie, daniel@ffwll.ch, jernej.skrabec@gmail.com, wens@csie.org, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, fazilyildiran@gmail.com Subject: [PATCH] drm/sun4i: fix unmet dependency on RESET_CONTROLLER for PHY_SUN6I_MIPI_DPHY Date: Thu, 28 Oct 2021 18:13:27 -0400 Message-Id: <20211028221327.17984-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_151330_839567_F42093CD X-CRM114-Status: GOOD ( 10.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER is not selected, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY Depends on [n]: (ARCH_SUNXI [=n] || COMPILE_TEST [=y]) && HAS_IOMEM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=n] Selected by [y]: - DRM_SUN6I_DSI [=y] && HAS_IOMEM [=y] && DRM_SUN4I [=y] This is because DRM_SUN6I_DSI selects PHY_SUN6I_MIPI_DPHY without selecting or depending on RESET_CONTROLLER, despite PHY_SUN6I_MIPI_DPHY depending on RESET_CONTROLLER. These unmet dependency bugs were detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha --- drivers/gpu/drm/sun4i/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig index 5755f0432e77..3f70a14a3c94 100644 --- a/drivers/gpu/drm/sun4i/Kconfig +++ b/drivers/gpu/drm/sun4i/Kconfig @@ -46,6 +46,7 @@ config DRM_SUN6I_DSI default MACH_SUN8I select CRC_CCITT select DRM_MIPI_DSI + select RESET_CONTROLLER select PHY_SUN6I_MIPI_DPHY help Choose this option if you want have an Allwinner SoC with -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel