From: Christian Brauner <christian.brauner@ubuntu.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH v4 01/13] fs_parse: allow parameter value to be empty
Date: Fri, 29 Oct 2021 10:44:11 +0200 [thread overview]
Message-ID: <20211029084411.zk32u3hflf2vdzmx@wittgenstein> (raw)
In-Reply-To: <20211027141857.33657-2-lczerner@redhat.com>
On Wed, Oct 27, 2021 at 04:18:45PM +0200, Lukas Czerner wrote:
> Allow parameter value to be empty by specifying fs_param_can_be_empty
> flag.
Hey Lukas,
what option is this for? Usually this should be handled by passing
FSCONFIG_SET_FLAG. Doesn't seem like a good idea to let the string value
be optionally empty. I'd rather have the guarantee that it has to be
something instead of having to be extra careful because it could be NULL.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/fs_parser.c | 31 +++++++++++++++++++++++--------
> include/linux/fs_parser.h | 2 +-
> 2 files changed, 24 insertions(+), 9 deletions(-)
>
> diff --git a/fs/fs_parser.c b/fs/fs_parser.c
> index 3df07c0e32b3..ed40ce5742fd 100644
> --- a/fs/fs_parser.c
> +++ b/fs/fs_parser.c
> @@ -199,6 +199,8 @@ int fs_param_is_bool(struct p_log *log, const struct fs_parameter_spec *p,
> int b;
> if (param->type != fs_value_is_string)
> return fs_param_bad_value(log, param);
> + if (!*param->string && (p->flags & fs_param_can_be_empty))
> + return 0;
> b = lookup_constant(bool_names, param->string, -1);
> if (b == -1)
> return fs_param_bad_value(log, param);
> @@ -211,8 +213,11 @@ int fs_param_is_u32(struct p_log *log, const struct fs_parameter_spec *p,
> struct fs_parameter *param, struct fs_parse_result *result)
> {
> int base = (unsigned long)p->data;
> - if (param->type != fs_value_is_string ||
> - kstrtouint(param->string, base, &result->uint_32) < 0)
> + if (param->type != fs_value_is_string)
> + return fs_param_bad_value(log, param);
> + if (!*param->string && (p->flags & fs_param_can_be_empty))
> + return 0;
> + if (kstrtouint(param->string, base, &result->uint_32) < 0)
> return fs_param_bad_value(log, param);
> return 0;
> }
> @@ -221,8 +226,11 @@ EXPORT_SYMBOL(fs_param_is_u32);
> int fs_param_is_s32(struct p_log *log, const struct fs_parameter_spec *p,
> struct fs_parameter *param, struct fs_parse_result *result)
> {
> - if (param->type != fs_value_is_string ||
> - kstrtoint(param->string, 0, &result->int_32) < 0)
> + if (param->type != fs_value_is_string)
> + return fs_param_bad_value(log, param);
> + if (!*param->string && (p->flags & fs_param_can_be_empty))
> + return 0;
> + if (kstrtoint(param->string, 0, &result->int_32) < 0)
> return fs_param_bad_value(log, param);
> return 0;
> }
> @@ -231,8 +239,11 @@ EXPORT_SYMBOL(fs_param_is_s32);
> int fs_param_is_u64(struct p_log *log, const struct fs_parameter_spec *p,
> struct fs_parameter *param, struct fs_parse_result *result)
> {
> - if (param->type != fs_value_is_string ||
> - kstrtoull(param->string, 0, &result->uint_64) < 0)
> + if (param->type != fs_value_is_string)
> + return fs_param_bad_value(log, param);
> + if (!*param->string && (p->flags & fs_param_can_be_empty))
> + return 0;
> + if (kstrtoull(param->string, 0, &result->uint_64) < 0)
> return fs_param_bad_value(log, param);
> return 0;
> }
> @@ -244,6 +255,8 @@ int fs_param_is_enum(struct p_log *log, const struct fs_parameter_spec *p,
> const struct constant_table *c;
> if (param->type != fs_value_is_string)
> return fs_param_bad_value(log, param);
> + if (!*param->string && (p->flags & fs_param_can_be_empty))
> + return 0;
> c = __lookup_constant(p->data, param->string);
> if (!c)
> return fs_param_bad_value(log, param);
> @@ -255,7 +268,8 @@ EXPORT_SYMBOL(fs_param_is_enum);
> int fs_param_is_string(struct p_log *log, const struct fs_parameter_spec *p,
> struct fs_parameter *param, struct fs_parse_result *result)
> {
> - if (param->type != fs_value_is_string || !*param->string)
> + if (param->type != fs_value_is_string ||
> + (!*param->string && !(p->flags & fs_param_can_be_empty)))
> return fs_param_bad_value(log, param);
> return 0;
> }
> @@ -275,7 +289,8 @@ int fs_param_is_fd(struct p_log *log, const struct fs_parameter_spec *p,
> {
> switch (param->type) {
> case fs_value_is_string:
> - if (kstrtouint(param->string, 0, &result->uint_32) < 0)
> + if ((!*param->string && !(p->flags & fs_param_can_be_empty)) ||
> + kstrtouint(param->string, 0, &result->uint_32) < 0)
> break;
> if (result->uint_32 <= INT_MAX)
> return 0;
> diff --git a/include/linux/fs_parser.h b/include/linux/fs_parser.h
> index aab0ffc6bac6..f103c91139d4 100644
> --- a/include/linux/fs_parser.h
> +++ b/include/linux/fs_parser.h
> @@ -42,7 +42,7 @@ struct fs_parameter_spec {
> u8 opt; /* Option number (returned by fs_parse()) */
> unsigned short flags;
> #define fs_param_neg_with_no 0x0002 /* "noxxx" is negative param */
> -#define fs_param_neg_with_empty 0x0004 /* "xxx=" is negative param */
> +#define fs_param_can_be_empty 0x0004 /* "xxx=" is allowed */
> #define fs_param_deprecated 0x0008 /* The param is deprecated */
> const void *data;
> };
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-10-29 8:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 14:18 [PATCH v4 00/13] ext4: new mount API conversion Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 01/13] fs_parse: allow parameter value to be empty Lukas Czerner
2021-10-29 8:44 ` Christian Brauner [this message]
2021-11-01 9:25 ` Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 02/13] ext4: Add fs parameter specifications for mount options Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 03/13] ext4: move option validation to a separate function Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 04/13] ext4: Change handle_mount_opt() to use fs_parameter Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 05/13] ext4: Allow sb to be NULL in ext4_msg() Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 06/13] ext4: move quota configuration out of handle_mount_opt() Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 07/13] ext4: check ext2/3 compatibility outside handle_mount_opt() Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 08/13] ext4: get rid of super block and sbi from handle_mount_ops() Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 09/13] ext4: Completely separate options parsing and sb setup Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 10/13] ext4: clean up return values in handle_mount_opt() Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 11/13] ext4: change token2str() to use ext4_param_specs Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 12/13] ext4: switch to the new mount api Lukas Czerner
2021-10-27 14:18 ` [PATCH v4 13/13] ext4: Remove unused match_table_t tokens Lukas Czerner
2021-10-27 21:39 ` [PATCH v4 00/13] ext4: new mount API conversion Sedat Dilek
2021-10-28 13:49 ` Lukas Czerner
2021-12-09 19:17 ` Theodore Y. Ts'o
2021-12-09 19:55 ` Lukas Czerner
2021-12-09 22:09 ` Theodore Y. Ts'o
2021-12-09 22:22 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029084411.zk32u3hflf2vdzmx@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=cmaiolino@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.