All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zhijian <zhijianx.li@intel.com>
To: dave@stgolabs.net, joel@joelfernandes.org, josh@joshtriplett.org,
	mathieu.desnoyers@efficios.com, paulmck@kernel.org,
	rostedt@goodmis.org, rcu@vger.kernel.org
Cc: philip.li@intel.com, lizhijian@cn.fujitsu.com,
	jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
	Li Zhijian <zhijianx.li@intel.com>
Subject: [PATCH 5/6] rcuscale: alwaly log error message
Date: Fri, 29 Oct 2021 17:40:28 +0800	[thread overview]
Message-ID: <20211029094029.22501-6-zhijianx.li@intel.com> (raw)
In-Reply-To: <20211029094029.22501-1-zhijianx.li@intel.com>

Generally, error message should be logged anyhow.

Signed-off-by: Li Zhijian <zhijianx.li@intel.com>
---
 kernel/rcu/rcuscale.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
index 2cc34a22a506..5c8449a8827a 100644
--- a/kernel/rcu/rcuscale.c
+++ b/kernel/rcu/rcuscale.c
@@ -50,8 +50,8 @@ MODULE_AUTHOR("Paul E. McKenney <paulmck@linux.ibm.com>");
 	pr_alert("%s" SCALE_FLAG " %s\n", scale_type, s)
 #define VERBOSE_SCALEOUT_STRING(s) \
 	do { if (verbose) pr_alert("%s" SCALE_FLAG " %s\n", scale_type, s); } while (0)
-#define VERBOSE_SCALEOUT_ERRSTRING(s) \
-	do { if (verbose) pr_alert("%s" SCALE_FLAG "!!! %s\n", scale_type, s); } while (0)
+#define SCALEOUT_ERRSTRING(s) \
+	pr_alert("%s" SCALE_FLAG "!!! %s\n", scale_type, s)
 
 /*
  * The intended use cases for the nreaders and nwriters module parameters
@@ -514,11 +514,11 @@ rcu_scale_cleanup(void)
 	 * during the mid-boot phase, so have to wait till the end.
 	 */
 	if (rcu_gp_is_expedited() && !rcu_gp_is_normal() && !gp_exp)
-		VERBOSE_SCALEOUT_ERRSTRING("All grace periods expedited, no normal ones to measure!");
+		SCALEOUT_ERRSTRING("All grace periods expedited, no normal ones to measure!");
 	if (rcu_gp_is_normal() && gp_exp)
-		VERBOSE_SCALEOUT_ERRSTRING("All grace periods normal, no expedited ones to measure!");
+		SCALEOUT_ERRSTRING("All grace periods normal, no expedited ones to measure!");
 	if (gp_exp && gp_async)
-		VERBOSE_SCALEOUT_ERRSTRING("No expedited async GPs, so went with async!");
+		SCALEOUT_ERRSTRING("No expedited async GPs, so went with async!");
 
 	if (torture_cleanup_begin())
 		return;
@@ -845,7 +845,7 @@ rcu_scale_init(void)
 	reader_tasks = kcalloc(nrealreaders, sizeof(reader_tasks[0]),
 			       GFP_KERNEL);
 	if (reader_tasks == NULL) {
-		VERBOSE_SCALEOUT_ERRSTRING("out of memory");
+		SCALEOUT_ERRSTRING("out of memory");
 		firsterr = -ENOMEM;
 		goto unwind;
 	}
@@ -865,7 +865,7 @@ rcu_scale_init(void)
 		kcalloc(nrealwriters, sizeof(*writer_n_durations),
 			GFP_KERNEL);
 	if (!writer_tasks || !writer_durations || !writer_n_durations) {
-		VERBOSE_SCALEOUT_ERRSTRING("out of memory");
+		SCALEOUT_ERRSTRING("out of memory");
 		firsterr = -ENOMEM;
 		goto unwind;
 	}
-- 
2.32.0


  parent reply	other threads:[~2021-10-29  9:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29  9:40 [PATCH 0/6] minor fixes and cleanups in rcuscale and torture tests Li Zhijian
2021-10-29  9:40 ` [PATCH 1/6] refscale: add missing '\n' to flush message out Li Zhijian
2021-10-29  9:40 ` [PATCH 2/6] scftorture: " Li Zhijian
2021-10-29  9:40 ` [PATCH 3/6] scftorture: remove unused SCFTORTOUT Li Zhijian
2021-10-29  9:40 ` [PATCH 4/6] scftorture: always log error message Li Zhijian
2021-11-02 16:06   ` Paul E. McKenney
2021-11-03  8:24     ` Li Zhijian
2021-10-29  9:40 ` Li Zhijian [this message]
2021-10-29 16:40   ` [PATCH 5/6] rcuscale: alwaly " Davidlohr Bueso
2021-11-02 16:09   ` Paul E. McKenney
2021-10-29  9:40 ` [PATCH 6/6] locktorture,rcutorture,torture: always " Li Zhijian
2021-10-29 16:41 ` [PATCH 0/6] minor fixes and cleanups in rcuscale and torture tests Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211029094029.22501-6-zhijianx.li@intel.com \
    --to=zhijianx.li@intel.com \
    --cc=dave@stgolabs.net \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@kernel.org \
    --cc=philip.li@intel.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.