From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8A6C433EF for ; Fri, 29 Oct 2021 10:51:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCF3E61051 for ; Fri, 29 Oct 2021 10:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231849AbhJ2Kx6 (ORCPT ); Fri, 29 Oct 2021 06:53:58 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:43568 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231820AbhJ2Kxz (ORCPT ); Fri, 29 Oct 2021 06:53:55 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 4DEAD1FD53; Fri, 29 Oct 2021 10:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635504686; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TyVjdqscO8NIKtfAt2hF9LKJUEv3Q/czSE4LKTRarjc=; b=zZ1zDKWhGmi5teD7umyt5oUZFIlgWwFgnyPYKHvX98GXsx4iBTMwxd9qVhCzpBIqgjS0M4 pic5fH4zm9R/bZaEH8GwFhGmszsjyhMMrk07cnOtaddevtzsBGzhXhh2zSQxnibsChrVWG v3El+ftG2E18fFCpzpd3dbcJ2Il214w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635504686; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TyVjdqscO8NIKtfAt2hF9LKJUEv3Q/czSE4LKTRarjc=; b=B05G5e+1Azeb7fWZW21ZJ4WbYU0OQ1qPdtD96mnIxK3oQSMiifPdfYVblT0u+fhwmd0K4V PhXJMZRYnwKo6eDA== Received: from ds.suse.cz (ds.suse.cz [10.100.12.205]) by relay2.suse.de (Postfix) with ESMTP id 413F0A3B85; Fri, 29 Oct 2021 10:51:26 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 14300DA7A9; Fri, 29 Oct 2021 12:50:53 +0200 (CEST) Date: Fri, 29 Oct 2021 12:50:52 +0200 From: David Sterba To: Stephen Rothwell Cc: Linux Kernel Mailing List , Linux Next Mailing List , Kees Cook , Andrew Morton Subject: Re: linux-next: build failure after merge of the btrfs tree Message-ID: <20211029105052.GW20319@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List , Kees Cook , Andrew Morton References: <20211027210924.22ef5881@canb.auug.org.au> <20211029095226.GV20319@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211029095226.GV20319@suse.cz> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 29, 2021 at 11:52:26AM +0200, David Sterba wrote: > On Wed, Oct 27, 2021 at 09:09:24PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > [I am not sure why this error only popped up after I merged Andrew's > > patch set ...] > > > > After merging the btrfs tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > In file included from include/linux/string.h:253, > > from include/linux/bitmap.h:11, > > from include/linux/cpumask.h:12, > > from arch/x86/include/asm/cpumask.h:5, > > from arch/x86/include/asm/msr.h:11, > > from arch/x86/include/asm/processor.h:22, > > from arch/x86/include/asm/cpufeature.h:5, > > from arch/x86/include/asm/thread_info.h:53, > > from include/linux/thread_info.h:60, > > from arch/x86/include/asm/preempt.h:7, > > from include/linux/preempt.h:78, > > from include/linux/spinlock.h:55, > > from include/linux/wait.h:9, > > from include/linux/mempool.h:8, > > from include/linux/bio.h:8, > > from fs/btrfs/ioctl.c:7: > > In function 'memcpy', > > inlined from '_btrfs_ioctl_send' at fs/btrfs/ioctl.c:4846:3: > > include/linux/fortify-string.h:219:4: error: call to '__write_overflow' declared with attribute error: detected write beyond size of object (1st parameter) > > 219 | __write_overflow(); > > | ^~~~~~~~~~~~~~~~~~ > > > > Caused by commit > > > > c8d9cdfc766d ("btrfs: send: prepare for v2 protocol") > > > > This changes the "reserved" field of struct btrfs_ioctl_send_args from 4 u64's to 3, but the above memcpy is copying the "reserved" filed from a struct btrfs_ioctl_send_args_32 (4 u64s) into it. > > I'll fix it in the next update. There are two structures for the ioctl > that need to be in sync but I forgot to do that. Now pushed with top commit 764ada31357678. Also I think that next time you can use some older version of the for-next branch instead of making the whole subsystem depend on BROKEN. This causes much more harm in the testing setups that suddenly can't work at all, compared to testing a few days older branch.