From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D61F52C83 for ; Fri, 29 Oct 2021 11:54:21 +0000 (UTC) Received: by gofer.mess.org (Postfix, from userid 1000) id 1493DC638B; Fri, 29 Oct 2021 12:54:13 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mess.org; s=2020; t=1635508453; bh=1ibxwqgBZhCbkK4nb0aNYAFKQRFLUuXXiDUrBdxYH+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n9s6MW2Kc68g44HK8GwSp2AYpSNTNWxYIksaYr9fiqOOSv3DFrcBMwLEi77QBNchy HA2ZtAIjt+hw8Vg9rAGowMOrbTKQZf6r02m7Ow/Xpl/z2W6VFMgmDzK7cqqRo8dmBl EsgthhJ/+fGXuxpJdESnaz2T+rNZ8zuvtsdMuVfjSNo4cocQXT80abn6Nc3Sbm5c83 wrzn6iCVBY0JukBkFH8v66awRXqcFBgMhukmqTpUv0XRNiocLUUN9Qxbw9PCMbFuNO orIcmolElUKprCSP5xWlejyXS93XmuIbBh3tbNXY5SVG6vShvAQgQE3W2oafxVkOUf 0s3voRAdpvocg== Date: Fri, 29 Oct 2021 12:54:12 +0100 From: Sean Young To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: =?iso-8859-1?Q?Ma=EDra?= Canal , lkp@intel.com, mchehab@kernel.org, thierry.reding@gmail.com, lee.jones@linaro.org, llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH v4] media: rc: pwm-ir-tx: Switch to atomic PWM API Message-ID: <20211029115412.GA32383@gofer.mess.org> References: <20211028064513.guziv6uaivzlk6ki@pengutronix.de> <20211028091442.GA16514@gofer.mess.org> <20211028111535.x7xgz7domx2lpyfh@pengutronix.de> <20211028122610.GA18767@gofer.mess.org> <20211028180516.t2tpfbzztm7s6cqm@pengutronix.de> <20211029071608.GA28997@gofer.mess.org> <20211029110602.uugnbm5vtfpghiwh@pengutronix.de> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211029110602.uugnbm5vtfpghiwh@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) On Fri, Oct 29, 2021 at 01:06:02PM +0200, Uwe Kleine-König wrote: > On Fri, Oct 29, 2021 at 08:16:08AM +0100, Sean Young wrote: > > This means with your changes, if the carrier and duty cycle are both set > > for each transmission, then we're doing more work. If only the carrier > > is set for each transmission, then there is no net gain/loss (I think), > > but the code size has increased. > > OK, then I discard my patch. > > While reading that I wondered if it makes sense to have a callback that > sets both carrier and duty cycle and then remove the other two. There are separate lirc ioctls to set carrier and duty cycle, that's why there are separate callbacks. Sean From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8444576350410238339==" MIME-Version: 1.0 From: Sean Young To: kbuild-all@lists.01.org Subject: Re: [PATCH v4] media: rc: pwm-ir-tx: Switch to atomic PWM API Date: Fri, 29 Oct 2021 12:54:12 +0100 Message-ID: <20211029115412.GA32383@gofer.mess.org> In-Reply-To: <20211029110602.uugnbm5vtfpghiwh@pengutronix.de> List-Id: --===============8444576350410238339== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Oct 29, 2021 at 01:06:02PM +0200, Uwe Kleine-K=C3=B6nig wrote: > On Fri, Oct 29, 2021 at 08:16:08AM +0100, Sean Young wrote: > > This means with your changes, if the carrier and duty cycle are both set > > for each transmission, then we're doing more work. If only the carrier > > is set for each transmission, then there is no net gain/loss (I think), > > but the code size has increased. > = > OK, then I discard my patch. > = > While reading that I wondered if it makes sense to have a callback that > sets both carrier and duty cycle and then remove the other two. There are separate lirc ioctls to set carrier and duty cycle, that's why there are separate callbacks. Sean --===============8444576350410238339==--