From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7CCC433F5 for ; Fri, 29 Oct 2021 12:39:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13A6561167 for ; Fri, 29 Oct 2021 12:39:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 13A6561167 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6D42A8321B; Fri, 29 Oct 2021 14:39:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="JPHle31S"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DA14883480; Fri, 29 Oct 2021 14:39:16 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9709282C6D for ; Fri, 29 Oct 2021 14:39:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id ay10so3971798qkb.12 for ; Fri, 29 Oct 2021 05:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LTk94PckNgaHKX5VdxFWgdrYjFbZqZx0X8E3wU+PhOg=; b=JPHle31SBlY0WqNqjYKKaYIp+oSgPLVpdY7cDlDRjv3gDYbLr4In0Nk/x0oyscHg+a xL/NfjDuaM4V2fJq7nHerA8siTRmLGxHQ6PRw3m3oosfVU5ur1JnEO7kiOT4gjXI/I+s v2jC9IDiKlWuVcOOIR2oc4j7pgIfeSrlZ5rEM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LTk94PckNgaHKX5VdxFWgdrYjFbZqZx0X8E3wU+PhOg=; b=SgiDvD7KbAOEbNDHKl2iEaVxEnYaE/WKq4XSGlPFWdnSqir5vwWVJoUBMwHywC9XIM 0uKm5ew9HJbKZvGRmMhsozVQeDzmk64c8jEYeNPamxlsD1a15w8n/QH/u1yFbPynw0MP eNhE5iCNHXfuu7HinvGjJ9yMNF7744lKkq1AxnvMeI+6gbWRgEEEXEXOwoI18cKtEQBh hNfGjz84Azm8VX7uf2P9wADVXGbEAP1TS2LLazuarLNzYV5njEWXelJcDtv0nLltfy1N Bj9d9NlKGCHZqJ/ofWGEvKLPWRP6KueaShcxUBadxoLKbsIHgpucUBSArp9qBtGTRq2y 4Z0Q== X-Gm-Message-State: AOAM532awvNLohkT0ny5CiiRFWgDPq/rB0pIs0p/m80JpHs4pfN2dJDa qo8/53prLAaEKxHTitiIn2gZIg== X-Google-Smtp-Source: ABdhPJxwCRS0NbsCGwDCQlASb5b6WautzDD0g5D9emYoA1duDxi19XrqhWayM/D34fnCoHbdUtV/6g== X-Received: by 2002:a05:620a:191a:: with SMTP id bj26mr8647216qkb.266.1635511150235; Fri, 29 Oct 2021 05:39:10 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-cd13-3c38-2d32-68e0.res6.spectrum.com. [2603:6081:7b01:cbda:cd13:3c38:2d32:68e0]) by smtp.gmail.com with ESMTPSA id q13sm4222959qtx.80.2021.10.29.05.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 05:39:09 -0700 (PDT) Date: Fri, 29 Oct 2021 08:39:07 -0400 From: Tom Rini To: Ilias Apalodimas Cc: Simon Glass , U-Boot Mailing List , Michal Simek , Heinrich Schuchardt , Daniel Schwierzeck , Steffen Jaeckel , Marek =?iso-8859-1?Q?Beh=FAn?= , Lukas Auer , Dennis Gilmore Subject: Re: [PATCH v2 31/41] bootstd: Add an implementation of EFI boot Message-ID: <20211029123907.GS8284@bill-the-cat> References: <20211023232635.9195-1-sjg@chromium.org> <20211023232635.9195-22-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XjxGazX6lEnETewT" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --XjxGazX6lEnETewT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 29, 2021 at 08:45:06AM +0300, Ilias Apalodimas wrote: > On Wed, Oct 27, 2021 at 12:34:40PM -0600, Simon Glass wrote: > > Hi Ilias, > >=20 > > On Wed, 27 Oct 2021 at 08:48, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > On Wed, Oct 27, 2021 at 08:09:04AM -0600, Simon Glass wrote: > > > > Hi Ilias, > > > > > > > > On Wed, 27 Oct 2021 at 02:36, Ilias Apalodimas > > > > wrote: > > > > > > > > > > Hi Simon, > > > > > > > > > > On Sun, 24 Oct 2021 at 02:27, Simon Glass wrot= e: > > > > > > > > > > > > Add a bootmeth driver which handles EFI boot, using EFI_LOADER. > > > > > > > > > > > > In effect, this provides the same functionality as the 'bootefi= ' command > > > > > > and shares the same code. But the interface into it is via a bo= otmeth, > > > > > > so it does not require any special scripts, etc. > > > > > > > > > > > > For now this requires the 'bootefi' command be enabled. Future = work may > > > > > > tidy this up so that it can be used without CONFIG_CMDLINE bein= g enabled. > > > > > > > > > > I'll leave this up to Heinrich, but personally I wouldn't include= this > > > > > patch at all. EFI has it's bootmgr which can handle booting just = fine. > > > > > I don't see why we should duplicate the functionality. The new b= oot > > > > > method can just have an entry called 'EFI' and then let the exist= ing > > > > > EFI code to decide. > > > > > > > > This is needed so that EFI boot is actually invoked. If bootmgr sta= rts > > > > being used then it can still be invoked from standard boot. The poi= nt > > > > is that there is a standard way of booting that supports EFI and ot= her > > > > things. > > > > > > This patch tries to reason about the default naming EFI imposes on it= 's > > > boot files. distro_efi_read_bootflow() will try to find files followi= ng the > > > EFI naming convention (e.g bootaarch64.efi, bootarm.efi etc). If tho= se are > > > found it will try to boot them right? That's not the right thing to = do though. > > > On the EFI spec these files are tried if no Boot#### variables are fo= und. > > > So we can get rid of this entirely, add a dummy entry on the bootflo= w that > > > says 'boot the efi manager' (which is what the next patch does). > > > > > > The efibootmgr then will check Boot#### variables and if none are fou= nd, > > > it's going to fallback into loading bootaarch64.efi, bootarm.efi etc > > > essentially offering identical functionality. > >=20 > > Yes that's fine, and when EFI's boot manager is in use I have a driver > > for that too, as you can see in the other patch. We may need to adjust > > the order, by the sound of it, if it needs to run before EFI things. > > But that is easy enough. >=20 > That's the point though. I don't want to have 2 different ways of bootin= g EFI > as I don't see any benefit. Do you? Unless we're saying that "bootefi bootmgr" is ready to be used always and without further pre-req support (which I don't think is quite the case, since we don't have persistent EFI vars, so can't set Boot### persistently or via userspace) _something_ is likely needed to either set those, or scan a configurable list of where, to find the EFI payload. --=20 Tom --XjxGazX6lEnETewT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF762gACgkQFHw5/5Y0 tyyvtgwAlfS8UK6cEFrRDb+wo0mIjQSIK91KwjnfSGTs6bLS66UJN3xHEym2DrX1 SSOrsXqw7/bSVYU2+07tkp0BkQGKsB/Pdv01PkXxmYrkc2WbUHi/GxmLtooLK805 7XoJCUUwF5Ip7HGHhXnltEe07iW2ROgKyproH40oB6GkkKqVT20rgnqpTZR4kXYa 8Hl1QhHyswyU7iLLxvP+2wkT2RTjLxYYNt1bbiX+iYUgbwHJFAyG+xMN8ZbQuq0A fcDwuWeHLy83zCwKvUK5R0cdf2WRnRPxZELib66/Pj9g3cIXEebwLj4rLng4t49R GrMgfPPKgYgaAvZQDoWglL/G+bkNHCi5bPufXgWpLPZlCgtLaCUDNjqHhbOf8F0V PoJ9ufCl0V5Ao0NnUzp/gUo77ScN8QwwNiFLbNrZKjWeRgHeJCTVr8FAf9ynnGqn 9tajeigwwFAam0+Fy8yEQJKRovCb3hEkjUDayKc4JKtB4H5T2dEcJQ1ouNpodiGj ndelJ5uQ =64Gc -----END PGP SIGNATURE----- --XjxGazX6lEnETewT--