From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50372C433EF for ; Fri, 29 Oct 2021 20:04:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 397826101E for ; Fri, 29 Oct 2021 20:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231144AbhJ2UGu (ORCPT ); Fri, 29 Oct 2021 16:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231561AbhJ2UGS (ORCPT ); Fri, 29 Oct 2021 16:06:18 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3C6FC0613B9; Fri, 29 Oct 2021 13:03:47 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id v1-20020a17090a088100b001a21156830bso11427540pjc.1; Fri, 29 Oct 2021 13:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dR5goGjRH+faRSi6+pkacTGlwe5Jw734C5Ek8o+kxiM=; b=EO5UYp4d9BPAHCW1iVC6CevixytvZOW1wSqpJwVRSt21Xo3bykzvIiwMLlmnORyFEB 3iE6CBm7HdlZmceoiKQ6PhLdfV8n99raNFrZuvhpnlMlHbngfcHHPTqjcvVKjqdXnkr0 hOSSMjttoN0fULRdSKM3wC54QGW0x16arz1I12bIZnFIYrtOPfl11dD3MKPj5u1k3Qs7 yiaElWlN2u85si9nIDIl7MMdE1bpI8A/RlT7kAkK2qS/RYAAy2dO8y8rhB+Q53kDwQ2J mDbml3aLhSdbF2/NIusE9vsh7pKje8XDQEZDXsmOBdj0S2dX397i8F2XtSLkg/+HNAgd jN3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dR5goGjRH+faRSi6+pkacTGlwe5Jw734C5Ek8o+kxiM=; b=bQk6hWsr6ZaueCQ+9ofrYrO5cRd86CX2CSV6UaDSlgBe6HCKVMFWX2IdV/gYriCtQY tep2EV0tgD2CvefltnuNE0B6GPUIR6zmaQi/EO9pvSvRigYCWa0AzsDHtGi4N2VHIAlY GhvXCDLsq8pCeQZYwFt9PQumYfNaVPe5WIxH1jiMCjCuQQGGQLs9PQPuS3U/w/EXsFxO zcZpInnKipftEcNY+Mw/mHQsuxY2vWYZWx2Wz9czpzvHzkH9A7xHcznB0UbEiTezMb8N YsRBLdLCMUaiZe1M44AQo5jJHa+lx1gwyt1Wj/5rJjWy61Q0vpQ/+mIvEB+5itl46OUf WaEg== X-Gm-Message-State: AOAM532wH8vtSz2ab3wIbnGat3RIhZuI0zwx+O+SQStG6kOhCpxTSQnA KofGMPfSlc2xlA9M03ZKn6Rd8NdGyvsdIw== X-Google-Smtp-Source: ABdhPJxfHPZGaIHFIxsk4OqGM5oJw5NQuLdc00Tn5tag40VnL4M5tQXeStlEaSC90MV8JJb1Te1gcA== X-Received: by 2002:a17:90a:4e42:: with SMTP id t2mr13798887pjl.108.1635537823599; Fri, 29 Oct 2021 13:03:43 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.11.250]) by smtp.gmail.com with ESMTPSA id j16sm8775041pfj.16.2021.10.29.13.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 13:03:43 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 9/9] PCI: brcmstb: change brcm_phy_stop() to return void Date: Fri, 29 Oct 2021 16:03:17 -0400 Message-Id: <20211029200319.23475-10-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211029200319.23475-1-jim2101024@gmail.com> References: <20211029200319.23475-1-jim2101024@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We do not use the result of this function so make it void. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 18b9f7c97864..c1f8fdb89cec 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1196,9 +1196,10 @@ static inline int brcm_phy_start(struct brcm_pcie *pcie) return pcie->rescal ? brcm_phy_cntl(pcie, 1) : 0; } -static inline int brcm_phy_stop(struct brcm_pcie *pcie) +static inline void brcm_phy_stop(struct brcm_pcie *pcie) { - return pcie->rescal ? brcm_phy_cntl(pcie, 0) : 0; + if (pcie->rescal) + brcm_phy_cntl(pcie, 0); } static void brcm_pcie_turn_off(struct brcm_pcie *pcie) @@ -1281,10 +1282,9 @@ static int brcm_pcie_get_regulators(struct brcm_pcie *pcie, struct pci_dev *dev) static int brcm_pcie_suspend(struct device *dev) { struct brcm_pcie *pcie = dev_get_drvdata(dev); - int ret; brcm_pcie_turn_off(pcie); - ret = brcm_phy_stop(pcie); + brcm_phy_stop(pcie); reset_control_rearm(pcie->rescal); clk_disable_unprepare(pcie->clk); -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7BF3C433F5 for ; Fri, 29 Oct 2021 20:26:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9079561038 for ; Fri, 29 Oct 2021 20:26:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9079561038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tgzqtu3Bn2eQ0+3s0uq1u9CrcdhiGKmkWoasdIRpjqY=; b=qzelutI4kcisPX Riw1M59kK/jidBToL2bf4N2QeIN0t7WBHeU5fgc6Bx46aGvSi1vRv+xcE8xvSE1Q/yfJ9yJSmtpCz J0Pz4TnDWufLzaA5xz5As/lELzYW0H/u4R8Vy/ComEa60e1HDP442tbfqrpM9qJT9m145gRhRcAaf tVO5M+L3jsCXPSejwUktMmvKCoDTAVrobkztr/WVAoDjn4e9iXbmymtrZQV0GtlNjsZiIZ9GYV7qh W/CfXgXgyE5ytW98hAK72PGAcL9Q2k0L5/CztX93cAtCTNitm4fhUM+LQ3+hI9LvL9T7h0o9+G32l ydjK4rn068WRF6kETzlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgYQ4-00CEuY-Tg; Fri, 29 Oct 2021 20:24:10 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgY6Q-00C9et-LU; Fri, 29 Oct 2021 20:03:52 +0000 Received: by mail-pj1-x1032.google.com with SMTP id x33-20020a17090a6c2400b001a63ef25836so1840987pjj.3; Fri, 29 Oct 2021 13:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dR5goGjRH+faRSi6+pkacTGlwe5Jw734C5Ek8o+kxiM=; b=EO5UYp4d9BPAHCW1iVC6CevixytvZOW1wSqpJwVRSt21Xo3bykzvIiwMLlmnORyFEB 3iE6CBm7HdlZmceoiKQ6PhLdfV8n99raNFrZuvhpnlMlHbngfcHHPTqjcvVKjqdXnkr0 hOSSMjttoN0fULRdSKM3wC54QGW0x16arz1I12bIZnFIYrtOPfl11dD3MKPj5u1k3Qs7 yiaElWlN2u85si9nIDIl7MMdE1bpI8A/RlT7kAkK2qS/RYAAy2dO8y8rhB+Q53kDwQ2J mDbml3aLhSdbF2/NIusE9vsh7pKje8XDQEZDXsmOBdj0S2dX397i8F2XtSLkg/+HNAgd jN3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dR5goGjRH+faRSi6+pkacTGlwe5Jw734C5Ek8o+kxiM=; b=QO73Mw4BvYO6ow0iIjHmXmW5nmNcoxpHedPoIb+PP0RJyPg4HNwGlNu6bgirbrLJTk dpmsA3QTD+U2o2ZJqaE7JYDRaV4WXqL/6S0vyfMmiHlikc4HFvr52RNJAify6fc7AcGi ZFikN4w75q43ojgkgKPfQG4T4Hqj1+CWNdBQdPBfSmWgAaWOsyszSlCJTjyNNeLewiRp OYRSHOoXeWtRRQVn/9JYMoEJEDVvVfcObsJz/+pOltnNLc42EOw5dJBOCEuN+GLfZeHB Ggcw+bBxGE9Me0YCFqGO39EunK4h7y8rRwGYlZQsImLXSflaWI0SxpOwPeQfoY0d/z+s MFqQ== X-Gm-Message-State: AOAM530eE41ib2ZQ3dtyTjTCJpI3BAKG7Kb4rq5dsIn1aHXp+08Rb6dZ lEOUA6B0rf4roqZScZ/y9rA= X-Google-Smtp-Source: ABdhPJxfHPZGaIHFIxsk4OqGM5oJw5NQuLdc00Tn5tag40VnL4M5tQXeStlEaSC90MV8JJb1Te1gcA== X-Received: by 2002:a17:90a:4e42:: with SMTP id t2mr13798887pjl.108.1635537823599; Fri, 29 Oct 2021 13:03:43 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.11.250]) by smtp.gmail.com with ESMTPSA id j16sm8775041pfj.16.2021.10.29.13.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 13:03:43 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 9/9] PCI: brcmstb: change brcm_phy_stop() to return void Date: Fri, 29 Oct 2021 16:03:17 -0400 Message-Id: <20211029200319.23475-10-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211029200319.23475-1-jim2101024@gmail.com> References: <20211029200319.23475-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211029_130350_737280_BA304308 X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We do not use the result of this function so make it void. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 18b9f7c97864..c1f8fdb89cec 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1196,9 +1196,10 @@ static inline int brcm_phy_start(struct brcm_pcie *pcie) return pcie->rescal ? brcm_phy_cntl(pcie, 1) : 0; } -static inline int brcm_phy_stop(struct brcm_pcie *pcie) +static inline void brcm_phy_stop(struct brcm_pcie *pcie) { - return pcie->rescal ? brcm_phy_cntl(pcie, 0) : 0; + if (pcie->rescal) + brcm_phy_cntl(pcie, 0); } static void brcm_pcie_turn_off(struct brcm_pcie *pcie) @@ -1281,10 +1282,9 @@ static int brcm_pcie_get_regulators(struct brcm_pcie *pcie, struct pci_dev *dev) static int brcm_pcie_suspend(struct device *dev) { struct brcm_pcie *pcie = dev_get_drvdata(dev); - int ret; brcm_pcie_turn_off(pcie); - ret = brcm_phy_stop(pcie); + brcm_phy_stop(pcie); reset_control_rearm(pcie->rescal); clk_disable_unprepare(pcie->clk); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel