Re: [RFC PATCH] Bluetooth: vhci: Add new packet type for VHCI

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4126 bytes --]

Hi Tedd,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on next-20211029]
[cannot apply to bluetooth/master v5.15-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tedd-Ho-Jeong-An/Bluetooth-vhci-Add-new-packet-type-for-VHCI/20211029-141735
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: powerpc-randconfig-r002-20211028 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/66ce881eb09833714ee56dc1f26ed8c251629957
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tedd-Ho-Jeong-An/Bluetooth-vhci-Add-new-packet-type-for-VHCI/20211029-141735
        git checkout 66ce881eb09833714ee56dc1f26ed8c251629957
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/bluetooth/hci_vhci.c: In function 'vhci_get_user':
>> drivers/bluetooth/hci_vhci.c:534:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     534 |                 struct vhci_ext_create_device_req *req;
         |                 ^~~~~~


vim +534 drivers/bluetooth/hci_vhci.c

   476	
   477	static inline ssize_t vhci_get_user(struct vhci_data *data,
   478					    struct iov_iter *from)
   479	{
   480		size_t len = iov_iter_count(from);
   481		struct sk_buff *skb;
   482		__u8 pkt_type, opcode;
   483		int ret;
   484	
   485		if (len < 2 || len > HCI_MAX_FRAME_SIZE)
   486			return -EINVAL;
   487	
   488		skb = bt_skb_alloc(len, GFP_KERNEL);
   489		if (!skb)
   490			return -ENOMEM;
   491	
   492		if (!copy_from_iter_full(skb_put(skb, len), len, from)) {
   493			kfree_skb(skb);
   494			return -EFAULT;
   495		}
   496	
   497		pkt_type = *((__u8 *) skb->data);
   498		skb_pull(skb, 1);
   499	
   500		switch (pkt_type) {
   501		case HCI_EVENT_PKT:
   502		case HCI_ACLDATA_PKT:
   503		case HCI_SCODATA_PKT:
   504		case HCI_ISODATA_PKT:
   505			if (!data->hdev) {
   506				kfree_skb(skb);
   507				return -ENODEV;
   508			}
   509	
   510			hci_skb_pkt_type(skb) = pkt_type;
   511	
   512			ret = hci_recv_frame(data->hdev, skb);
   513			break;
   514	
   515		case HCI_VENDOR_PKT:
   516			cancel_delayed_work_sync(&data->open_timeout);
   517	
   518			opcode = *((__u8 *) skb->data);
   519			skb_pull(skb, 1);
   520	
   521			if (skb->len > 0) {
   522				kfree_skb(skb);
   523				return -EINVAL;
   524			}
   525	
   526			kfree_skb(skb);
   527	
   528			ret = vhci_create_device(data, opcode);
   529			break;
   530	
   531		/* This packet type is for VHCI specific command */
   532		case HCI_VHCI_PKT:
   533			cancel_delayed_work_sync(&data->open_timeout);
 > 534			struct vhci_ext_create_device_req *req;
   535	
   536			if (skb->len != sizeof(*req)) {
   537				kfree_skb(skb);
   538				return -EINVAL;
   539			}
   540	
   541			req = (void *)skb->data;
   542			skb_pull(skb, sizeof(*req));
   543	
   544			ret = vhci_ext_create_device(data, req->dev_type, req->flags);
   545	
   546			kfree_skb(skb);
   547			break;
   548	
   549		default:
   550			kfree_skb(skb);
   551			return -EINVAL;
   552		}
   553	
   554		return (ret < 0) ? ret : len;
   555	}
   556	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39997 bytes --]