From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D308C433EF for ; Mon, 1 Nov 2021 09:01:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D27D60EFF for ; Mon, 1 Nov 2021 09:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231386AbhKAJEY (ORCPT ); Mon, 1 Nov 2021 05:04:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:53658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230520AbhKAJEW (ORCPT ); Mon, 1 Nov 2021 05:04:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A36D960F36; Mon, 1 Nov 2021 09:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635757309; bh=l7HaZsOf0inuUkFmNCqzqHcB4dS2C93Ciex8mXy6UPA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cgH/76ARewnijYGJDipqNTzX9kG+pGG3OP9wOnXKswhFX1ofUD6x4pdu8jADvqOK6 2vCrn/H5Io79U7DvaYn1vHiXe81PExUysDmZm1TjydiHZjlcU+37NkDorvXqF1pINQ XRVDg+su98u6TUpHBP7EJ0lmfA/35FJ7LzK5KicrhYORVRxRk1JTLbtXmb/vH2eRLb idX/jFc+oa0/ve8HJOFhF9ol1D2xjew/88Q1jwhWYFeBseZiMFSi+3BOi+xBjbRSpa z78PK5mO241DrO4kqd0fZT9wTYu1ZgeL5chCozc6w7RYeCeuAnSU+womooLCtCPUUa 7yYecgXoapG4g== Date: Mon, 1 Nov 2021 09:01:44 +0000 From: Will Deacon To: Catalin Marinas Cc: Suzuki K Poulose , Arnd Bergmann , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Message-ID: <20211101090143.GA27181@willie-the-truck> References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > Reviewed-by: Suzuki K Poulose > > Tested-by: Suzuki K Poulose > > > > Will, Catalin, Mathieu, > > > > Do you have a preference on how this fix can be pulled in ? This may > > be safe to go via coresight tree if it is not too late. Otherwise, > > it could go via the arm64 tree. > > I think Will already closed/tagged the arm64 tree for the upcoming > merging window, though he could take it as a fix afterwards. > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > go through the coresight tree. > > > > Signed-off-by: Arnd Bergmann > > > --- > > > Not sure if we actually want this to be exported, this is my local > > > workaround for the randconfig build bot. > > > --- > > > arch/arm64/kernel/cpufeature.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > index ecbdff795f5e..beccbcfa7391 100644 > > > --- a/arch/arm64/kernel/cpufeature.c > > > +++ b/arch/arm64/kernel/cpufeature.c > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > return false; > > > } > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > specialised than cpus_have_const_cap(). > > With that: > > Acked-by: Catalin Marinas Yes, at this stage I think it's best for this to go via the Coresight tree. So with the _GPL export: Acked-by: Will Deacon If that doesn't work for some reason, I can take it next week after the initial arm64 queue has been merged. Please just let me know. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53A56C433F5 for ; Mon, 1 Nov 2021 09:03:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D13660EFF for ; Mon, 1 Nov 2021 09:03:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1D13660EFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wwuQV8IdVMf6DqjbM6g2kvySprxag9/0GUKhwI/eNpg=; b=xYRnXT+LXyjv2e WY9EpoPBpYPXCErDooeEE9/fHv4PCSIT5/E2+SQZSIh6QR9Ota97EJzQzZqPaW8Wg4t2XTATVxKb5 JGaBJpemkoCqjW7U+zfJjaFF7MCVKw5LKO0zge33hSEJAhN/BOBGKM5tWY+NTSlTUXniQwdJLI0EA X13W6alAr0J92lHwl4Cz/I1EwSfe6Ow/k96uROLM+KaS5UPNYT0E2VHYaXIi3Ygk9IVXHnN/m/6KX l+LVHtM4QxbsVd++2ar/FFM3YcfElcN3ToTebjCI8jTappNsA2/Zq4x+jK9+PdCaNTGDrX3AhnMxJ dm+qsXu1ymA5Lp8OA0JA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhTCT-00FjKE-E0; Mon, 01 Nov 2021 09:01:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhTCQ-00FjJM-7O for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 09:01:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A36D960F36; Mon, 1 Nov 2021 09:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635757309; bh=l7HaZsOf0inuUkFmNCqzqHcB4dS2C93Ciex8mXy6UPA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cgH/76ARewnijYGJDipqNTzX9kG+pGG3OP9wOnXKswhFX1ofUD6x4pdu8jADvqOK6 2vCrn/H5Io79U7DvaYn1vHiXe81PExUysDmZm1TjydiHZjlcU+37NkDorvXqF1pINQ XRVDg+su98u6TUpHBP7EJ0lmfA/35FJ7LzK5KicrhYORVRxRk1JTLbtXmb/vH2eRLb idX/jFc+oa0/ve8HJOFhF9ol1D2xjew/88Q1jwhWYFeBseZiMFSi+3BOi+xBjbRSpa z78PK5mO241DrO4kqd0fZT9wTYu1ZgeL5chCozc6w7RYeCeuAnSU+womooLCtCPUUa 7yYecgXoapG4g== Date: Mon, 1 Nov 2021 09:01:44 +0000 From: Will Deacon To: Catalin Marinas Cc: Suzuki K Poulose , Arnd Bergmann , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Message-ID: <20211101090143.GA27181@willie-the-truck> References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_020150_317705_2CCFA1DA X-CRM114-Status: GOOD ( 28.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > Reviewed-by: Suzuki K Poulose > > Tested-by: Suzuki K Poulose > > > > Will, Catalin, Mathieu, > > > > Do you have a preference on how this fix can be pulled in ? This may > > be safe to go via coresight tree if it is not too late. Otherwise, > > it could go via the arm64 tree. > > I think Will already closed/tagged the arm64 tree for the upcoming > merging window, though he could take it as a fix afterwards. > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > go through the coresight tree. > > > > Signed-off-by: Arnd Bergmann > > > --- > > > Not sure if we actually want this to be exported, this is my local > > > workaround for the randconfig build bot. > > > --- > > > arch/arm64/kernel/cpufeature.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > index ecbdff795f5e..beccbcfa7391 100644 > > > --- a/arch/arm64/kernel/cpufeature.c > > > +++ b/arch/arm64/kernel/cpufeature.c > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > return false; > > > } > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > specialised than cpus_have_const_cap(). > > With that: > > Acked-by: Catalin Marinas Yes, at this stage I think it's best for this to go via the Coresight tree. So with the _GPL export: Acked-by: Will Deacon If that doesn't work for some reason, I can take it next week after the initial arm64 queue has been merged. Please just let me know. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel