From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D81B5C433F5 for ; Mon, 1 Nov 2021 09:42:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0E6360C4B for ; Mon, 1 Nov 2021 09:42:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A0E6360C4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4ga+4dsGzPE06uO8Mj2RzvsiVDGtEoeEeRoVG5PBFKc=; b=SxbXbGjZ5/yZ9A RsbutzLIrDCZmcG3yjDtDiecAE7AFGbAKEKosPKUgpfIucFs/SmeBKdRulKWHYSB/4yaAHDKnEkh5 UOYnOp0ih5Ew5DnohDt0y/vUQTgGZlgJGP/42AGj9RBsra/xn4Hjhn8G2HQBif9vhKP11kGddmkXW HAyjXpRCV38/0Iw27Gr2B7w7G1XbxBMUEJBD4HWjJGNrFHbHyCoIxRob2ERavPoKYD02CIUCbZpeF DWDrh6GezpWl+GLsuQ1Yx4iC+yraW+wWiI7/aPAS/GP51l1MPXfEztZ11Cp2iV+jr7r/oj6CioVyO 4PHUrA3kpJ7pmfkUViOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhToE-00FqI0-GI; Mon, 01 Nov 2021 09:40:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhToB-00FqHW-1Z for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 09:40:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A5E3960C40; Mon, 1 Nov 2021 09:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635759650; bh=SF7WKY1O6uumm2ECM8NsFAYbMFy4Hkjnwkn8xH3bmHI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H7UjP2MPnLxj2CKPa7Hrecp+CeBG3PNKKTdGOwRrAkLW3jJ12MCZab1EqVHlhCmif Wo0vNnJFdEt0DntnAingPDUAsuSQmLbgGG+KLagxI/4toDi0O+g/pSzktMM6tXRSPg GnLzgNRovPqCY1EyRQNc72++/h+KsxEj7e5P+Hk8GyJeAiTBgWeKtauaZ3AjyHaUSq xvKVad1AVREdo18u/QkbU0dgHDdrVKjyVdOSr8dUNTbTrA2d+t51JoAlhBgKzPFFmo iEG0huyK02qdBX0k1WQWbM/n3jgf2VxahvbdxseBGMbNn3+VYRbVTikCWCLhdPQoXO ynu1SmKs3ROuA== Date: Mon, 1 Nov 2021 09:40:45 +0000 From: Will Deacon To: Suzuki K Poulose Cc: Catalin Marinas , Arnd Bergmann , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Message-ID: <20211101094045.GB27400@willie-the-truck> References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> <20211101090143.GA27181@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_024051_155371_992500BE X-CRM114-Status: GOOD ( 36.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 01, 2021 at 09:34:08AM +0000, Suzuki K Poulose wrote: > On 01/11/2021 09:01, Will Deacon wrote: > > On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > > > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > > > From: Arnd Bergmann > > > > > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > > > > > Reviewed-by: Suzuki K Poulose > > > > Tested-by: Suzuki K Poulose > > > > > > > > Will, Catalin, Mathieu, > > > > > > > > Do you have a preference on how this fix can be pulled in ? This may > > > > be safe to go via coresight tree if it is not too late. Otherwise, > > > > it could go via the arm64 tree. > > > > > > I think Will already closed/tagged the arm64 tree for the upcoming > > > merging window, though he could take it as a fix afterwards. > > > > > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > > > go through the coresight tree. > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > --- > > > > > Not sure if we actually want this to be exported, this is my local > > > > > workaround for the randconfig build bot. > > > > > --- > > > > > arch/arm64/kernel/cpufeature.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > > > index ecbdff795f5e..beccbcfa7391 100644 > > > > > --- a/arch/arm64/kernel/cpufeature.c > > > > > +++ b/arch/arm64/kernel/cpufeature.c > > > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > > return false; > > > > > } > > > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > > > specialised than cpus_have_const_cap(). > > > > > > With that: > > > > > > Acked-by: Catalin Marinas > > > > Yes, at this stage I think it's best for this to go via the Coresight tree. > > So with the _GPL export: > > > > Acked-by: Will Deacon > > > > If that doesn't work for some reason, I can take it next week after the > > initial arm64 queue has been merged. Please just let me know. > > As I understand correctly, this will now need to go via arm64 tree. The > CoreSight tree changes are pulled into Greg's tree and the next it will > happen is for the next release. Usually the fixes don't end up there > during the -rc cycles. So, I believe it is better if this goes via > arm64. Hmm, are you saying that Coresight drivers don't receive fixes outside of the merge window? That sounds sub-optimal... But in any case, I'm happy to take this as long as it can wait until the second half of the merge window. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47164C433FE for ; Mon, 1 Nov 2021 09:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28DF060184 for ; Mon, 1 Nov 2021 09:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234299AbhKAJyt (ORCPT ); Mon, 1 Nov 2021 05:54:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:54508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234569AbhKAJvG (ORCPT ); Mon, 1 Nov 2021 05:51:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A5E3960C40; Mon, 1 Nov 2021 09:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635759650; bh=SF7WKY1O6uumm2ECM8NsFAYbMFy4Hkjnwkn8xH3bmHI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H7UjP2MPnLxj2CKPa7Hrecp+CeBG3PNKKTdGOwRrAkLW3jJ12MCZab1EqVHlhCmif Wo0vNnJFdEt0DntnAingPDUAsuSQmLbgGG+KLagxI/4toDi0O+g/pSzktMM6tXRSPg GnLzgNRovPqCY1EyRQNc72++/h+KsxEj7e5P+Hk8GyJeAiTBgWeKtauaZ3AjyHaUSq xvKVad1AVREdo18u/QkbU0dgHDdrVKjyVdOSr8dUNTbTrA2d+t51JoAlhBgKzPFFmo iEG0huyK02qdBX0k1WQWbM/n3jgf2VxahvbdxseBGMbNn3+VYRbVTikCWCLhdPQoXO ynu1SmKs3ROuA== Date: Mon, 1 Nov 2021 09:40:45 +0000 From: Will Deacon To: Suzuki K Poulose Cc: Catalin Marinas , Arnd Bergmann , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Message-ID: <20211101094045.GB27400@willie-the-truck> References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> <20211101090143.GA27181@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 01, 2021 at 09:34:08AM +0000, Suzuki K Poulose wrote: > On 01/11/2021 09:01, Will Deacon wrote: > > On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > > > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > > > From: Arnd Bergmann > > > > > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > > > > > Reviewed-by: Suzuki K Poulose > > > > Tested-by: Suzuki K Poulose > > > > > > > > Will, Catalin, Mathieu, > > > > > > > > Do you have a preference on how this fix can be pulled in ? This may > > > > be safe to go via coresight tree if it is not too late. Otherwise, > > > > it could go via the arm64 tree. > > > > > > I think Will already closed/tagged the arm64 tree for the upcoming > > > merging window, though he could take it as a fix afterwards. > > > > > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > > > go through the coresight tree. > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > --- > > > > > Not sure if we actually want this to be exported, this is my local > > > > > workaround for the randconfig build bot. > > > > > --- > > > > > arch/arm64/kernel/cpufeature.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > > > index ecbdff795f5e..beccbcfa7391 100644 > > > > > --- a/arch/arm64/kernel/cpufeature.c > > > > > +++ b/arch/arm64/kernel/cpufeature.c > > > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > > return false; > > > > > } > > > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > > > specialised than cpus_have_const_cap(). > > > > > > With that: > > > > > > Acked-by: Catalin Marinas > > > > Yes, at this stage I think it's best for this to go via the Coresight tree. > > So with the _GPL export: > > > > Acked-by: Will Deacon > > > > If that doesn't work for some reason, I can take it next week after the > > initial arm64 queue has been merged. Please just let me know. > > As I understand correctly, this will now need to go via arm64 tree. The > CoreSight tree changes are pulled into Greg's tree and the next it will > happen is for the next release. Usually the fixes don't end up there > during the -rc cycles. So, I believe it is better if this goes via > arm64. Hmm, are you saying that Coresight drivers don't receive fixes outside of the merge window? That sounds sub-optimal... But in any case, I'm happy to take this as long as it can wait until the second half of the merge window. Will