From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C33CC433F5 for ; Mon, 1 Nov 2021 22:58:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06C4660F0F for ; Mon, 1 Nov 2021 22:58:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232320AbhKAXBH (ORCPT ); Mon, 1 Nov 2021 19:01:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229842AbhKAXBF (ORCPT ); Mon, 1 Nov 2021 19:01:05 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6B61C061714; Mon, 1 Nov 2021 15:58:31 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 5so68389078edw.7; Mon, 01 Nov 2021 15:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jZ9LOwzZ3P8QcHNJCOuEJw++blcCddHe1Pn0IJjCj6o=; b=LJPT46Bf/d6iZrm2CLPmbX29KWiXzDDlgAjjSY9ajlH6grzuqSR+qwzBV52z+zDze2 opoYDD22jFsH/HYRAgshAr5f186FCKLzE8EwMzRmIwaCKKUyr1pWDfL3xrXwqBpBCZUV tqRt2waMiCCddQI3D9w/tUCdjzrwGRqsrimWFwFbRXEsM4qweAtOGl0vNVg7HRnzs0d6 CDqRtMMsjUECxN7iHg2bgS3UI4rDhNZ8cZ+N3cvYHtMjWZf6EOfY0AW7AXK1QBX+Uj3v NA/989sk5X9rwOHv180+6jMkPwu77ZwGshiSe4rGcsQvVUOIE2Yb0mth0GPwmCctVgfJ WtfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jZ9LOwzZ3P8QcHNJCOuEJw++blcCddHe1Pn0IJjCj6o=; b=hZkF+VtjJKJX1+2d3VXu/WDPsf4crsLyrhLVCk85H8PtHskSVAdDXrP9r5VP9lFaiN ZLa7MmAhdryKuSrkPo57JveTFjVsfWUTSyZz6D057GrZeCoH4QMcPsAiqAwfad4bsR+9 kBgIM7mBHtsQ/pTg/Ni8X+VsatqQ2QcrFRkSnLuvX54rZtED5nkrut/Cn0gI8lMKiZ/O xF441vdMJ9nf9HpD+ej1WSTpn1QR/OlkhCcYmQiHkgPqnJ6xiwF1Lh9EdVW16CqGaF+H ZSRC2Thv+jbRBFnNMRbrcYsGZdOF46nJggrlVs/xt9/vZvMJx+ZNawlLB28Iu8UGBZXA qYtA== X-Gm-Message-State: AOAM531y8DC+PFxqwZu1stW2GEaSne0lEiydWvJLvWwbFzaRQqtJ0MEd f/1H2Vs2t3TuO7CCIl2mV7M= X-Google-Smtp-Source: ABdhPJwcRG0ef+5apgQqvFYVa9abYfLIGt4MhDq3CfIAjIQaUosJZTBseiEBU8hcYsX6qiD5XXHyvg== X-Received: by 2002:a05:6402:402:: with SMTP id q2mr45339719edv.248.1635807510530; Mon, 01 Nov 2021 15:58:30 -0700 (PDT) Received: from tom-desktop (net-188-153-110-208.cust.vodafonedsl.it. [188.153.110.208]) by smtp.gmail.com with ESMTPSA id t16sm18007edd.18.2021.11.01.15.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 15:58:30 -0700 (PDT) Date: Mon, 1 Nov 2021 23:58:27 +0100 From: Tommaso Merciai To: Ahmad Fatoum Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Peng Fan , Alice Guo , Shawn Guo , Sascha Hauer , Joakim Zhang , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Adam Ford , Lucas Stach Subject: Re: [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs Message-ID: <20211101225827.GA9208@tom-desktop> References: <20211101222857.6940-1-tomm.merciai@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 01, 2021 at 11:35:49PM +0100, Ahmad Fatoum wrote: > Hello Tommaso, > > On 01.11.21 23:28, Tommaso Merciai wrote: > > Add system controller node for registers of module Display Block Control > > (DISPLAY_BLK_CTRL, base address: 0x32e28000). > > The DISPLAY_BLK_CTRL module contains general purpose registers (GPRs), > > which control varied features of the associated peripherals. > > Reference: IMX8MMRM Rev. 3, 11/2020, p 3897 > > --- > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > index 2f632e8ca388..3e496b457e1a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > @@ -961,6 +961,11 @@ aips4: bus@32c00000 { > > #size-cells = <1>; > > ranges = <0x32c00000 0x32c00000 0x400000>; > > > > + dispmix_gpr: display-gpr@32e28000 { > > + compatible = "fsl, imx8mm-iomuxc-gpr", "syscon"; > > Please read vendor patches before submitting them. The space > is out-of-place in the compatible and the compatible is wrong: > This doesn't look like a i.MX8MM pin controller. > > Cheers, > Ahmad Hi Ahmad, Thanks for your review. Do you think this is correct? compatible = "fsl,imx8mm-dispmix-gpr", "syscon"; Let me know. Thanks, Tommaso > > > + reg = <0x32e28000 0x100>; > > + }; > > + > > usbotg1: usb@32e40000 { > > compatible = "fsl,imx8mm-usb", "fsl,imx7d-usb"; > > reg = <0x32e40000 0x200>; > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5436C433EF for ; Mon, 1 Nov 2021 22:59:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68507603E5 for ; Mon, 1 Nov 2021 22:59:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 68507603E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ww5XzWYzHeVrstwF7bY7dUdxbv2rExn99AMTWPCN1gU=; b=Tab43MPUV+BzVo vjpgDYy/a3omQleAX1mfmaC0ce+EXguKZ8u/RJ+yHZ+mvklYoV7Pi7/aUKDexHU+7NXsR3dvJeqvn R/vc10+vGTQrJVtESkHHBPmShtY9TL97lmLiaxGiJxYpA3Cvw6ScAWDU5pZL8M0vKwl6JhyZAgcnt kBGmTbhBhvFDTID/cLoUJpc6LFprD1pu53dtvb1vmQhS2S3XCT8aJWgqYxYKXMrls0EGfSivnlB8e H8QKMX74zB4HvVNNVbTz/UketzoBgAtWMJn8y8eHfjXTLQkGp4DgJMFIg0D2eMb/tMnnN4NUw65c4 LsrSRJ+Qybfc1oicPfEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhgGC-00HUb1-0V; Mon, 01 Nov 2021 22:58:36 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhgG7-00HUaF-Rz for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 22:58:33 +0000 Received: by mail-ed1-x52b.google.com with SMTP id h7so70004993ede.8 for ; Mon, 01 Nov 2021 15:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jZ9LOwzZ3P8QcHNJCOuEJw++blcCddHe1Pn0IJjCj6o=; b=LJPT46Bf/d6iZrm2CLPmbX29KWiXzDDlgAjjSY9ajlH6grzuqSR+qwzBV52z+zDze2 opoYDD22jFsH/HYRAgshAr5f186FCKLzE8EwMzRmIwaCKKUyr1pWDfL3xrXwqBpBCZUV tqRt2waMiCCddQI3D9w/tUCdjzrwGRqsrimWFwFbRXEsM4qweAtOGl0vNVg7HRnzs0d6 CDqRtMMsjUECxN7iHg2bgS3UI4rDhNZ8cZ+N3cvYHtMjWZf6EOfY0AW7AXK1QBX+Uj3v NA/989sk5X9rwOHv180+6jMkPwu77ZwGshiSe4rGcsQvVUOIE2Yb0mth0GPwmCctVgfJ WtfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jZ9LOwzZ3P8QcHNJCOuEJw++blcCddHe1Pn0IJjCj6o=; b=neDmCXV56FiCHXscGHJSjDVyzld2j4WKaK2Nan2DewjGY+xZtf+Ud+QSHkadva1MUf R9wIfsBNZLoaOtBZNkPHF4+lhEALc1I2tUhI7hnfq5OPna8hqn/haPolw8Y7ZfPa2iNb yVmywVu6XTjLoEPr620kfEnhpconSQCTH/uWLVzsUn+S1JLiQlApv+Sc9FYsLHlm3tyS 3BGVwh+IP417DUJbotsCjB/2S1xy072Cli2Wt0XXlqp2KHIOAnRLk4y+TcCj7R+XjJxR 1KV68BVc+O0d7ytfMdEGYZ8+KNyqEvoA29VBF6bZ6tV3cykLHbFJRf/u9jTLXXjt2Wk2 CNoA== X-Gm-Message-State: AOAM531mG1wFjt2tKij68fE8Y99+SJngfbgFHvPPyRxNotGy/VBgdJNT QsuM7LfUJfypo4PjZTsmJDY= X-Google-Smtp-Source: ABdhPJwcRG0ef+5apgQqvFYVa9abYfLIGt4MhDq3CfIAjIQaUosJZTBseiEBU8hcYsX6qiD5XXHyvg== X-Received: by 2002:a05:6402:402:: with SMTP id q2mr45339719edv.248.1635807510530; Mon, 01 Nov 2021 15:58:30 -0700 (PDT) Received: from tom-desktop (net-188-153-110-208.cust.vodafonedsl.it. [188.153.110.208]) by smtp.gmail.com with ESMTPSA id t16sm18007edd.18.2021.11.01.15.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 15:58:30 -0700 (PDT) Date: Mon, 1 Nov 2021 23:58:27 +0100 From: Tommaso Merciai To: Ahmad Fatoum Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Peng Fan , Alice Guo , Shawn Guo , Sascha Hauer , Joakim Zhang , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Adam Ford , Lucas Stach Subject: Re: [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs Message-ID: <20211101225827.GA9208@tom-desktop> References: <20211101222857.6940-1-tomm.merciai@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_155831_935872_FBF3C3B4 X-CRM114-Status: GOOD ( 24.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 01, 2021 at 11:35:49PM +0100, Ahmad Fatoum wrote: > Hello Tommaso, > > On 01.11.21 23:28, Tommaso Merciai wrote: > > Add system controller node for registers of module Display Block Control > > (DISPLAY_BLK_CTRL, base address: 0x32e28000). > > The DISPLAY_BLK_CTRL module contains general purpose registers (GPRs), > > which control varied features of the associated peripherals. > > Reference: IMX8MMRM Rev. 3, 11/2020, p 3897 > > --- > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > index 2f632e8ca388..3e496b457e1a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > @@ -961,6 +961,11 @@ aips4: bus@32c00000 { > > #size-cells = <1>; > > ranges = <0x32c00000 0x32c00000 0x400000>; > > > > + dispmix_gpr: display-gpr@32e28000 { > > + compatible = "fsl, imx8mm-iomuxc-gpr", "syscon"; > > Please read vendor patches before submitting them. The space > is out-of-place in the compatible and the compatible is wrong: > This doesn't look like a i.MX8MM pin controller. > > Cheers, > Ahmad Hi Ahmad, Thanks for your review. Do you think this is correct? compatible = "fsl,imx8mm-dispmix-gpr", "syscon"; Let me know. Thanks, Tommaso > > > + reg = <0x32e28000 0x100>; > > + }; > > + > > usbotg1: usb@32e40000 { > > compatible = "fsl,imx8mm-usb", "fsl,imx7d-usb"; > > reg = <0x32e40000 0x200>; > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel