From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A57022C85 for ; Tue, 2 Nov 2021 15:09:47 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A20B15C0125; Tue, 2 Nov 2021 11:09:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Nov 2021 11:09:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=ls42lHAs9gBZOIsdVGXqxUQvy1f 6gbOB9gv3uDCyIBg=; b=DqBTK8LDvrSWaKHLtbnlXkzD22eb9kEK4TX0t6VaWXE l17d1eUdXIpm0v2scb/R3Ij8kLRiBMd73STIQHbKsJo47fowhx+cj9WPHuKBeKDd liIql3R9fkzeSxfgMzdQC2Z1hKZIhAfQ2s+ZIJkwgvnYl+I+bkoE57RujbzMYtQ8 teL8JwqlNm5eKkXtAu81UaHUTSLoCczpNRPAKEZlGGoI1Ykj8MuAQVtKOb8lR/zO k9S9xdj0jqHLHuJXA3mUe6lMTk59pByrsAPNqzWJ6qqjvCRfohj1n6ucrt5J7jt4 mJlDU0EipQIASRwr+j482Z6qjn6yO4KGZ6NXkPgEdvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ls42lH As9gBZOIsdVGXqxUQvy1f6gbOB9gv3uDCyIBg=; b=JWtHx13aD8KrmXsrmAa3/Q jN+20FvmhkWkxVd4AEez/QgHtAMZJ1O5vrv7Of5UxQkjNw7N3jzVvhxgw2/XhxH6 MKvYFTb6ijKLypbX8HRDdvWN+4KeTZc+sha51QxSPg1UTW1r8iS8Da908QAwbQNV gHGl7Mf3n7v5YJCtIHfp1qkVzc5ao2LQNJtQgjElwT4vtQL5dDcey3r7C+jxfLJ4 tTLjnzGjR9WM9WdoZnfrw8+SlZbsbawx/HpuGTSguznvTOx1w0bZrHwjSFVrqnn5 fYYzI0epC/85HcDZM/1uQk15M77kpP6lMuJRv6N444pVM/++TiBb4+t30TNzHY6A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtddtgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 Nov 2021 11:09:46 -0400 (EDT) Date: Tue, 2 Nov 2021 16:09:44 +0100 From: Maxime Ripard To: Julian Braha Cc: airlied@linux.ie, daniel@ffwll.ch, jernej.skrabec@gmail.com, wens@csie.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, fazilyildiran@gmail.com Subject: Re: [PATCH] drm/sun4i: fix unmet dependency on RESET_CONTROLLER for PHY_SUN6I_MIPI_DPHY Message-ID: <20211102150944.h7ycdzlm4s5kvk4j@gilmour> References: <20211028221327.17984-1-julianbraha@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sdgbi7nuhb2tf3wq" Content-Disposition: inline In-Reply-To: <20211028221327.17984-1-julianbraha@gmail.com> --sdgbi7nuhb2tf3wq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Oct 28, 2021 at 06:13:27PM -0400, Julian Braha wrote: > When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER > is not selected, Kbuild gives the following warning: >=20 > WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY > Depends on [n]: (ARCH_SUNXI [=3Dn] || COMPILE_TEST [=3Dy]) && HAS_IOMEM= [=3Dy] && COMMON_CLK [=3Dy] && RESET_CONTROLLER [=3Dn] > Selected by [y]: > - DRM_SUN6I_DSI [=3Dy] && HAS_IOMEM [=3Dy] && DRM_SUN4I [=3Dy] >=20 > This is because DRM_SUN6I_DSI selects PHY_SUN6I_MIPI_DPHY > without selecting or depending on RESET_CONTROLLER, despite > PHY_SUN6I_MIPI_DPHY depending on RESET_CONTROLLER. >=20 > These unmet dependency bugs were detected by Kismet, > a static analysis tool for Kconfig. Please advise if this > is not the appropriate solution. >=20 > Signed-off-by: Julian Braha > --- > drivers/gpu/drm/sun4i/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig > index 5755f0432e77..3f70a14a3c94 100644 > --- a/drivers/gpu/drm/sun4i/Kconfig > +++ b/drivers/gpu/drm/sun4i/Kconfig > @@ -46,6 +46,7 @@ config DRM_SUN6I_DSI > default MACH_SUN8I > select CRC_CCITT > select DRM_MIPI_DSI > + select RESET_CONTROLLER The indentation is off, can you fix it and resend it? Maxime --sdgbi7nuhb2tf3wq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYYFUuAAKCRDj7w1vZxhR xdQVAQCEOb8We3hYtT3mqkzFKDO4114iJbKGuP+0OpjI3IatWwD/dQ/ShFBmVkCN VR9uV82ZNKb6qsodk3xIjJPhbE8+Pw4= =2Lra -----END PGP SIGNATURE----- --sdgbi7nuhb2tf3wq-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E48C433EF for ; Tue, 2 Nov 2021 15:09:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6091160EE9 for ; Tue, 2 Nov 2021 15:09:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6091160EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2BF572BE0; Tue, 2 Nov 2021 15:09:47 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47DEC72BE0 for ; Tue, 2 Nov 2021 15:09:47 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A20B15C0125; Tue, 2 Nov 2021 11:09:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Nov 2021 11:09:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=ls42lHAs9gBZOIsdVGXqxUQvy1f 6gbOB9gv3uDCyIBg=; b=DqBTK8LDvrSWaKHLtbnlXkzD22eb9kEK4TX0t6VaWXE l17d1eUdXIpm0v2scb/R3Ij8kLRiBMd73STIQHbKsJo47fowhx+cj9WPHuKBeKDd liIql3R9fkzeSxfgMzdQC2Z1hKZIhAfQ2s+ZIJkwgvnYl+I+bkoE57RujbzMYtQ8 teL8JwqlNm5eKkXtAu81UaHUTSLoCczpNRPAKEZlGGoI1Ykj8MuAQVtKOb8lR/zO k9S9xdj0jqHLHuJXA3mUe6lMTk59pByrsAPNqzWJ6qqjvCRfohj1n6ucrt5J7jt4 mJlDU0EipQIASRwr+j482Z6qjn6yO4KGZ6NXkPgEdvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ls42lH As9gBZOIsdVGXqxUQvy1f6gbOB9gv3uDCyIBg=; b=JWtHx13aD8KrmXsrmAa3/Q jN+20FvmhkWkxVd4AEez/QgHtAMZJ1O5vrv7Of5UxQkjNw7N3jzVvhxgw2/XhxH6 MKvYFTb6ijKLypbX8HRDdvWN+4KeTZc+sha51QxSPg1UTW1r8iS8Da908QAwbQNV gHGl7Mf3n7v5YJCtIHfp1qkVzc5ao2LQNJtQgjElwT4vtQL5dDcey3r7C+jxfLJ4 tTLjnzGjR9WM9WdoZnfrw8+SlZbsbawx/HpuGTSguznvTOx1w0bZrHwjSFVrqnn5 fYYzI0epC/85HcDZM/1uQk15M77kpP6lMuJRv6N444pVM/++TiBb4+t30TNzHY6A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtddtgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 Nov 2021 11:09:46 -0400 (EDT) Date: Tue, 2 Nov 2021 16:09:44 +0100 From: Maxime Ripard To: Julian Braha Subject: Re: [PATCH] drm/sun4i: fix unmet dependency on RESET_CONTROLLER for PHY_SUN6I_MIPI_DPHY Message-ID: <20211102150944.h7ycdzlm4s5kvk4j@gilmour> References: <20211028221327.17984-1-julianbraha@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sdgbi7nuhb2tf3wq" Content-Disposition: inline In-Reply-To: <20211028221327.17984-1-julianbraha@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, fazilyildiran@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, wens@csie.org, jernej.skrabec@gmail.com, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --sdgbi7nuhb2tf3wq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Oct 28, 2021 at 06:13:27PM -0400, Julian Braha wrote: > When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER > is not selected, Kbuild gives the following warning: >=20 > WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY > Depends on [n]: (ARCH_SUNXI [=3Dn] || COMPILE_TEST [=3Dy]) && HAS_IOMEM= [=3Dy] && COMMON_CLK [=3Dy] && RESET_CONTROLLER [=3Dn] > Selected by [y]: > - DRM_SUN6I_DSI [=3Dy] && HAS_IOMEM [=3Dy] && DRM_SUN4I [=3Dy] >=20 > This is because DRM_SUN6I_DSI selects PHY_SUN6I_MIPI_DPHY > without selecting or depending on RESET_CONTROLLER, despite > PHY_SUN6I_MIPI_DPHY depending on RESET_CONTROLLER. >=20 > These unmet dependency bugs were detected by Kismet, > a static analysis tool for Kconfig. Please advise if this > is not the appropriate solution. >=20 > Signed-off-by: Julian Braha > --- > drivers/gpu/drm/sun4i/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig > index 5755f0432e77..3f70a14a3c94 100644 > --- a/drivers/gpu/drm/sun4i/Kconfig > +++ b/drivers/gpu/drm/sun4i/Kconfig > @@ -46,6 +46,7 @@ config DRM_SUN6I_DSI > default MACH_SUN8I > select CRC_CCITT > select DRM_MIPI_DSI > + select RESET_CONTROLLER The indentation is off, can you fix it and resend it? Maxime --sdgbi7nuhb2tf3wq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYYFUuAAKCRDj7w1vZxhR xdQVAQCEOb8We3hYtT3mqkzFKDO4114iJbKGuP+0OpjI3IatWwD/dQ/ShFBmVkCN VR9uV82ZNKb6qsodk3xIjJPhbE8+Pw4= =2Lra -----END PGP SIGNATURE----- --sdgbi7nuhb2tf3wq-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 753F2C433F5 for ; Tue, 2 Nov 2021 15:11:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D43360EE9 for ; Tue, 2 Nov 2021 15:11:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D43360EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0pvkiwWHiOMqT4f7wiEsL0xndJr3BfJzfTNIU7JJfhU=; b=N8we9Nvao4VzwRztkd96DI1z8u jX0Zn/5w80R5Xtpv7XldrHyOLI8gnCyQIUoPTKInWUIICdCPTEeIYscImFkvK3rGtOYEcqoNofuCu 1XDMUT60OIune8pj+2JKdeBqizQrUTm07JUkaVRftxwNLnnZ7NJ5432ftxvk+4+fD7mIuRx5Okj8a SczDPNXrnZHnmnBdP4xLes/m6j+3iaHUM0xd9vy4rv/eaJXzhfUGMIe9jWpe/W6r6ThMTANRAJpmj 8l9zfuJYSU7pRiC2c2J1y9PM6AI4IBnCTNSRBxMH8sl9HL11mw9gIIkGVZ/8rZRoOMp9HbMwavpiE mSuGghQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhvQ6-0024fe-JX; Tue, 02 Nov 2021 15:09:50 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhvQ3-0024ep-C4 for linux-arm-kernel@lists.infradead.org; Tue, 02 Nov 2021 15:09:48 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A20B15C0125; Tue, 2 Nov 2021 11:09:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Nov 2021 11:09:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=ls42lHAs9gBZOIsdVGXqxUQvy1f 6gbOB9gv3uDCyIBg=; b=DqBTK8LDvrSWaKHLtbnlXkzD22eb9kEK4TX0t6VaWXE l17d1eUdXIpm0v2scb/R3Ij8kLRiBMd73STIQHbKsJo47fowhx+cj9WPHuKBeKDd liIql3R9fkzeSxfgMzdQC2Z1hKZIhAfQ2s+ZIJkwgvnYl+I+bkoE57RujbzMYtQ8 teL8JwqlNm5eKkXtAu81UaHUTSLoCczpNRPAKEZlGGoI1Ykj8MuAQVtKOb8lR/zO k9S9xdj0jqHLHuJXA3mUe6lMTk59pByrsAPNqzWJ6qqjvCRfohj1n6ucrt5J7jt4 mJlDU0EipQIASRwr+j482Z6qjn6yO4KGZ6NXkPgEdvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ls42lH As9gBZOIsdVGXqxUQvy1f6gbOB9gv3uDCyIBg=; b=JWtHx13aD8KrmXsrmAa3/Q jN+20FvmhkWkxVd4AEez/QgHtAMZJ1O5vrv7Of5UxQkjNw7N3jzVvhxgw2/XhxH6 MKvYFTb6ijKLypbX8HRDdvWN+4KeTZc+sha51QxSPg1UTW1r8iS8Da908QAwbQNV gHGl7Mf3n7v5YJCtIHfp1qkVzc5ao2LQNJtQgjElwT4vtQL5dDcey3r7C+jxfLJ4 tTLjnzGjR9WM9WdoZnfrw8+SlZbsbawx/HpuGTSguznvTOx1w0bZrHwjSFVrqnn5 fYYzI0epC/85HcDZM/1uQk15M77kpP6lMuJRv6N444pVM/++TiBb4+t30TNzHY6A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtddtgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 Nov 2021 11:09:46 -0400 (EDT) Date: Tue, 2 Nov 2021 16:09:44 +0100 From: Maxime Ripard To: Julian Braha Cc: airlied@linux.ie, daniel@ffwll.ch, jernej.skrabec@gmail.com, wens@csie.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, fazilyildiran@gmail.com Subject: Re: [PATCH] drm/sun4i: fix unmet dependency on RESET_CONTROLLER for PHY_SUN6I_MIPI_DPHY Message-ID: <20211102150944.h7ycdzlm4s5kvk4j@gilmour> References: <20211028221327.17984-1-julianbraha@gmail.com> MIME-Version: 1.0 In-Reply-To: <20211028221327.17984-1-julianbraha@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211102_080947_531568_6241FFBC X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8131087641972019931==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8131087641972019931== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sdgbi7nuhb2tf3wq" Content-Disposition: inline --sdgbi7nuhb2tf3wq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Oct 28, 2021 at 06:13:27PM -0400, Julian Braha wrote: > When PHY_SUN6I_MIPI_DPHY is selected, and RESET_CONTROLLER > is not selected, Kbuild gives the following warning: >=20 > WARNING: unmet direct dependencies detected for PHY_SUN6I_MIPI_DPHY > Depends on [n]: (ARCH_SUNXI [=3Dn] || COMPILE_TEST [=3Dy]) && HAS_IOMEM= [=3Dy] && COMMON_CLK [=3Dy] && RESET_CONTROLLER [=3Dn] > Selected by [y]: > - DRM_SUN6I_DSI [=3Dy] && HAS_IOMEM [=3Dy] && DRM_SUN4I [=3Dy] >=20 > This is because DRM_SUN6I_DSI selects PHY_SUN6I_MIPI_DPHY > without selecting or depending on RESET_CONTROLLER, despite > PHY_SUN6I_MIPI_DPHY depending on RESET_CONTROLLER. >=20 > These unmet dependency bugs were detected by Kismet, > a static analysis tool for Kconfig. Please advise if this > is not the appropriate solution. >=20 > Signed-off-by: Julian Braha > --- > drivers/gpu/drm/sun4i/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig > index 5755f0432e77..3f70a14a3c94 100644 > --- a/drivers/gpu/drm/sun4i/Kconfig > +++ b/drivers/gpu/drm/sun4i/Kconfig > @@ -46,6 +46,7 @@ config DRM_SUN6I_DSI > default MACH_SUN8I > select CRC_CCITT > select DRM_MIPI_DSI > + select RESET_CONTROLLER The indentation is off, can you fix it and resend it? Maxime --sdgbi7nuhb2tf3wq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYYFUuAAKCRDj7w1vZxhR xdQVAQCEOb8We3hYtT3mqkzFKDO4114iJbKGuP+0OpjI3IatWwD/dQ/ShFBmVkCN VR9uV82ZNKb6qsodk3xIjJPhbE8+Pw4= =2Lra -----END PGP SIGNATURE----- --sdgbi7nuhb2tf3wq-- --===============8131087641972019931== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8131087641972019931==--