All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: "netfilter-devel@vger.kernel.org"
	<netfilter-devel@vger.kernel.org>,
	Florian Westphal <fw@strlen.de>,
	Lahav Schlesinger <lschlesinger@drivenets.com>,
	David Ahern <dsahern@kernel.org>,
	stable@vger.kernel.org
Subject: Re: Potential problem with VRF+conntrack after kernel upgrade
Date: Tue, 2 Nov 2021 17:24:02 +0100	[thread overview]
Message-ID: <20211102162402.GB19266@breakpoint.cc> (raw)
In-Reply-To: <1a816689-3960-eb6b-2256-9478265d2d8e@netfilter.org>

Arturo Borrero Gonzalez <arturo@netfilter.org> wrote:

[ cc stable@ ]

> We experienced a major network outage today when upgrading kernels.
> 
> The affected servers run the VRF+conntrack+nftables combo. They are edge
> firewalls/NAT boxes, meaning most interesting traffic is not locally
> generated, but forwarded.
> 
> What we experienced is NATed traffic in the reply direction never being
> forwarded back to the original client.
> 
> Good kernel: 5.10.40 (debian 5.10.0-0.bpo.7-amd64)
> Bad kernel: 5.10.70 (debian 5.10.0-0.bpo.9-amd64)
> 
> I suspect the problem may be related to this patch:
> https://x-lore.kernel.org/stable/20210824165908.709932-58-sashal@kernel.org/

This commit has been reverted upstream:

55161e67d44fdd23900be166a81e996abd6e3be9
("vrf: Revert "Reset skb conntrack connection...").

Sasha, Greg, it would be good if you could apply this revert to all
stable trees that have a backport of
09e856d54bda5f288ef8437a90ab2b9b3eab83d1
("vrf: Reset skb conntrack connection on VRF rcv").

Arturo, it would be good if you could check current linux.git or
net.git -- those contain the revert + an alternate approach to address
the problem that 09e856d54bda5f288ef8437a90ab2b9b3eab83d1 tried to fix.

If net.git is still broken for your use case it would be great if you
could extend this test script:

https://patchwork.ozlabs.org/project/netfilter-devel/patch/20211018123813.17248-1-fw@strlen.de/

this would help to figure out what the issue is.

  reply	other threads:[~2021-11-02 16:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 14:32 Potential problem with VRF+conntrack after kernel upgrade Arturo Borrero Gonzalez
2021-11-02 16:24 ` Florian Westphal [this message]
2021-11-03  9:42   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211102162402.GB19266@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=arturo@netfilter.org \
    --cc=dsahern@kernel.org \
    --cc=lschlesinger@drivenets.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.