From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E33AC433F5 for ; Tue, 2 Nov 2021 17:05:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1294D60EB9 for ; Tue, 2 Nov 2021 17:05:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1294D60EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:33840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhxET-0001dN-6Z for qemu-devel@archiver.kernel.org; Tue, 02 Nov 2021 13:05:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhwtP-0004el-LP for qemu-devel@nongnu.org; Tue, 02 Nov 2021 12:44:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:47619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhwtM-0004UP-S2 for qemu-devel@nongnu.org; Tue, 02 Nov 2021 12:44:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635871447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MQZygFxaXka73ARVFPZFjJtIQj1V18wdvsjXu5tQvEs=; b=hS0GUsItsiXZr3r3EurrTMw/yVlYzXOCZwlKCcmHsIoydG1GpHGvOQOZj+/x+9dmaIJs1v fCI5G2zer8o2+WFzex8dbKDGhsFyp+jXObIeXq4z5RQZyhL0TdZQ1Fs6R0Il188Q7bxmDY Ua/DhdZqagwKQ6SBXAT4tHSdRIiDMno= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-6QJr5Ix7ND-I-oAuhDbx2Q-1; Tue, 02 Nov 2021 12:44:03 -0400 X-MC-Unique: 6QJr5Ix7ND-I-oAuhDbx2Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97EB2117D666; Tue, 2 Nov 2021 16:44:02 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.193.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58F441002D71; Tue, 2 Nov 2021 16:43:18 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v3 0/3] memory: memory_region_is_mapped() cleanups Date: Tue, 2 Nov 2021 17:43:14 +0100 Message-Id: <20211102164317.45658-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.702, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , David Hildenbrand , Richard Henderson , Peter Xu , Igor Mammedov , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Playing with memory_region_is_mapped(), I realized that memory regions mapped via an alias behave a little bit "differently", as they don't have their ->container set. * memory_region_is_mapped() will never succeed for memory regions mapped via an alias * memory_region_to_address_space(), memory_region_find(), memory_region_find_rcu(), memory_region_present() won't work, which seems okay, because we don't expect such memory regions getting passed to these functions. * memory_region_to_absolute_addr() will result in a wrong address. As the result is only used for tracing, that is tolerable. Let's cleanup/fix the code and documentation of memory_region_is_mapped() and change one user that really should be checking something else. v1 -> v2: - "memory: Make memory_region_is_mapped() succeed when mapped via an alias" -- Add an assertion - Add RBs Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Peter Xu Cc: Igor Mammedov Cc: Richard Henderson Cc: "Philippe Mathieu-Daudé" David Hildenbrand (3): machine: Use host_memory_backend_is_mapped() in machine_consume_memdev() memory: Make memory_region_is_mapped() succeed when mapped via an alias memory: Update description of memory_region_is_mapped() hw/core/machine.c | 2 +- include/exec/memory.h | 4 +++- softmmu/memory.c | 13 ++++++++++++- 3 files changed, 16 insertions(+), 3 deletions(-) -- 2.31.1