From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88AB7C433FE for ; Tue, 2 Nov 2021 16:45:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D56FD610FC for ; Tue, 2 Nov 2021 16:45:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D56FD610FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D147C82FC5; Tue, 2 Nov 2021 17:45:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="PnQoJWcw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B4FAB8319B; Tue, 2 Nov 2021 17:45:02 +0100 (CET) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 89D3A82051 for ; Tue, 2 Nov 2021 17:44:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72c.google.com with SMTP id br39so7059887qkb.8 for ; Tue, 02 Nov 2021 09:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gPkcE5T6hJHDFZqqE97mlIVWebGsCUaib3k9LdFQ7aY=; b=PnQoJWcwymCbQmQzFV2jLuv8okA3aKlvH5UIGZ5rfh6pOulWRIcRPLOynAWLpGOf50 XjO5C87sLt2HQX8jSWjHdVMpZxolV/l6A9kTK6ZGROKCYkqXYRmWXdieQCNsTqwsaaVI BObHxAAREFsd7uUnotHe1b6kQYhvPW15UpsCY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gPkcE5T6hJHDFZqqE97mlIVWebGsCUaib3k9LdFQ7aY=; b=YkfTy5Mv4GIQCIaDmpYLm05D36+eFxWhn2hWqZ8VDTPrQ0569Ht3x5iSe6HX8ZIDqa tWQppSduBt1jUE51eF9PmsGWkE6f5lOeNENt3mTVY0RXxU0hUqyqDlbFrj6P0bKX011x TEW3qwJ1AeBKskHc9mcoR2XEAu/NRkTKgHuhnm+bXtb56WM/fS1zoY8Lly3fKivOiP6N lJBq9NSrgGHyAP/91qL403F83WmRuLS1GyRpqSWNWKvKwbZmv5keZn4ydUeYQm/geDvc PSz54zhK0e5O6NCZI8FhfK4IoCoWGinKl62BeEmB0lUDPZX5kEKtZITvmPJhOPVzVWhH vpKA== X-Gm-Message-State: AOAM530Ale6aZt57Fjhmh25EX4w3n+znHohr7u59fZ23P+xShmzDllcg 7gzYOoZVsPFGk1TIesBFRvwbdA== X-Google-Smtp-Source: ABdhPJxk2rGq9iiJgW+kJGxXIBZVfyfOYhl23Qx+BUbhTC+3elxEzE0KhJZQKLyXPrQPzaH2Ehhvrw== X-Received: by 2002:a05:620a:a48:: with SMTP id j8mr3089462qka.399.1635871497361; Tue, 02 Nov 2021 09:44:57 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-e929-65d4-8978-cf6f.res6.spectrum.com. [2603:6081:7b01:cbda:e929:65d4:8978:cf6f]) by smtp.gmail.com with ESMTPSA id j20sm13529194qtj.72.2021.11.02.09.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 09:44:56 -0700 (PDT) Date: Tue, 2 Nov 2021 12:44:54 -0400 From: Tom Rini To: Artem Lapkin Cc: sjg@chromium.org, marek.behun@nic.cz, narmstrong@baylibre.com, twarren@nvidia.com, andre.przywara@arm.com, u-boot@lists.denx.de, u-boot-amlogic@groups.io, art@khadas.com, nick@khadas.com, gouwa@khadas.com Subject: Re: [PATCH v1] env: setenv add resolve value option Message-ID: <20211102164454.GQ24579@bill-the-cat> References: <20211102071914.696963-1-art@khadas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xHR3sS2kvo5MIJEm" Content-Disposition: inline In-Reply-To: <20211102071914.696963-1-art@khadas.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --xHR3sS2kvo5MIJEm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 02, 2021 at 03:19:14PM +0800, Artem Lapkin wrote: > Add possibility setup env variable with additional resolving vars inside > value. >=20 > Usage examples >=20 > =3D> setenv a hello > =3D> setenv b world > =3D> setenv c '${a} ${b}' > =3D> setenv -r d '${c}! ${a}...' > =3D> printenv d > d=3Dhello world! hello... >=20 > /* internal usage example */ > env_resolve("d", "${c}! ${a}..."); > /* d=3D"hello world! hello..." */ >=20 > Notes >=20 > Resolving works only for ${var} "bracket" and didn't workd for > "unbracket" $var >=20 > =3D> setenv -r d '$c! $a...' > =3D> printenv d > d=3D$c! $a... >=20 > Signed-off-by: Artem Lapkin The high level problem I have with this patch is that we keep going back to "we really need to update to a modern hush (or other shell) rather than patching new features in to our ancient fork". --=20 Tom --xHR3sS2kvo5MIJEm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGBawMACgkQFHw5/5Y0 tyzvVwwAppEYr+FDIcr87sscDkrQ9/68yb+VjsJAjppDmtgPK8+BpphlJ72FG/yZ ABoWw+bpvXOwJESrQAmirKVjW3DOlykYik9IJDImkEj/RiCRuEbwMMgfxM4zIsE1 sRHCHFevIETHrdxiwmNuKAr+uFV0BcOixB8o8cL5svILMwyVjdHiFYkFInQhgHAC Q86+i2MTc437vVb24kLV0qsBt0eTmh62+VlxoXUFhHwvbshmijLJkqvv8cuyPTO9 YdDRDN8LNMQtISxxRiJ9KOQGiMGe0NmS7o8b8wx0Oozff1JY7GqV24sFlPkU3P4H Nl1ENJsoVpJ2vFMGvhSMAu5EFCR62J7ntzj2alOdi4uEhfvZEYnbMXHKMDraIply pYBsmPZd+nhahnXLN86sV1pILbZx+1mdj7Xj+92NxYMwqijhS4Td7pNCjIo97AGC aVLMnW4NPY3CZdnEEddlyhG/gTSibp0sj9EKAr2gEAN+0ZlSmnwn4izsMB9psHhG tMFqe4NQ =PIBt -----END PGP SIGNATURE----- --xHR3sS2kvo5MIJEm--