From: Nghia Le <nghialm78@gmail.com>
To: axboe@kernel.dk, asml.silence@gmail.com
Cc: Nghia Le <nghialm78@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
lukas.bulwahn@gmail.com
Subject: [PATCH] io_uring: remove redundant assignment to ret in io_register_iowq_max_workers()
Date: Wed, 3 Nov 2021 02:05:21 +0700 [thread overview]
Message-ID: <20211102190521.28291-1-nghialm78@gmail.com> (raw)
After the assignment, only exit path with label 'err' uses ret as
return value. However,before exiting through this path with label 'err',
ret is assigned with the return value of io_wq_max_workers(). Hence, the
initial assignment is redundant and can be removed.
Signed-off-by: Nghia Le <nghialm78@gmail.com>
---
fs/io_uring.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index acc05ff3aa19..d18f1f46ca83 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -10800,7 +10800,6 @@ static __cold int io_register_iowq_max_workers(struct io_ring_ctx *ctx,
memcpy(ctx->iowq_limits, new_count, sizeof(new_count));
ctx->iowq_limits_set = true;
- ret = -EINVAL;
if (tctx && tctx->io_wq) {
ret = io_wq_max_workers(tctx->io_wq, new_count);
if (ret)
--
2.25.1
next reply other threads:[~2021-11-02 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 19:05 Nghia Le [this message]
2021-11-02 20:29 ` [PATCH] io_uring: remove redundant assignment to ret in io_register_iowq_max_workers() Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-10-29 15:59 Nghia Le
2021-11-02 16:30 ` Lukas Bulwahn
2021-11-02 19:14 ` Nghia Le
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102190521.28291-1-nghialm78@gmail.com \
--to=nghialm78@gmail.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.