From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01357C433EF for ; Tue, 2 Nov 2021 22:39:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF2D360240 for ; Tue, 2 Nov 2021 22:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbhKBWlz (ORCPT ); Tue, 2 Nov 2021 18:41:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:51158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbhKBWlx (ORCPT ); Tue, 2 Nov 2021 18:41:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5F67F61058; Tue, 2 Nov 2021 22:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635892758; bh=O/fJB1Su3Q6+W+ASLuT2yZYyhlwKE3dR8/QUTtPvjD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tDNEFCkbG7NaEdirxQosgbQhsoyCtLel9OaEYYfvNmxtI8yX/CZlxBmSL764KxLTa uHTNSiRzacCfGvwV/W+jty7ZIKkVyuNKDewNUF+mKzl37QxFHJhysHodVYfnF5zReL QPpOi4p71CAaVlJatpUgYLh6o4dDYPjXk+FAUWdbkerflcu14JScXRFtwV6ge2pepd CMiVVqkNqVC3NNrEj2OSjSzmREhrhHrBD5Hti2CONiWwMIL2fhHAc3+oIkyDvEYGto cAzOjK0TJunxjBkAy0du4DTrl3FKDnEfUAE9AMpzV7w8ago4dm6alC2ZK1kiqPPzsh /RxIY56CKwu+g== Date: Tue, 2 Nov 2021 15:39:18 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: "Matthew Wilcox (Oracle)" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe Subject: Re: [PATCH 07/21] iomap: Convert iomap_releasepage to use a folio Message-ID: <20211102223918.GF2237511@magnolia> References: <20211101203929.954622-1-willy@infradead.org> <20211101203929.954622-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Nov 02, 2021 at 12:14:35AM -0700, Christoph Hellwig wrote: > On Mon, Nov 01, 2021 at 08:39:15PM +0000, Matthew Wilcox (Oracle) wrote: > > This is an address_space operation, so its argument must remain as a > > struct page, but we can use a folio internally. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Looks good, > > Reviewed-by: Christoph Hellwig This seems reasonable to me too. Even if my MTA saw "This is an ad" and spat it out. ;) That has now been fixed, so Reviewed-by: Darrick J. Wong --D