All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org,
	Paul Cercueil <paul@crapouillou.net>,
	Paul Burton <paul.burton@mips.com>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and <linux/power/jz4740-battery.h>
Date: Wed, 3 Nov 2021 13:40:46 +0100	[thread overview]
Message-ID: <20211103124046.te5rfhfvkbw2tby3@earth.universe> (raw)
In-Reply-To: <YYI9t2Ng1Uppkiav@google.com>

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

Hi,

On Wed, Nov 03, 2021 at 07:43:51AM +0000, Lee Jones wrote:
> On Tue, 02 Nov 2021, Jonathan Corbet wrote:
> > Commit ff71266aa490 ("mfd: Drop obsolete JZ4740 driver") removed the last
> > file to include <linux/jz4740-adc.h> but left the header file itself
> > behind.  Nothing uses it, remove it now.
> > 
> > Similarly, aea12071d6fc ("power/supply: Drop obsolete JZ4740 driver")
> > deleted the last use of <linux/power/jz4740-battery.h>, so remove that one
> > too.

Thanks for the cleanup Jonathan.

> > Cc: Paul Cercueil <paul@crapouillou.net>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Paul Burton <paul.burton@mips.com>
> > Cc: Sebastian Reichel <sre@kernel.org>
> > Cc: linux-pm@vger.kernel.org
> > Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> > ---
> >  include/linux/jz4740-adc.h           | 33 ----------------------------
> >  include/linux/power/jz4740-battery.h | 15 -------------
> 
> It appears as though there are still references to both of these
> *devices* in the kernel tree.  Should those be removed also?
> 
> >  2 files changed, 48 deletions(-)
> >  delete mode 100644 include/linux/jz4740-adc.h
> >  delete mode 100644 include/linux/power/jz4740-battery.h
> 
> Patch looks fine though.
> 
> Let me know if you want me to take it in via MFD.  Otherwise:
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

You can take it through MFD, no immutable branch needed.

Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2021-11-03 12:40 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 22:01 [PATCH 0/9] Remove some unused header files Jonathan Corbet
2021-11-02 22:01 ` [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and <linux/power/jz4740-battery.h> Jonathan Corbet
2021-11-02 22:19   ` Paul Cercueil
2021-11-03  7:43   ` Lee Jones
2021-11-03  9:27     ` Paul Cercueil
2021-11-03 10:13       ` Lee Jones
2021-11-03 12:40     ` Sebastian Reichel [this message]
2021-11-04  8:30       ` Lee Jones
2021-11-02 22:01 ` [PATCH 2/9] nfs: remove unused header <linux/pnfs_osd_xdr.h> Jonathan Corbet
2021-11-02 22:42   ` Trond Myklebust
2021-11-03 13:38     ` Jonathan Corbet
2021-11-03 13:54       ` Trond Myklebust
2021-11-02 22:01 ` [PATCH 3/9] Remove unused header <linux/cnt32_to_63.h> Jonathan Corbet
2021-11-02 22:38   ` Arnd Bergmann
2021-11-02 23:16   ` Nicolas Pitre
2021-11-03  6:31   ` Mike Rapoport
2021-11-02 22:01 ` [PATCH 4/9] Remove unused header <linux/sdb.h> Jonathan Corbet
2021-11-09 11:13   ` Linus Walleij
2021-11-02 22:01 ` [PATCH 5/9] Input: remove unused header <linux/input/cy8ctmg110_pdata.h> Jonathan Corbet
2021-11-02 23:47   ` Dmitry Torokhov
2021-11-02 22:02 ` [PATCH 6/9] mtd: remove unused header file <linux/mtd/latch-addr-flash.h> Jonathan Corbet
2021-11-02 22:02   ` Jonathan Corbet
2021-11-19 18:35   ` Miquel Raynal
2021-11-19 18:35     ` Miquel Raynal
2021-11-02 22:02 ` [PATCH 7/9] ARM: ixp4xx: remove unused header file pata_ixp4xx_cf.h Jonathan Corbet
2021-11-02 22:38   ` Arnd Bergmann
2021-11-10  8:30   ` Linus Walleij
2021-11-02 22:02 ` [PATCH 8/9] spi: remove unused header file <linux/platform_data/spi-clps711x.h> Jonathan Corbet
2021-11-02 22:02   ` Jonathan Corbet
2021-11-02 22:37   ` Arnd Bergmann
2021-11-02 22:37     ` Arnd Bergmann
2021-11-02 22:02 ` [PATCH 9/9] net: remove unused header file <linux/ks8851_mll.h> Jonathan Corbet
2021-11-03  8:43 ` [PATCH 4/9] Remove unused header <linux/sdb.h> Alessandro Rubini
2021-11-15 19:21 ` (subset) [PATCH 0/9] Remove some unused header files Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103124046.te5rfhfvkbw2tby3@earth.universe \
    --to=sre@kernel.org \
    --cc=corbet@lwn.net \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=paul.burton@mips.com \
    --cc=paul@crapouillou.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.