From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE5A2C433EF for ; Thu, 4 Nov 2021 08:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2F3F6103B for ; Thu, 4 Nov 2021 08:53:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230445AbhKDI4S (ORCPT ); Thu, 4 Nov 2021 04:56:18 -0400 Received: from verein.lst.de ([213.95.11.211]:34363 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbhKDI4R (ORCPT ); Thu, 4 Nov 2021 04:56:17 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 89EB968AA6; Thu, 4 Nov 2021 09:53:36 +0100 (CET) Date: Thu, 4 Nov 2021 09:53:36 +0100 From: Christoph Hellwig To: Walter Wu Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Matthias Brugger , Ard Biesheuvel , Andrew Morton , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream , linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2] dma-direct: improve DMA_ATTR_NO_KERNEL_MAPPING Message-ID: <20211104085336.GA24260@lst.de> References: <20211104023221.16391-1-walter-zh.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211104023221.16391-1-walter-zh.wu@mediatek.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 04, 2021 at 10:32:21AM +0800, Walter Wu wrote: > diff --git a/include/linux/set_memory.h b/include/linux/set_memory.h > index f36be5166c19..6c7d1683339c 100644 > --- a/include/linux/set_memory.h > +++ b/include/linux/set_memory.h > @@ -7,11 +7,16 @@ > > #ifdef CONFIG_ARCH_HAS_SET_MEMORY > #include > + > +#ifndef CONFIG_RODATA_FULL_DEFAULT_ENABLED This is an arm64-specific symbol, and one that only controls a default. I don't think it is suitable to key off stubs in common code. > +static inline int set_memory_valid(unsigned long addr, int numpages, int enable) { return 0; } Pleae avoid overly long lines. > + if (IS_ENABLED(CONFIG_RODATA_FULL_DEFAULT_ENABLED)) { > + kaddr = (unsigned long)phys_to_virt(dma_to_phys(dev, *dma_handle)); This can just use page_address. > + /* page remove kernel mapping for arm64 */ > + set_memory_valid(kaddr, size >> PAGE_SHIFT, 0); > + } But more importantly: set_memory_valid only exists on arm64, this will break compile everywhere else. And this API is complete crap. Passing kernel virtual addresses as unsigned long just sucks, and passing an integer argument for valid/non-valid also is a horrible API. Not to mention the overly long line. Same on the free side. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43317C433F5 for ; Thu, 4 Nov 2021 08:53:45 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA3486103B for ; Thu, 4 Nov 2021 08:53:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA3486103B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 717FA4022B; Thu, 4 Nov 2021 08:53:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h5fJVGGTKpKu; Thu, 4 Nov 2021 08:53:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 6C1D5403C5; Thu, 4 Nov 2021 08:53:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2DE93C0019; Thu, 4 Nov 2021 08:53:43 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 074BFC0012 for ; Thu, 4 Nov 2021 08:53:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E9E29403C5 for ; Thu, 4 Nov 2021 08:53:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m9jBtLwHPpxZ for ; Thu, 4 Nov 2021 08:53:41 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5C2974022B for ; Thu, 4 Nov 2021 08:53:41 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 89EB968AA6; Thu, 4 Nov 2021 09:53:36 +0100 (CET) Date: Thu, 4 Nov 2021 09:53:36 +0100 From: Christoph Hellwig To: Walter Wu Subject: Re: [PATCH v2] dma-direct: improve DMA_ATTR_NO_KERNEL_MAPPING Message-ID: <20211104085336.GA24260@lst.de> References: <20211104023221.16391-1-walter-zh.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211104023221.16391-1-walter-zh.wu@mediatek.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: wsd_upstream , linux-kernel@vger.kernel.org, Christoph Hellwig , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Andrew Morton , Robin Murphy , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Nov 04, 2021 at 10:32:21AM +0800, Walter Wu wrote: > diff --git a/include/linux/set_memory.h b/include/linux/set_memory.h > index f36be5166c19..6c7d1683339c 100644 > --- a/include/linux/set_memory.h > +++ b/include/linux/set_memory.h > @@ -7,11 +7,16 @@ > > #ifdef CONFIG_ARCH_HAS_SET_MEMORY > #include > + > +#ifndef CONFIG_RODATA_FULL_DEFAULT_ENABLED This is an arm64-specific symbol, and one that only controls a default. I don't think it is suitable to key off stubs in common code. > +static inline int set_memory_valid(unsigned long addr, int numpages, int enable) { return 0; } Pleae avoid overly long lines. > + if (IS_ENABLED(CONFIG_RODATA_FULL_DEFAULT_ENABLED)) { > + kaddr = (unsigned long)phys_to_virt(dma_to_phys(dev, *dma_handle)); This can just use page_address. > + /* page remove kernel mapping for arm64 */ > + set_memory_valid(kaddr, size >> PAGE_SHIFT, 0); > + } But more importantly: set_memory_valid only exists on arm64, this will break compile everywhere else. And this API is complete crap. Passing kernel virtual addresses as unsigned long just sucks, and passing an integer argument for valid/non-valid also is a horrible API. Not to mention the overly long line. Same on the free side. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6B4FC433F5 for ; Thu, 4 Nov 2021 08:54:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87BED610FC for ; Thu, 4 Nov 2021 08:54:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 87BED610FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uwAh17oaL6WXGcP58piURDVBLKnHiUXM+MaAK3OgO00=; b=oIwKfn1CbJ8UZ1 ZwDBFCXjNN3eNii29t5ksEiSRmO9Hju61dAIxWfTzwWwJBJ1Ioy3qxXThDtIq4KDb81qNsJdfvA7Q HyEDbF9f8FWDij/lO4xEonbIwdfKrkHKazaA5V3LTh7dTU3yo0DY9SwRh8UcuGH4T9s2yGZMz+fR+ ITJeZJra4/PsAWh9EfZ7zwuPBPxJokkP1vnsHyPinZW76nLbb1j9BtO9B6/ut6gVrOiNFcLPX2Imj l55RxkNLDAPK4JCA7O3PQWNvAVW4RCv4xunTtwKvyhca6EW70xXgbiNjjwXNoqBa4tig1KoaGY5oW +ot3iqyvlegDdydjWNTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miYVU-008NFM-Df; Thu, 04 Nov 2021 08:54:00 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miYVI-008NBx-Ey; Thu, 04 Nov 2021 08:53:49 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 89EB968AA6; Thu, 4 Nov 2021 09:53:36 +0100 (CET) Date: Thu, 4 Nov 2021 09:53:36 +0100 From: Christoph Hellwig To: Walter Wu Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Matthias Brugger , Ard Biesheuvel , Andrew Morton , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream , linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2] dma-direct: improve DMA_ATTR_NO_KERNEL_MAPPING Message-ID: <20211104085336.GA24260@lst.de> References: <20211104023221.16391-1-walter-zh.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211104023221.16391-1-walter-zh.wu@mediatek.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211104_015348_694930_E4A49BC0 X-CRM114-Status: GOOD ( 18.70 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Nov 04, 2021 at 10:32:21AM +0800, Walter Wu wrote: > diff --git a/include/linux/set_memory.h b/include/linux/set_memory.h > index f36be5166c19..6c7d1683339c 100644 > --- a/include/linux/set_memory.h > +++ b/include/linux/set_memory.h > @@ -7,11 +7,16 @@ > > #ifdef CONFIG_ARCH_HAS_SET_MEMORY > #include > + > +#ifndef CONFIG_RODATA_FULL_DEFAULT_ENABLED This is an arm64-specific symbol, and one that only controls a default. I don't think it is suitable to key off stubs in common code. > +static inline int set_memory_valid(unsigned long addr, int numpages, int enable) { return 0; } Pleae avoid overly long lines. > + if (IS_ENABLED(CONFIG_RODATA_FULL_DEFAULT_ENABLED)) { > + kaddr = (unsigned long)phys_to_virt(dma_to_phys(dev, *dma_handle)); This can just use page_address. > + /* page remove kernel mapping for arm64 */ > + set_memory_valid(kaddr, size >> PAGE_SHIFT, 0); > + } But more importantly: set_memory_valid only exists on arm64, this will break compile everywhere else. And this API is complete crap. Passing kernel virtual addresses as unsigned long just sucks, and passing an integer argument for valid/non-valid also is a horrible API. Not to mention the overly long line. Same on the free side. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC2DC433EF for ; Thu, 4 Nov 2021 08:55:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA44961059 for ; Thu, 4 Nov 2021 08:55:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA44961059 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FSN/RtExQuRsGg2uelKxOmB1yPvz/KDfvpYqhLVqCak=; b=W9l/Ncf2RXvacz uuZiKAhHffHCyaWFEl+30W5BXdxi/DYuwm+U7BQUyqihcwt5PaxQfZr430Kwy/gOdw1jaIP+GbTFr HeA2avr4OcdygTIL/wFL1hFKpzuQ17Wx2fkHg+dJJSmeDN58wvL7/RB7+cniTweD50Jukfu4d5SKq ply+EPkhnLI2rAGVsecSTEBeh34RffF6scxbvwHu/N6IfnVGbqlr259x8AYouP4MZp6jdP6cY0kz5 Blo3I3e0lNgQ0tcmxxXGk155pcS/4djEIkovEjI3GDWVr4l/jaIgdUYrGcytH5qElKJWLHK2vXvwI ic6u6yx+/Th/mmiMPoRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miYVL-008NDT-K7; Thu, 04 Nov 2021 08:53:51 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miYVI-008NBx-Ey; Thu, 04 Nov 2021 08:53:49 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 89EB968AA6; Thu, 4 Nov 2021 09:53:36 +0100 (CET) Date: Thu, 4 Nov 2021 09:53:36 +0100 From: Christoph Hellwig To: Walter Wu Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Matthias Brugger , Ard Biesheuvel , Andrew Morton , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream , linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2] dma-direct: improve DMA_ATTR_NO_KERNEL_MAPPING Message-ID: <20211104085336.GA24260@lst.de> References: <20211104023221.16391-1-walter-zh.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211104023221.16391-1-walter-zh.wu@mediatek.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211104_015348_694930_E4A49BC0 X-CRM114-Status: GOOD ( 18.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 04, 2021 at 10:32:21AM +0800, Walter Wu wrote: > diff --git a/include/linux/set_memory.h b/include/linux/set_memory.h > index f36be5166c19..6c7d1683339c 100644 > --- a/include/linux/set_memory.h > +++ b/include/linux/set_memory.h > @@ -7,11 +7,16 @@ > > #ifdef CONFIG_ARCH_HAS_SET_MEMORY > #include > + > +#ifndef CONFIG_RODATA_FULL_DEFAULT_ENABLED This is an arm64-specific symbol, and one that only controls a default. I don't think it is suitable to key off stubs in common code. > +static inline int set_memory_valid(unsigned long addr, int numpages, int enable) { return 0; } Pleae avoid overly long lines. > + if (IS_ENABLED(CONFIG_RODATA_FULL_DEFAULT_ENABLED)) { > + kaddr = (unsigned long)phys_to_virt(dma_to_phys(dev, *dma_handle)); This can just use page_address. > + /* page remove kernel mapping for arm64 */ > + set_memory_valid(kaddr, size >> PAGE_SHIFT, 0); > + } But more importantly: set_memory_valid only exists on arm64, this will break compile everywhere else. And this API is complete crap. Passing kernel virtual addresses as unsigned long just sucks, and passing an integer argument for valid/non-valid also is a horrible API. Not to mention the overly long line. Same on the free side. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel