All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-s390x@nongnu.org
Subject: Re: [RFC PATCH v1 0/3]  virtio: early detect 'modern' virtio
Date: Fri, 5 Nov 2021 03:42:33 -0400	[thread overview]
Message-ID: <20211105034053-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20211028220017.930806-1-pasic@linux.ibm.com>

On Fri, Oct 29, 2021 at 12:00:14AM +0200, Halil Pasic wrote:
> This is an early RFC for a transport specific early detecton of
> modern virtio, which is most relevant for transitional devices on big
> endian platforms, when drivers access the config space before
> FEATURES_OK is set.
> 
> The most important part that is missing here is fixing the problems that
> arrise in the situation described in the previous paragraph, when the
> config is managed by a vhost device (and thus outside QEMU).
> 
> This series was only lightly tested. 

I think it's a good enough approach, and we are getting close
to release. For vhost - a new callback just for that? Would be ok.
Or just invoke set features - if this works.


> Halil Pasic (3):
>   virtio: introduce virtio_force_modern()
>   virtio-ccw: use virtio_force_modern
>   virtio-pci: use virtio_force_modern()
> 
>  hw/s390x/virtio-ccw.c      |  3 +++
>  hw/virtio/virtio-pci.c     |  1 +
>  hw/virtio/virtio.c         | 12 ++++++++++++
>  include/hw/virtio/virtio.h |  1 +
>  4 files changed, 17 insertions(+)
> 
> 
> base-commit: 2c3e83f92d93fbab071b8a96b8ab769b01902475
> -- 
> 2.25.1



  parent reply	other threads:[~2021-11-05  7:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 22:00 [RFC PATCH v1 0/3] virtio: early detect 'modern' virtio Halil Pasic
2021-10-28 22:00 ` [RFC PATCH v1 1/3] virtio: introduce virtio_force_modern() Halil Pasic
2021-10-29 14:53   ` Cornelia Huck
2021-11-12 15:42     ` Halil Pasic
2021-11-12 15:55       ` Cornelia Huck
2021-11-12 16:36         ` Halil Pasic
2021-10-28 22:00 ` [RFC PATCH v1 2/3] virtio-ccw: use virtio_force_modern Halil Pasic
2021-10-28 22:00 ` [RFC PATCH v1 3/3] virtio-pci: use virtio_force_modern() Halil Pasic
2021-11-05  7:42 ` Michael S. Tsirkin [this message]
2021-11-09 10:12   ` [RFC PATCH v1 0/3] virtio: early detect 'modern' virtio Halil Pasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211105034053-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.