From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E92DC433F5 for ; Fri, 5 Nov 2021 08:50:54 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7084261139 for ; Fri, 5 Nov 2021 08:50:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7084261139 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 363A2836C7; Fri, 5 Nov 2021 09:50:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="OHToULb6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6FE5C836C4; Fri, 5 Nov 2021 09:50:49 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0B0F3833E6 for ; Fri, 5 Nov 2021 09:50:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A21661186; Fri, 5 Nov 2021 08:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636102244; bh=RyQ/fBUA/dZvtnEU0ne178VSBG86wGbrvgkBnk04zfM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OHToULb604aYHfSEbiTzJX9ZWUTR8UuI7UOgnF/XhgACN1zND8S/8Eq5ffoEgSBol t9W+Qv0Cskz3hvsNSY+eKyWtghFg1qSh1Ox/g9kM+sObD9a2lnaLAYDUO0C3ThJ+YH nn4nFMvujZbUKGLKttPi93WzlbOMCp9d+KSUFmd0sYyPSpp5E1OwzJ2dc+HUZjmXS4 SZtd7VLf5RNjLter1KWBk5kSIEC+k15eKbzu/dJD7DE5etRRlltjoyoBVoXrpw9G/q GnY+GN0iGzZRWsxeC2fOhT0bsbnp/l03g7fOoewk6l+L9gzhwZ/bIl44Uj+v/6ejo5 67ulmNycwj8PQ== Received: by pali.im (Postfix) id 49BC8638; Fri, 5 Nov 2021 09:50:42 +0100 (CET) Date: Fri, 5 Nov 2021 09:50:42 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: Marek =?utf-8?B?QmVow7pu?= , u-boot@lists.denx.de, Marek =?utf-8?B?QmVow7pu?= Subject: Re: [PATCH v2 11/12] arm: mvebu: Espressobin: Use new API for setting default env at runtime Message-ID: <20211105085042.3ztjer7g2xy5ec7t@pali> References: <20211103232332.2737-1-kabel@kernel.org> <20211103232332.2737-12-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thursday 04 November 2021 20:02:33 Simon Glass wrote: > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > From: Marek Behún > > > > ESPRESSObin's board code uses an ad-hoc solution for ensuring that > > ethaddrs are not overwritten by `env default -a` command and that the > > `fdtfile` is set to correct value when `env default -a` is called. > > > > This ad-hoc solution is overwriting the default_environment[] buffer in > > board_late_init(). > > > > Since now we have a specific API for overwriting default environment, > > convert this ad-hoc code to this new API. > > > > Signed-off-by: Marek Behún > > --- > > board/Marvell/mvebu_armada-37xx/board.c | 135 +++++++++++++------- > > configs/mvebu_espressobin-88f3720_defconfig | 1 + > > include/configs/mvebu_armada-37xx.h | 17 +-- > > 3 files changed, 90 insertions(+), 63 deletions(-) > > Reviewed-by: Simon Glass Hello Simon! This change needs to be properly tested to ensure that detection of eMMC is still correctly working and erase of MAC addresses does not happen again. I will try to find some time during next week to test this patch series on Espressobin board.