From: "Darrick J. Wong" <djwong@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: fdmanana@gmail.com, fstests@vger.kernel.org,
Anthony Iliopoulos <ailiopoulos@suse.de>
Subject: Re: [PATCH] fsstress: improve error message on check_cwd() error
Date: Fri, 5 Nov 2021 09:09:10 -0700 [thread overview]
Message-ID: <20211105160910.GB24282@magnolia> (raw)
In-Reply-To: <YYVWBdHBuj4hQnMy@bombadil.infradead.org>
On Fri, Nov 05, 2021 at 09:04:21AM -0700, Luis Chamberlain wrote:
> On Wed, Nov 03, 2021 at 11:18:22AM -0700, Luis Chamberlain wrote:
> > On Wed, Nov 03, 2021 at 09:24:34AM -0700, Darrick J. Wong wrote:
> > > > - if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
> > > > + if (statbuf.st_ino == top_ino)
> > > > return;
> > > > +
> > > > + fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%lu) != top_ino (%lu)\n",
> > > > + statbuf.st_ino, top_ino);
> > >
> > > This might want some explicit casting, since this can be defined as
> > > anything between unsigned long to uint64_t, at least according to the
> > > glibc headers on my system.
> >
> > Um, Filipe had suggested something a bit different before. Can you guys
> > decide and let me know your final preference ? :)
>
> Any final preference / recommendation?
Use %llu with explicit casts to (unsigned long long) and it should work
fine everywhere.
--D
> Luis
next prev parent reply other threads:[~2021-11-05 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 15:55 [PATCH] fsstress: improve error message on check_cwd() error Luis Chamberlain
2021-11-03 16:24 ` Darrick J. Wong
2021-11-03 18:18 ` Luis Chamberlain
2021-11-05 16:04 ` Luis Chamberlain
2021-11-05 16:09 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-21 17:50 Luis Chamberlain
2021-09-22 10:15 ` Filipe Manana
2021-09-22 20:07 ` Luis Chamberlain
2021-09-23 12:37 ` Filipe Manana
2021-11-01 15:50 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105160910.GB24282@magnolia \
--to=djwong@kernel.org \
--cc=ailiopoulos@suse.de \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.