All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>,
	Lee Jones <lee.jones@linaro.org>
Cc: linux-pwm@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	kernel@pengutronix.de
Subject: Re: [PATCH 0/3] pwm: Some improvements for legacy drivers
Date: Fri, 5 Nov 2021 20:19:05 +0100	[thread overview]
Message-ID: <20211105191905.i2ixhea2tmr5u7tg@pengutronix.de> (raw)
In-Reply-To: <20210701072927.328254-1-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

Hello Thierry,

On Thu, Jul 01, 2021 at 09:29:24AM +0200, Uwe Kleine-König wrote:
> this is the successor of my earlier patch "pwm: Ensure for legacy
> drivers that pwm->state stays consistent" that was applied shortly to
> next until Geert found a problem with it.
> 
> I split the patch in three parts now: First the legacy handling is just
> moved to a separate function without any semantic change. Then a glitch
> is fixed, but without the regression I introduced initially. In the
> third and last patch the longstanding FIXME about breaking pwm->state if
> a callback fails is addressed.

I noticed you collected patches for the current merge window, but among
others skipped this series.

You mentioned two doubts, but never reacted on my replies that (IMHO)
should remove your doubts.

Can you please voice your concerns?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2021-11-05 19:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  7:29 [PATCH 0/3] pwm: Some improvements for legacy drivers Uwe Kleine-König
2021-07-01  7:29 ` [PATCH 1/3] pwm: Move legacy driver handling into a dedicated function Uwe Kleine-König
2021-07-01  7:29 ` [PATCH 2/3] pwm: Prevent a glitch for legacy drivers Uwe Kleine-König
2021-08-19 13:36   ` Thierry Reding
2021-09-07 10:36     ` Uwe Kleine-König
2021-07-01  7:29 ` [PATCH 3/3] pwm: Restore initial state if a legacy callback fails Uwe Kleine-König
2021-08-19 13:28   ` Thierry Reding
2021-09-07 10:41     ` Uwe Kleine-König
2021-07-01  8:58 ` [PATCH 0/3] pwm: Some improvements for legacy drivers Geert Uytterhoeven
2021-07-01 10:45   ` Uwe Kleine-König
2021-07-01 11:41     ` Geert Uytterhoeven
2021-07-01 12:19       ` Uwe Kleine-König
2021-11-05 19:19 ` Uwe Kleine-König [this message]
2021-11-17 16:12 ` Thierry Reding
2021-11-23 17:15   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211105191905.i2ixhea2tmr5u7tg@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=geert@linux-m68k.org \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.