From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13659C433F5 for ; Mon, 8 Nov 2021 11:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF9E661381 for ; Mon, 8 Nov 2021 11:11:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237344AbhKHLOY (ORCPT ); Mon, 8 Nov 2021 06:14:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:50930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236176AbhKHLOW (ORCPT ); Mon, 8 Nov 2021 06:14:22 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D44C61360; Mon, 8 Nov 2021 11:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636369898; bh=7jjDd9CBG4/LM9amMERhrdw6zgQgalfZow+o2TL+xNc=; h=From:To:Cc:Subject:Date:From; b=ZEAOGc3d4l/towaigTVgofn/UkzylCCIJ+PhIFhCQ3xphTcn1FlajJ0XOeScD0Fyw lXNNInOyttPKnW/iVWxjcocDkiwdM9pPv8xJABz1ksoLMlF6g6mGC3pXaiwnEwc1UT zmQKV6b66LgBfc+T6dk77dvV1HuvKeCFo5m6AckiAWLzCwz8kOOQs1m24DcXr/5SRF XR9WkoJP/sNM0Lm9MRAkpV7knrwo/6ygiH7IZrlZSobStZgOOaYS2rF6zQSXgMgLw/ 4Sx8TEZVczKCP4O9PVmxH6c3NQdkZAkxHg/cfnlHTjVM+9L6Xw5bG0aNLGveO9brR9 91OPC9ACS3psw== From: Arnd Bergmann To: Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta Cc: Arnd Bergmann , Mark Brown , Jaroslav Kysela , Takashi Iwai , Colin Ian King , Peter Ujfalusi , Randy Dunlap , Bud Liviu-Alexandru , Paul Olaru , sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: SOF: build compression interface into snd_sof.ko Date: Mon, 8 Nov 2021 12:11:14 +0100 Message-Id: <20211108111132.3800548-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann With CONFIG_SND_SOC_SOF_COMPRESS=m, the compression code is not built into a the main SOF driver when that is built-in: x86_64-linux-ld: sound/soc/sof/ipc.o: in function `ipc_stream_message': ipc.c:(.text+0x5a2): undefined reference to `snd_sof_compr_fragment_elapsed' x86_64-linux-ld: sound/soc/sof/topology.o: in function `sof_dai_load': topology.c:(.text+0x32d1): undefined reference to `snd_sof_compr_init_elapsed_work' x86_64-linux-ld: topology.c:(.text+0x32e1): undefined reference to `snd_sof_compr_init_elapsed_work' Make this a 'bool' symbol so it just decides whether the code gets built at all. Fixes: 858f7a5c45ca ("ASoC: SOF: Introduce fragment elapsed notification API") Signed-off-by: Arnd Bergmann --- sound/soc/sof/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 6bb4db87af03..041c54639c4d 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -47,7 +47,7 @@ config SND_SOC_SOF_OF Say Y if you need this option. If unsure select "N". config SND_SOC_SOF_COMPRESS - tristate + bool select SND_SOC_COMPRESS config SND_SOC_SOF_DEBUG_PROBES -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB544C433EF for ; Mon, 8 Nov 2021 11:12:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6CFF603E9 for ; Mon, 8 Nov 2021 11:12:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B6CFF603E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 213531658; Mon, 8 Nov 2021 12:11:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 213531658 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1636369969; bh=7jjDd9CBG4/LM9amMERhrdw6zgQgalfZow+o2TL+xNc=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=sVwaJQc9380KWLoTohf2vZ9el7wSrEGBbigiFO31S/PbtWI6fTUgbI7B/pmyQOMxC 9Blbx2Nv3QCIO2xETIYRdBbgTmm4Hcqwl+jO+xtvQXzLynx45f+wDtf/tUWO+Izzug vpykmDMXltBqyAq48blnvTIV3FRKwVQhIGG8o1sw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 35D36F80227; Mon, 8 Nov 2021 12:11:57 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 79EAAF8049E; Mon, 8 Nov 2021 12:11:55 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 22B44F801D8; Mon, 8 Nov 2021 12:11:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 22B44F801D8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZEAOGc3d" Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D44C61360; Mon, 8 Nov 2021 11:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636369898; bh=7jjDd9CBG4/LM9amMERhrdw6zgQgalfZow+o2TL+xNc=; h=From:To:Cc:Subject:Date:From; b=ZEAOGc3d4l/towaigTVgofn/UkzylCCIJ+PhIFhCQ3xphTcn1FlajJ0XOeScD0Fyw lXNNInOyttPKnW/iVWxjcocDkiwdM9pPv8xJABz1ksoLMlF6g6mGC3pXaiwnEwc1UT zmQKV6b66LgBfc+T6dk77dvV1HuvKeCFo5m6AckiAWLzCwz8kOOQs1m24DcXr/5SRF XR9WkoJP/sNM0Lm9MRAkpV7knrwo/6ygiH7IZrlZSobStZgOOaYS2rF6zQSXgMgLw/ 4Sx8TEZVczKCP4O9PVmxH6c3NQdkZAkxHg/cfnlHTjVM+9L6Xw5bG0aNLGveO9brR9 91OPC9ACS3psw== From: Arnd Bergmann To: Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta Subject: [PATCH] ASoC: SOF: build compression interface into snd_sof.ko Date: Mon, 8 Nov 2021 12:11:14 +0100 Message-Id: <20211108111132.3800548-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, Arnd Bergmann , Bud Liviu-Alexandru , Randy Dunlap , Takashi Iwai , Mark Brown , Paul Olaru , Colin Ian King , Peter Ujfalusi , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Arnd Bergmann With CONFIG_SND_SOC_SOF_COMPRESS=m, the compression code is not built into a the main SOF driver when that is built-in: x86_64-linux-ld: sound/soc/sof/ipc.o: in function `ipc_stream_message': ipc.c:(.text+0x5a2): undefined reference to `snd_sof_compr_fragment_elapsed' x86_64-linux-ld: sound/soc/sof/topology.o: in function `sof_dai_load': topology.c:(.text+0x32d1): undefined reference to `snd_sof_compr_init_elapsed_work' x86_64-linux-ld: topology.c:(.text+0x32e1): undefined reference to `snd_sof_compr_init_elapsed_work' Make this a 'bool' symbol so it just decides whether the code gets built at all. Fixes: 858f7a5c45ca ("ASoC: SOF: Introduce fragment elapsed notification API") Signed-off-by: Arnd Bergmann --- sound/soc/sof/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 6bb4db87af03..041c54639c4d 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -47,7 +47,7 @@ config SND_SOC_SOF_OF Say Y if you need this option. If unsure select "N". config SND_SOC_SOF_COMPRESS - tristate + bool select SND_SOC_COMPRESS config SND_SOC_SOF_DEBUG_PROBES -- 2.29.2