From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47293C4167D for ; Tue, 9 Nov 2021 01:16:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B9BF61AA2 for ; Tue, 9 Nov 2021 01:16:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243580AbhKIBSw (ORCPT ); Mon, 8 Nov 2021 20:18:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:38612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241468AbhKIBMo (ORCPT ); Mon, 8 Nov 2021 20:12:44 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CB32761A7F; Tue, 9 Nov 2021 01:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636419911; bh=yATXGdaUzZgEZsx70fgb68NdEgPLCYLLlzykAUdNEcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S3N4n6cu9D3xQrERafZPllKFwj5zJ4kaKt2vK4nQ9+bLrALk2qxT1yleEUawjECIg gphgfDAizfPgTxjN+1rusYOWbkyBn5LbS4CHKIR3fSFMBhOrK71eJUlWE1EyNNI9Ee Qv3G0L5RqmJyISBRX9upt3309rCPQHL1qOoiULfUaXmyX8OCDUP2M/KXgoakV3lSo2 UxNQb4+mb/EdT9mE5hYCmJc0KDfzOV9W0ZVgzyfoCrMGmXOJ87qlvF7TJwcP5PWKAU 4MpcETP7NVJ8FuELHXpt8CyyfVNisCNrbCa3FD0zbMW4uNEdnoQo1fEyPFYh0M53La sZcONrvbhyPVg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nadezda Lutovinova , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 26/74] media: s5p-mfc: Add checking to s5p_mfc_probe(). Date: Mon, 8 Nov 2021 12:48:53 -0500 Message-Id: <20211108174942.1189927-26-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211108174942.1189927-1-sashal@kernel.org> References: <20211108174942.1189927-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nadezda Lutovinova [ Upstream commit cdfaf4752e6915a4b455ad4400133e540e4dc965 ] If of_device_get_match_data() return NULL, then null pointer dereference occurs in s5p_mfc_init_pm(). The patch adds checking if dev->variant is NULL. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Nadezda Lutovinova Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index f8a5ed6bb9d7a..9faecd049002f 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1284,6 +1284,10 @@ static int s5p_mfc_probe(struct platform_device *pdev) } dev->variant = of_device_get_match_data(&pdev->dev); + if (!dev->variant) { + dev_err(&pdev->dev, "Failed to get device MFC hardware variant information\n"); + return -ENOENT; + } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dev->regs_base = devm_ioremap_resource(&pdev->dev, res); -- 2.33.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6489C433F5 for ; Tue, 9 Nov 2021 01:27:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B57C60F6E for ; Tue, 9 Nov 2021 01:27:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B57C60F6E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sc7nOT57VIDfZ5b2auOtxXADXbjQnvAmnhLhfxue3C0=; b=vB2BTdRO2LzfyZ cFtzY+5DJpGmeG4VS7WrcB6NZmoUUzW/YtmfcpB1GN+vy1ZrpUrTToX3ikxNgnIS64PMHsxeG4hvm 7PsH78ZDsCwaMZ6kAfFFYbivd6yBYqgrmxO1C+BbmnaM+ydmOb+bDbt12DujQJiyd9/gidQWlefJb +nC3R13UQKA68ocFb1H23oEbG3c3n9DZjPUT5Bk4mCJrxor0/3pqPLr/PF3fUmYOevLv0jP4N35PZ l/yrW4yrGZyIiuO6a6lkDQiQYj26FykGSuPXDjTqHI7I4nCOTiMkg3BD1SdKQJYAS4fVq6ZoKTInx SKgLE35VQ9asfUrM1Kqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFtL-000K2B-9A; Tue, 09 Nov 2021 01:25:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkFZY-000Chg-5h for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 01:05:14 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CB32761A7F; Tue, 9 Nov 2021 01:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636419911; bh=yATXGdaUzZgEZsx70fgb68NdEgPLCYLLlzykAUdNEcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S3N4n6cu9D3xQrERafZPllKFwj5zJ4kaKt2vK4nQ9+bLrALk2qxT1yleEUawjECIg gphgfDAizfPgTxjN+1rusYOWbkyBn5LbS4CHKIR3fSFMBhOrK71eJUlWE1EyNNI9Ee Qv3G0L5RqmJyISBRX9upt3309rCPQHL1qOoiULfUaXmyX8OCDUP2M/KXgoakV3lSo2 UxNQb4+mb/EdT9mE5hYCmJc0KDfzOV9W0ZVgzyfoCrMGmXOJ87qlvF7TJwcP5PWKAU 4MpcETP7NVJ8FuELHXpt8CyyfVNisCNrbCa3FD0zbMW4uNEdnoQo1fEyPFYh0M53La sZcONrvbhyPVg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nadezda Lutovinova , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , a.hajda@samsung.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 26/74] media: s5p-mfc: Add checking to s5p_mfc_probe(). Date: Mon, 8 Nov 2021 12:48:53 -0500 Message-Id: <20211108174942.1189927-26-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211108174942.1189927-1-sashal@kernel.org> References: <20211108174942.1189927-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_170512_328602_E41D4E73 X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nadezda Lutovinova [ Upstream commit cdfaf4752e6915a4b455ad4400133e540e4dc965 ] If of_device_get_match_data() return NULL, then null pointer dereference occurs in s5p_mfc_init_pm(). The patch adds checking if dev->variant is NULL. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Nadezda Lutovinova Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index f8a5ed6bb9d7a..9faecd049002f 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1284,6 +1284,10 @@ static int s5p_mfc_probe(struct platform_device *pdev) } dev->variant = of_device_get_match_data(&pdev->dev); + if (!dev->variant) { + dev_err(&pdev->dev, "Failed to get device MFC hardware variant information\n"); + return -ENOENT; + } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dev->regs_base = devm_ioremap_resource(&pdev->dev, res); -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel