Re: [PATCH][next] ftrace: Fix -Wcast-function-type warnings on powerpc64

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5487 bytes --]

Hi "Gustavo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on v5.15]
[cannot apply to rostedt-trace/for-next linux/master linus/master next-20211108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gustavo-A-R-Silva/ftrace-Fix-Wcast-function-type-warnings-on-powerpc64/20211005-133606
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 41100833cdd8b1bef363b81a6482d74711c116ad
config: xtensa-randconfig-r013-20211004 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9c10c0713155955bf1170eea3904cfcfb6d2d832
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Gustavo-A-R-Silva/ftrace-Fix-Wcast-function-type-warnings-on-powerpc64/20211005-133606
        git checkout 9c10c0713155955bf1170eea3904cfcfb6d2d832
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/trace/ftrace.c:586:5: warning: no previous prototype for 'ftrace_profile_pages_init' [-Wmissing-prototypes]
     586 | int ftrace_profile_pages_init(struct ftrace_profile_stat *stat)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/trace/ftrace.c:870:27: error: initialization of 'void (*)(long unsigned int,  long unsigned int)' from incompatible pointer type 'void (*)(long unsigned int,  long unsigned int,  struct ftrace_ops *, struct ftrace_regs *)' [-Werror=incompatible-pointer-types]
     870 |         .func           = function_profile_call,
         |                           ^~~~~~~~~~~~~~~~~~~~~
   kernel/trace/ftrace.c:870:27: note: (near initialization for 'ftrace_profile_ops.func')
   kernel/trace/ftrace.c:6925:35: error: initialization of 'void (*)(long unsigned int,  long unsigned int)' from incompatible pointer type 'void (*)(long unsigned int,  long unsigned int,  struct ftrace_ops *, struct ftrace_regs *)' [-Werror=incompatible-pointer-types]
    6925 |         .func                   = ftrace_stub,
         |                                   ^~~~~~~~~~~
   kernel/trace/ftrace.c:6925:35: note: (near initialization for 'global_ops.func')
   cc1: some warnings being treated as errors
--
   kernel/trace/trace.c: In function 'trace_check_vprintf':
   kernel/trace/trace.c:3827:17: warning: function 'trace_check_vprintf' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    3827 |                 trace_seq_vprintf(&iter->seq, iter->fmt, ap);
         |                 ^~~~~~~~~~~~~~~~~
   kernel/trace/trace.c:3882:17: warning: function 'trace_check_vprintf' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    3882 |                 trace_seq_vprintf(&iter->seq, p, ap);
         |                 ^~~~~~~~~~~~~~~~~
   In file included from kernel/trace/trace.c:8605:
   kernel/trace/trace_selftest.c: At top level:
>> kernel/trace/trace_selftest.c:562:27: error: initialization of 'void (*)(long unsigned int,  long unsigned int)' from incompatible pointer type 'void (*)(long unsigned int,  long unsigned int,  struct ftrace_ops *, struct ftrace_regs *)' [-Werror=incompatible-pointer-types]
     562 |         .func           = trace_selftest_test_regs_func,
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/trace/trace_selftest.c:562:27: note: (near initialization for 'test_regs_probe.func')
   kernel/trace/trace_selftest.c: In function 'trace_selftest_function_regs':
   kernel/trace/trace_selftest.c:571:13: warning: variable 'len' set but not used [-Wunused-but-set-variable]
     571 |         int len;
         |             ^~~
   cc1: some warnings being treated as errors


vim +870 kernel/trace/ftrace.c

0706f1c48ca8a7 Steven Rostedt           2009-03-23  863  
0706f1c48ca8a7 Steven Rostedt           2009-03-23  864  static void unregister_ftrace_profiler(void)
0706f1c48ca8a7 Steven Rostedt           2009-03-23  865  {
688f7089d8851b Steven Rostedt (VMware   2018-11-15  866) 	unregister_ftrace_graph(&fprofiler_ops);
0706f1c48ca8a7 Steven Rostedt           2009-03-23  867  }
0706f1c48ca8a7 Steven Rostedt           2009-03-23  868  #else
bd38c0e6f98326 Paul McQuade             2011-05-31  869  static struct ftrace_ops ftrace_profile_ops __read_mostly = {
bac429f037f1a5 Steven Rostedt           2009-03-20 @870  	.func		= function_profile_call,
a25d036d939a30 Steven Rostedt (VMware   2020-11-05  871) 	.flags		= FTRACE_OPS_FL_INITIALIZED,
33b7f99cf003ca Steven Rostedt (Red Hat  2014-08-15  872) 	INIT_OPS_HASH(ftrace_profile_ops)
bac429f037f1a5 Steven Rostedt           2009-03-20  873  };
bac429f037f1a5 Steven Rostedt           2009-03-20  874  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31229 bytes --]