From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/ptp/ptp_ocp.c:1845:2: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-an...
Date: Tue, 09 Nov 2021 05:12:20 +0800 [thread overview]
Message-ID: <202111090515.RpYacDGC-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 18635 bytes --]
CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Jonathan Lemon <jonathan.lemon@gmail.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e851dfae4371d3c751f1e18e8eb5eba993de1467
commit: f67bf662d2cffa2ddf19ffa23381d49c9cffd783 ptp: ocp: Add debugfs entry for timecard
date: 8 weeks ago
:::::: branch date: 4 hours ago
:::::: commit date: 8 weeks ago
config: i386-randconfig-c001-20211012 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c3dcf39554dbea780d6cb7e12239451ba47a2668)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f67bf662d2cffa2ddf19ffa23381d49c9cffd783
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout f67bf662d2cffa2ddf19ffa23381d49c9cffd783
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/raw/nand_base.c:5416:7: note: 'ret' is 0
if (ret)
^~~
drivers/mtd/nand/raw/nand_base.c:5416:3: note: Taking false branch
if (ret)
^
drivers/mtd/nand/raw/nand_base.c:5419:19: note: The right operand of '!=' is a garbage value
if (nand_maf_id != id[0] || nand_dev_id != id[1]) {
^ ~~~~~
drivers/mtd/nand/raw/nand_base.c:5613:22: warning: Value stored to 'nanddev' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
struct nand_device *nanddev = mtd_to_nanddev(mtd);
^~~~~~~ ~~~~~~~~~~~~~~~~~~~
drivers/mtd/nand/raw/nand_base.c:5613:22: note: Value stored to 'nanddev' during its initialization is never read
struct nand_device *nanddev = mtd_to_nanddev(mtd);
^~~~~~~ ~~~~~~~~~~~~~~~~~~~
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
9 warnings generated.
Suppressed 9 warnings (9 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
9 warnings generated.
Suppressed 9 warnings (9 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
9 warnings generated.
Suppressed 9 warnings (9 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
11 warnings generated.
Suppressed 11 warnings (9 in non-user code, 2 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
20 warnings generated.
drivers/power/supply/twl4030_charger.c:364:2: warning: Value stored to 'cur_reg' is never read [clang-analyzer-deadcode.DeadStores]
cur_reg |= oldreg << 8;
^ ~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:364:2: note: Value stored to 'cur_reg' is never read
cur_reg |= oldreg << 8;
^ ~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:383:3: warning: Value stored to 'status' is never read [clang-analyzer-deadcode.DeadStores]
status = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:383:3: note: Value stored to 'status' is never read
status = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:412:2: warning: Value stored to 'curr' is never read [clang-analyzer-deadcode.DeadStores]
curr = twl4030_charger_get_current();
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:412:2: note: Value stored to 'curr' is never read
curr = twl4030_charger_get_current();
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:467:4: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
ret = twl4030_clear_set_boot_bci(0, TWL4030_BCIAUTOUSB);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:467:4: note: Value stored to 'ret' is never read
ret = twl4030_clear_set_boot_bci(0, TWL4030_BCIAUTOUSB);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:487:4: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0x33,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:487:4: note: Value stored to 'ret' is never read
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0x33,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:490:4: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0x2a,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:490:4: note: Value stored to 'ret' is never read
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0x2a,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:493:4: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0x26,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:493:4: note: Value stored to 'ret' is never read
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0x26,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:496:4: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0xf3,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:496:4: note: Value stored to 'ret' is never read
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0xf3,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:499:4: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0x9c,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/power/supply/twl4030_charger.c:499:4: note: Value stored to 'ret' is never read
ret = twl_i2c_write_u8(TWL_MODULE_MAIN_CHARGE, 0x9c,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 11 warnings (9 in non-user code, 2 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
10 warnings generated.
Suppressed 10 warnings (10 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
10 warnings generated.
Suppressed 10 warnings (10 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
10 warnings generated.
Suppressed 10 warnings (10 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
19 warnings generated.
>> drivers/ptp/ptp_ocp.c:1845:2: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy]
strcpy(ans, def);
^~~~~~
drivers/ptp/ptp_ocp.c:1845:2: note: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
strcpy(ans, def);
^~~~~~
>> drivers/ptp/ptp_ocp.c:1849:3: warning: Value stored to 'ans' is never read [clang-analyzer-deadcode.DeadStores]
ans += sprintf(ans, "%s ", sec);
^ ~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:1849:3: note: Value stored to 'ans' is never read
ans += sprintf(ans, "%s ", sec);
^ ~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:1975:3: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy]
strcpy(buf, "unknown");
^~~~~~
drivers/ptp/ptp_ocp.c:1975:3: note: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
strcpy(buf, "unknown");
^~~~~~
Suppressed 16 warnings (16 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
6 warnings generated.
Suppressed 6 warnings (6 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
10 warnings generated.
Suppressed 10 warnings (10 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
11 warnings generated.
Suppressed 11 warnings (10 in non-user code, 1 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
drivers/comedi/drivers/pcmmio.c:578:2: warning: Value stored to 'val' is never read [clang-analyzer-deadcode.DeadStores]
val |= inb(iobase + PCMMIO_AI_MSB_REG) << 8;
^
drivers/comedi/drivers/pcmmio.c:578:2: note: Value stored to 'val' is never read
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
drivers/comedi/drivers/addi_apci_3xxx.c:745:3: warning: Value stored to 'val' is never read [clang-analyzer-deadcode.DeadStores]
val = readl(dev->mmio + 28);
^
drivers/comedi/drivers/addi_apci_3xxx.c:745:3: note: Value stored to 'val' is never read
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
10 warnings generated.
drivers/gpu/drm/i915/gt/uc/intel_huc.c:93:2: warning: Value stored to 'copied' is never read [clang-analyzer-deadcode.DeadStores]
copied = intel_uc_fw_copy_rsa(&huc->fw, vaddr, vma->size);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/uc/intel_huc.c:93:2: note: Value stored to 'copied' is never read
copied = intel_uc_fw_copy_rsa(&huc->fw, vaddr, vma->size);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 9 warnings (9 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
Suppressed 8 warnings (8 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
17 warnings generated.
Suppressed 17 warnings (17 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
9 warnings generated.
vim +1845 drivers/ptp/ptp_ocp.c
f67bf662d2cffa Jonathan Lemon 2021-09-14 1838
f67bf662d2cffa Jonathan Lemon 2021-09-14 1839 static void
f67bf662d2cffa Jonathan Lemon 2021-09-14 1840 gpio_multi_map(char *buf, u32 gpio, u32 bit,
f67bf662d2cffa Jonathan Lemon 2021-09-14 1841 const char *pri, const char *sec, const char *def)
f67bf662d2cffa Jonathan Lemon 2021-09-14 1842 {
f67bf662d2cffa Jonathan Lemon 2021-09-14 1843 char *ans = buf;
f67bf662d2cffa Jonathan Lemon 2021-09-14 1844
f67bf662d2cffa Jonathan Lemon 2021-09-14 @1845 strcpy(ans, def);
f67bf662d2cffa Jonathan Lemon 2021-09-14 1846 if (gpio & (1 << bit))
f67bf662d2cffa Jonathan Lemon 2021-09-14 1847 ans += sprintf(ans, "%s ", pri);
f67bf662d2cffa Jonathan Lemon 2021-09-14 1848 if (gpio & (1 << (bit + 16)))
f67bf662d2cffa Jonathan Lemon 2021-09-14 @1849 ans += sprintf(ans, "%s ", sec);
f67bf662d2cffa Jonathan Lemon 2021-09-14 1850 }
f67bf662d2cffa Jonathan Lemon 2021-09-14 1851
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38271 bytes --]
next reply other threads:[~2021-11-08 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 21:12 kernel test robot [this message]
2022-01-03 18:29 drivers/ptp/ptp_ocp.c:1845:2: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-an kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111090515.RpYacDGC-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.