From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA3FCC433EF for ; Tue, 9 Nov 2021 07:55:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8935E610C8 for ; Tue, 9 Nov 2021 07:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243803AbhKIH6i (ORCPT ); Tue, 9 Nov 2021 02:58:38 -0500 Received: from verein.lst.de ([213.95.11.211]:48900 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243795AbhKIH6d (ORCPT ); Tue, 9 Nov 2021 02:58:33 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 9444E68AA6; Tue, 9 Nov 2021 08:55:45 +0100 (CET) Date: Tue, 9 Nov 2021 08:55:45 +0100 From: Christoph Hellwig To: Joonas Lahtinen Cc: Christoph Hellwig , Jani Nikula , Rodrigo Vivi , Zhenyu Wang , Zhi Wang , Jason Gunthorpe , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/29] drm/i915/gvt: integrate into the main Makefile Message-ID: <20211109075545.GA27339@lst.de> References: <20211102070601.155501-1-hch@lst.de> <20211102070601.155501-3-hch@lst.de> <163602902009.4807.3745093259631583283@jlahtine-mobl.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163602902009.4807.3745093259631583283@jlahtine-mobl.ger.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 04, 2021 at 02:30:20PM +0200, Joonas Lahtinen wrote: > Quoting Christoph Hellwig (2021-11-02 09:05:34) > > Remove the separately included Makefile and just use the relative > > reference from the main i915 Makefile as for source files in other > > subdirectories. > > The thinking behind the split is to avoid any merge conflicts as the > gvt/ subdirectory is handled through separate pull request flow and > are note part of drm-tip. > > The other subdirectories are part of drm-intel-next/drm-intel-gt-next > and are part of drm-tip. > > So I would rather still see the Makefile live in gvt/ directory. So the reason I did this is because the include broke doing nice little subdir makes or me. It would also require renaming the kvmgvt.c source file later on. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A240C433EF for ; Tue, 9 Nov 2021 07:55:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 977CC610F8 for ; Tue, 9 Nov 2021 07:55:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 977CC610F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CECC16E580; Tue, 9 Nov 2021 07:55:49 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A9A66E584; Tue, 9 Nov 2021 07:55:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 9444E68AA6; Tue, 9 Nov 2021 08:55:45 +0100 (CET) Date: Tue, 9 Nov 2021 08:55:45 +0100 From: Christoph Hellwig To: Joonas Lahtinen Message-ID: <20211109075545.GA27339@lst.de> References: <20211102070601.155501-1-hch@lst.de> <20211102070601.155501-3-hch@lst.de> <163602902009.4807.3745093259631583283@jlahtine-mobl.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163602902009.4807.3745093259631583283@jlahtine-mobl.ger.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Intel-gfx] [PATCH 02/29] drm/i915/gvt: integrate into the main Makefile X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , intel-gvt-dev@lists.freedesktop.org, Christoph Hellwig Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Nov 04, 2021 at 02:30:20PM +0200, Joonas Lahtinen wrote: > Quoting Christoph Hellwig (2021-11-02 09:05:34) > > Remove the separately included Makefile and just use the relative > > reference from the main i915 Makefile as for source files in other > > subdirectories. > > The thinking behind the split is to avoid any merge conflicts as the > gvt/ subdirectory is handled through separate pull request flow and > are note part of drm-tip. > > The other subdirectories are part of drm-intel-next/drm-intel-gt-next > and are part of drm-tip. > > So I would rather still see the Makefile live in gvt/ directory. So the reason I did this is because the include broke doing nice little subdir makes or me. It would also require renaming the kvmgvt.c source file later on.