From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0542C4332F for ; Tue, 9 Nov 2021 17:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC39461186 for ; Tue, 9 Nov 2021 17:03:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240695AbhKIRGM (ORCPT ); Tue, 9 Nov 2021 12:06:12 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4077 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239427AbhKIRGK (ORCPT ); Tue, 9 Nov 2021 12:06:10 -0500 Received: from fraeml713-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HpZ6w6wh2z67gk4; Wed, 10 Nov 2021 01:03:04 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml713-chm.china.huawei.com (10.206.15.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 9 Nov 2021 18:03:21 +0100 Received: from localhost (10.202.226.41) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.15; Tue, 9 Nov 2021 17:03:21 +0000 Date: Tue, 9 Nov 2021 17:03:20 +0000 From: Jonathan Cameron To: Andrea Merello CC: Jonathan Cameron , Mauro Carvalho Chehab , linux-iio , linux-kernel , devicetree , Lars-Peter Clausen , "Rob Herring" , Andy Shevchenko , Matt Ranostay , Alexandru Ardelean , Jacopo Mondi , Andrea Merello Subject: Re: [v2 03/10] iio: document euler angles modifiers Message-ID: <20211109170320.0000597b@Huawei.com> In-Reply-To: References: <20210715141742.15072-1-andrea.merello@gmail.com> <20211028101840.24632-1-andrea.merello@gmail.com> <20211028101840.24632-4-andrea.merello@gmail.com> <20211028114154.19e596fc@jic23-huawei> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.41] X-ClientProxiedBy: lhreml704-chm.china.huawei.com (10.201.108.53) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Nov 2021 09:15:09 +0100 Andrea Merello wrote: > Il giorno gio 28 ott 2021 alle ore 12:37 Jonathan Cameron > ha scritto: > > > > On Thu, 28 Oct 2021 12:18:33 +0200 > > Andrea Merello wrote: > > > > > This patch introduces ABI documentation for new modifiers used for > > > reporting rotations expressed as euler angles (i.e. yaw, pitch, roll). > > > > > > Signed-off-by: Andrea Merello > > > --- > > > Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio > > > index 5147a00bf24a..f0adc2c817bd 100644 > > > --- a/Documentation/ABI/testing/sysfs-bus-iio > > > +++ b/Documentation/ABI/testing/sysfs-bus-iio > > > @@ -1965,3 +1965,11 @@ KernelVersion: 5.15 > > > Contact: linux-iio@vger.kernel.org > > > Description: > > > Raw (unscaled) linear acceleration readings. > > > + > > > +What: /sys/bus/iio/devices/iio:deviceX/in_rot_yaw_raw > > > +What: /sys/bus/iio/devices/iio:deviceX/in_rot_pitch_raw > > > +What: /sys/bus/iio/devices/iio:deviceX/in_rot_roll_raw > > > +KernelVersion: 5.15 > > > +Contact: linux-iio@vger.kernel.org > > > +Description: > > > + Raw (unscaled) euler angles readings. > > Any _raw entry should also include what the units are after application of > > offset and scale. Or you could just add this as more info to the in_rot_raw > > block as an extra sentence explaining that they are euler angles. > > That will lose the 'KernelVersion' information but honestly I'm not sure we > > care that much about that. > > I'm unsure which block you are talking about: I see there are two > blocks that refer to rot things: in_rot_quaternion_raw and > in_rot_from_north_xxx_raw. > > Looking at the 1st one description, it looks very specific to > quaternions to me; the 2nd seems very specific to its own thing, > whatever it is.. So I would just add the missing information (unit) in > the new block just being introduced, if this is ok for you. Or am I > missing some other block in which I could coalesce this new euler > thing? Good point, not sure what I was thinking. There isn't a sensible block to add this to. So just add the info about units. Jonathan > > > > Jonathan > > > >