From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 151EBC433EF for ; Tue, 9 Nov 2021 18:18:41 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7088760232 for ; Tue, 9 Nov 2021 18:18:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7088760232 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 016BB83968; Tue, 9 Nov 2021 19:18:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="DLzkL0gB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 837608396B; Tue, 9 Nov 2021 19:18:35 +0100 (CET) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BCF4483944 for ; Tue, 9 Nov 2021 19:18:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id v4so17779637qtw.8 for ; Tue, 09 Nov 2021 10:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YfmP+BFiqgGJzbYgsV5P64CUQNuk6AjLC6sG34bgxuA=; b=DLzkL0gBkEbQEQGugmE0H1Y5b8VpE82RxoJvOcNX54jO3wFOAr1qrYdC/h+e4SMK9P y4VJPEPv/UXNZWylWbtv/6k6z8MfJxzrMVo7kshdXlF+bvTiWppkIgWGJcfnjBfNmXeJ fOe5vGYo7Bo7KAqgLt2OcE2tb/OvTHx2LSly0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YfmP+BFiqgGJzbYgsV5P64CUQNuk6AjLC6sG34bgxuA=; b=s1XZ14UzfE3YGAJtDlZTBPCqTXldaWbN7D4qPjd5a0J7WI+VMpGJwDF+JJk6Ag+rpQ RSW/2yDgEjwTFxHjz+nQtREW5ORNUqjqMCq9zWv0mq5Vf7Skjphelc/MJDgsaR5ORt1i KIpBa5LFltan3IWMlRDa360m6nC2Gci3BV4SW6wGzTWWXwVfR5U3EdpXn8a8T8D0zFmf xQFn5tN3RhKWlF7IVW16ROOc0mcwot6H5LwP4dn1XY945yBrrzcdstBBqwueRPDK2VF4 2PLtwayzVhS6yTTIuiI2BthzA1VmXMJPTCa5z/QsDFkgVq3dIw0+ksliU8xwGb0dRV16 C8jA== X-Gm-Message-State: AOAM531I7N0zpz6wzoeY25p4hUtgG8xs6Vod/ffyN9uXWNDak5V+E5Ud /nU/sFHk8rKpZjhfAAJzb3xOXQ== X-Google-Smtp-Source: ABdhPJzlavUqWfMx0NgQA2YnQe3wnRYlJXBELX4YR58Qg3QAl90/5Lv+7hX8xVyxHfFMe9wvz5DWWw== X-Received: by 2002:ac8:7d09:: with SMTP id g9mr10784621qtb.241.1636481910563; Tue, 09 Nov 2021 10:18:30 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-74ad-b320-81ce-4688.res6.spectrum.com. [2603:6081:7b01:cbda:74ad:b320:81ce:4688]) by smtp.gmail.com with ESMTPSA id n13sm1493071qtx.68.2021.11.09.10.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 10:18:30 -0800 (PST) Date: Tue, 9 Nov 2021 13:18:28 -0500 From: Tom Rini To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, Andre Przywara , Heinrich Schuchardt , Alexander Graf Subject: Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices() Message-ID: <20211109181828.GX24579@bill-the-cat> References: <20211109101901.24015-1-heinrich.schuchardt@canonical.com> <20211109101901.24015-2-heinrich.schuchardt@canonical.com> <20211109175526.GW24579@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eegVCDMvnUS/vTOg" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --eegVCDMvnUS/vTOg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 09, 2021 at 07:15:10PM +0100, Heinrich Schuchardt wrote: > On 11/9/21 18:55, Tom Rini wrote: > > On Tue, Nov 09, 2021 at 11:19:01AM +0100, Heinrich Schuchardt wrote: > >=20 > > > The UEFI specification requires for ExitBootServices() that "the boot > > > services watchdog timer is disabled". We already disable the software > > > watchdog. We should additionally disable the hardware watchdogs. > > >=20 > > > Reported-by: Andre Przywara > > > Signed-off-by: Heinrich Schuchardt > >=20 > > Let me start by saying thank you for bringing this up with UEFI folks as > > well. To be clear, for right now I would much rather see U-Boot > > continue to be non-complaint with UEFI in this regard and assume that a > > running watchdog will be able to be handled by the running OS (which > > tends to be the case, but not always as sunxi has just shown) than to > > attempt to be complaint with the spec as it stands now as I am hopeful > > that we can get this case handled in a way that matches long standing > > industry practice. > >=20 >=20 > We have either merge this patch or >=20 > [1/1] watchdog: don't autostart watchdog on Sunxi boards > https://patchwork.ozlabs.org/project/uboot/patch/20211105183431.117221-1-= heinrich.schuchardt@canonical.com/ >=20 > or we will be breaking boot processes that have been running up to now. >=20 > As Sunxi watchdogs were only enabled by a recent patch disabling autostart > should not cause any harm. Yes, I was expecting a PR from Andre in my inbox this morning with your patch, as he had said he would apply it. I'm just assuming now I got a bit ahead of myself with expecting it so quickly. --=20 Tom --eegVCDMvnUS/vTOg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGKu3AACgkQFHw5/5Y0 tyz+uQv+NrrR0r66PWTivO6ngaCVi1IsKEwRNCWKdFzNps3xE4vpeGlX42j7yhbY 8Rbg4P4B/sBq16PFnZZSKc3GrPhcooiDZXQlLH5PMmqecqhH/D2MeeYNO3asAh0o QTBYmos3MNkGumqgP2fc0owP5vGAqbr5IE6QBxBncydxrxE+LJhqYSKeLisfbDPp N0KKJ+TwJeHrXxCHPdfFuGO1ymLp1Cn9gOdIuAVW3UQ1wyIIO01ku/xz3KfXIB7G TAuakkAOgeIE8UKXLIttInDbad6z3ksT/S8xYbYswAOgMkbOnoAAYpzqli/p+6ar 9hHgH+O8dSfDjPcbWprPcPpg9bthu+EQ9jJwMLTMETxhY0bUGY4/dXDx9zcg6Cdl 2ykuf4+1pWAI1iVmwWeEe3SeRvMbjDMlLoBmPNj5i+SQXZ5bw3UTv3U+fYs9WIbX zZYQPpSkqB/4Wmx8J0/icd+D/1ShPunTZHMvNqkiKndPn1QiPIM7eqxInm7MAnQg xzSr9kIB =pfIJ -----END PGP SIGNATURE----- --eegVCDMvnUS/vTOg--