All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Babu Moger <babu.moger@amd.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	clemens@ladisch.de, jdelvare@suse.com, bhelgaas@google.com,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/3] hwmon: (k10temp) Remove unused definitions
Date: Tue, 9 Nov 2021 12:29:43 -0800	[thread overview]
Message-ID: <20211109202943.GA3693009@roeck-us.net> (raw)
In-Reply-To: <163640828776.955062.15863375803675701204.stgit@bmoger-ubuntu>

On Mon, Nov 08, 2021 at 03:51:27PM -0600, Babu Moger wrote:
> Usage of these definitions were removed after the commit 0a4e668b5d52
> ("hwmon: (k10temp) Remove support for displaying voltage and current on Zen CPUs").
> So, cleanup them up.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/k10temp.c |   20 --------------------
>  1 file changed, 20 deletions(-)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 3618a924e78e..662bad7ed0a2 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -76,26 +76,6 @@ static DEFINE_MUTEX(nb_smu_ind_mutex);
>  #define ZEN_CUR_TEMP_SHIFT			21
>  #define ZEN_CUR_TEMP_RANGE_SEL_MASK		BIT(19)
>  
> -#define ZEN_SVI_BASE				0x0005A000
> -
> -/* F17h thermal registers through SMN */
> -#define F17H_M01H_SVI_TEL_PLANE0		(ZEN_SVI_BASE + 0xc)
> -#define F17H_M01H_SVI_TEL_PLANE1		(ZEN_SVI_BASE + 0x10)
> -#define F17H_M31H_SVI_TEL_PLANE0		(ZEN_SVI_BASE + 0x14)
> -#define F17H_M31H_SVI_TEL_PLANE1		(ZEN_SVI_BASE + 0x10)
> -
> -#define F17H_M01H_CFACTOR_ICORE			1000000	/* 1A / LSB	*/
> -#define F17H_M01H_CFACTOR_ISOC			250000	/* 0.25A / LSB	*/
> -#define F17H_M31H_CFACTOR_ICORE			1000000	/* 1A / LSB	*/
> -#define F17H_M31H_CFACTOR_ISOC			310000	/* 0.31A / LSB	*/
> -
> -/* F19h thermal registers through SMN */
> -#define F19H_M01_SVI_TEL_PLANE0			(ZEN_SVI_BASE + 0x14)
> -#define F19H_M01_SVI_TEL_PLANE1			(ZEN_SVI_BASE + 0x10)
> -
> -#define F19H_M01H_CFACTOR_ICORE			1000000	/* 1A / LSB	*/
> -#define F19H_M01H_CFACTOR_ISOC			310000	/* 0.31A / LSB	*/
> -
>  struct k10temp_data {
>  	struct pci_dev *pdev;
>  	void (*read_htcreg)(struct pci_dev *pdev, u32 *regval);

  reply	other threads:[~2021-11-09 20:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 21:51 [PATCH 0/3] k10temp/amd_nb: Add support for AMD Family 19h Models 10h-1Fh and A0h-AFh Babu Moger
2021-11-08 21:51 ` [PATCH 1/3] x86/amd_nb: Add AMD Family 19h Models (10h-1Fh) and (A0h-AFh) PCI IDs Babu Moger
2021-11-09  0:10   ` Krzysztof Wilczyński
2021-11-09 14:59     ` Babu Moger
2021-11-09  9:22   ` Borislav Petkov
2021-11-09 15:36   ` Bjorn Helgaas
2021-11-09 20:28   ` Guenter Roeck
2021-11-08 21:51 ` [PATCH 2/3] hwmon: (k10temp) Remove unused definitions Babu Moger
2021-11-09 20:29   ` Guenter Roeck [this message]
2021-11-08 21:51 ` [PATCH 3/3] hwmon: (k10temp) Add support for AMD Family 19h Models 10h-1Fh and A0h-AFh Babu Moger
2021-11-09 20:30   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211109202943.GA3693009@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=babu.moger@amd.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=clemens@ladisch.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.