From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B73F8C433F5 for ; Tue, 9 Nov 2021 21:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9ACE561178 for ; Tue, 9 Nov 2021 21:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244438AbhKIV4F (ORCPT ); Tue, 9 Nov 2021 16:56:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244174AbhKIV4B (ORCPT ); Tue, 9 Nov 2021 16:56:01 -0500 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92DBFC061764 for ; Tue, 9 Nov 2021 13:53:14 -0800 (PST) Received: by mail-pg1-x54a.google.com with SMTP id h35-20020a63f923000000b002d5262fdfc4so306521pgi.2 for ; Tue, 09 Nov 2021 13:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=+orjKM59Ip1jg3YDIyso53FFr4R86deutg9aS1RmPgU=; b=OoPhJmTDncIYB5udY0KMuU/k/gZGETWsIa26KBZMW9/bcpA5X897kzrHCPRWTVyRuJ L0tKjpaYFpQjFVgwR85GA4+DcCNr643jeuHzVi9cgeYbc2eVUTReHdLQhhYt4OTBE3HL eu9LG2p1UhwaIgNMBZmowzdvSWvpo6MjmLXEpw9Cr8UH15R9CE91L30ZBXcgo55NsxL8 7oDE/iixLxGHjcCKAGagpY99Hx/tQ4wtWcXGVNKUp6T/w39cOmwSrLiswVLEfalroDEZ dPIS5PAfca7G7Ef0kpKiAdKRc2qfNCgBCaiTrdH8heVeXOAnbVyK7sIEb0gqBukYkgwh HVnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=+orjKM59Ip1jg3YDIyso53FFr4R86deutg9aS1RmPgU=; b=M9Dh1253N9cG8ArMt9J4C0XPaBQWC64SwzPpFdhhe8fgfkd+PKx6tECvL+v4yNawr2 4cfUooJWtwPGHFoPjB++kCFwN4bAnWnasFFXLJ3GSOj9zu5hg9r3Wj04WTLql2IzFPmq 4b/UGYftjp14hDw4V6TwgezKcmX28O+oGyCu0VmVVfRZGyA8XMrPG21N1YWtk4epGaKG 5K9N/E/FBZQwXd3U7bzWjXr02UlW6NT5nHrU/Q/4Eq+7Y+C0tm/GwXehzyxXKH0WuKWm VursMJ9QL7wYcS8BS3qvI/LZlP6JXS8mNCdP3NvUEUxDvLXiTXz82h4fn7YPOKdLz8kp fdqw== X-Gm-Message-State: AOAM533rznBkATQ1a13FUoWHHlQqjVdK79qxzSzfAHN+pHOIFtR6K3RA JrP8OV7VvvLPFZ3NU1AgHQPIQX2n9HI= X-Google-Smtp-Source: ABdhPJzJHyfzMV92VSzp7DtPIHOhADA+GIEVQO4/Wv8/arTXrYXbLFCY7EloFUKfE3GXC/TAPq+gPV3EqlE= X-Received: from seanjc.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3e5]) (user=seanjc job=sendgmr) by 2002:a62:3306:0:b0:480:f89c:c251 with SMTP id z6-20020a623306000000b00480f89cc251mr11901402pfz.74.1636494794010; Tue, 09 Nov 2021 13:53:14 -0800 (PST) Reply-To: Sean Christopherson Date: Tue, 9 Nov 2021 21:50:56 +0000 In-Reply-To: <20211109215101.2211373-1-seanjc@google.com> Message-Id: <20211109215101.2211373-2-seanjc@google.com> Mime-Version: 1.0 References: <20211109215101.2211373-1-seanjc@google.com> X-Mailer: git-send-email 2.34.0.rc0.344.g81b53c2807-goog Subject: [PATCH 1/6] KVM: SEV: Disallow COPY_ENC_CONTEXT_FROM if target has created vCPUs From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Gonda , Marc Orr , Nathan Tempelman , Brijesh Singh , Tom Lendacky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reject COPY_ENC_CONTEXT_FROM if the destination VM has created vCPUs. KVM relies on SEV activation to occur before vCPUs are created, e.g. to set VMCB flags and intercepts correctly. Fixes: 54526d1fd593 ("KVM: x86: Support KVM VMs sharing SEV context") Cc: stable@vger.kernel.org Cc: Peter Gonda Cc: Marc Orr Cc: Sean Christopherson Cc: Nathan Tempelman Cc: Brijesh Singh Cc: Tom Lendacky Signed-off-by: Sean Christopherson --- arch/x86/kvm/svm/sev.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index 3e2769855e51..eeec499e4372 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -1775,7 +1775,12 @@ int svm_vm_copy_asid_from(struct kvm *kvm, unsigned int source_fd) mutex_unlock(&source_kvm->lock); mutex_lock(&kvm->lock); - if (sev_guest(kvm)) { + /* + * Disallow out-of-band SEV/SEV-ES init if the target is already an + * SEV guest, or if vCPUs have been created. KVM relies on vCPUs being + * created after SEV/SEV-ES initialization, e.g. to init intercepts. + */ + if (sev_guest(kvm) || kvm->created_vcpus) { ret = -EINVAL; goto e_mirror_unlock; } -- 2.34.0.rc0.344.g81b53c2807-goog