From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEF10C433F5 for ; Thu, 11 Nov 2021 12:54:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEBE5611C9 for ; Thu, 11 Nov 2021 12:54:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DEBE5611C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2817983A13; Thu, 11 Nov 2021 13:54:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="emAuiVCH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BC3A483A20; Thu, 11 Nov 2021 13:54:50 +0100 (CET) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1BAC783A07 for ; Thu, 11 Nov 2021 13:54:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from mwalle01.kontron.local. (unknown [213.135.10.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id A0DE122236; Thu, 11 Nov 2021 13:54:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1636635286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OLl4iwEsIGlRM9HAV0sjq/3AIAZop1x14JsFvyPPb44=; b=emAuiVCHAK210sBQVuRyZYCoggboIwOuj0LgLNk6kPA7ERHrzzYJYuySO9/6BT591pdevR 8iEjMXTMC9XW7OaY9UJob54wh9GBtwlvhOSVhNnGqb+6FqMNIWi1/kSMIMCSmrQRxpbcvO RaxxCWiHQyoSamu7tEjn/icYblSSgQg= From: Michael Walle To: padmarao.b@gmail.com Cc: anup.patel@wdc.com, atish.patra@wdc.com, bmeng.cn@gmail.com, conor.dooley@microchip.com, cyril.jean@microchip.com, daire.mcnamara@microchip.com, hs@denx.de, ivan.griffin@microchip.com, lewis.hanly@microchip.com, padmarao.begari@microchip.com, rick@andestech.com, u-boot@lists.denx.de, valentina.fernandezalanis@microchip.com, Michael Walle Subject: Re: [PATCH v1 4/5] net: macb: Compatible as per device tree Date: Thu, 11 Nov 2021 13:54:41 +0100 Message-Id: <20211111125441.3344243-1-michael@walle.cc> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > > If Linux driver does not need to be updated to support MPFS macb using > > existing compatible string but U-Boot driver has to, something is > > wrong on the U-Boot macb driver side. > > > > Would you please reconsider the whole changes? > > > We submitted patches(v1, v2) last year for the U-Boot MACB update for > 64-bit DMA access same like Linux MACB driver using "#ifdef > CONFIG_DMA_ADDR_T_64BIT" but one of the reviewer wanted to check 64-bit DMA > support at runtime instead of #ifdef and we updated the macb driver based > on the design config debug6 register of MACB hardware which supports 32-bit > or 64-bit DMA in patch(v3) but the SiFive FU540 MACB didn't work then the > reviewer suggested use compatible string instead of design config register > and updated same in patch(v4), these changes were tested and acknowledged > them at Patch v6. I agree with Bin here. You shouldn't introduce a new compatible just for u-boot. If you need one, please to it first in linux and get an ACK there. Or at least there should be patches for it pending in linux and it should be likely, that they will be accepted. Please work towards having one binding for u-boot and linux. -michael