Re: [PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3110 bytes --]

Hi Christoph,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to xfs-linux/for-next device-mapper-dm/for-next tytso-ext4/dev v5.15 next-20211111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christoph-Hellwig/nvdimm-pmem-move-dax_attribute_group-from-dax-to-pmem/20211109-173316
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d2f38a3c6507b2520101f9a3807ed98f1bdc545a
config: um-i386_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/5ea2c91584999019cd215022cca4d292c9296294
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christoph-Hellwig/nvdimm-pmem-move-dax_attribute_group-from-dax-to-pmem/20211109-173316
        git checkout 5ea2c91584999019cd215022cca4d292c9296294
        # save the attached .config to linux build tree
        make W=1 ARCH=um SUBARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/ext4/inode.c: In function 'ext4_block_zero_page_range':
>> fs/ext4/inode.c:3786:10: error: implicit declaration of function 'dax_zero_range'; did you mean 'iomap_zero_range'? [-Werror=implicit-function-declaration]
    3786 |   return dax_zero_range(inode, from, length, NULL,
         |          ^~~~~~~~~~~~~~
         |          iomap_zero_range
   cc1: some warnings being treated as errors


vim +3786 fs/ext4/inode.c

  3762	
  3763	/*
  3764	 * ext4_block_zero_page_range() zeros out a mapping of length 'length'
  3765	 * starting from file offset 'from'.  The range to be zero'd must
  3766	 * be contained with in one block.  If the specified range exceeds
  3767	 * the end of the block it will be shortened to end of the block
  3768	 * that corresponds to 'from'
  3769	 */
  3770	static int ext4_block_zero_page_range(handle_t *handle,
  3771			struct address_space *mapping, loff_t from, loff_t length)
  3772	{
  3773		struct inode *inode = mapping->host;
  3774		unsigned offset = from & (PAGE_SIZE-1);
  3775		unsigned blocksize = inode->i_sb->s_blocksize;
  3776		unsigned max = blocksize - (offset & (blocksize - 1));
  3777	
  3778		/*
  3779		 * correct length if it does not fall between
  3780		 * 'from' and the end of the block
  3781		 */
  3782		if (length > max || length < 0)
  3783			length = max;
  3784	
  3785		if (IS_DAX(inode)) {
> 3786			return dax_zero_range(inode, from, length, NULL,
  3787					      &ext4_iomap_ops);
  3788		}
  3789		return __ext4_block_zero_page_range(handle, mapping, from, length);
  3790	}
  3791	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 9895 bytes --]